Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
On Fri, Sep 9, 2016 at 6:09 PM, Davey Shafik wrote: > On Fri, Sep 9, 2016 at 6:05 PM, Stanislav Malyshev > wrote: > >> Hi! >> >> > As noted last week, I'm now opening up the vote for adding a PHP Engine >> > Identifier constant to PHP 7.2+ (and more importantly, to the language >> > spec). Addit

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Kalle Sommer Nielsen
2016-09-10 3:09 GMT+02:00 Davey Shafik : > Uh… wow. Lemme see if I can fix that without breaking the votes. > > Also, you only voted on the second vote. Was that intentional? Fixed it, voteType should be "single", not "multi" :) -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals -

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
On Fri, Sep 9, 2016 at 6:05 PM, Stanislav Malyshev wrote: > Hi! > > > As noted last week, I'm now opening up the vote for adding a PHP Engine > > Identifier constant to PHP 7.2+ (and more importantly, to the language > > spec). Additionally, there is a second vote to add corresponding > > PHP_ENG

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Stanislav Malyshev
Hi! > As noted last week, I'm now opening up the vote for adding a PHP Engine > Identifier constant to PHP 7.2+ (and more importantly, to the language > spec). Additionally, there is a second vote to add corresponding > PHP_ENGINE_(*_)VERSION(_ID) constants. > > https://wiki.php.net/rfc/php_engin

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
Kalle, My use case is for the php7-mysql-shim, some of the error messages I duplicate and therefore have tests for, are different on HHVM, meaning the tests fail. The messages aren't in the spec, so they're not failing to support the spec, and it's unlikely to affect functionality — which is why

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Kalle Sommer Nielsen
Hi Davey 2016-09-10 1:49 GMT+02:00 Davey Shafik : > Hi all, > > As noted last week, I'm now opening up the vote for adding a PHP Engine > Identifier constant to PHP 7.2+ (and more importantly, to the language > spec). Additionally, there is a second vote to add corresponding > PHP_ENGINE_(*_)VERSI

[PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
Hi all, As noted last week, I'm now opening up the vote for adding a PHP Engine Identifier constant to PHP 7.2+ (and more importantly, to the language spec). Additionally, there is a second vote to add corresponding PHP_ENGINE_(*_)VERSION(_ID) constants. https://wiki.php.net/rfc/php_engine_consta