Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-07-01 Thread Go Kudo
2022年6月29日(水) 17:40 Guilliam Xavier : > >> > https://wiki.php.net/rfc/random_extension_improvement > >> > >> I just realized a little thing: in the array_rand() example, for > >> $beforeSingle, it would probably be "more realistic" to omit `, 1` > >> (which is already the default for $num). > >> >

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-29 Thread Tim Düsterhus
Hi On 6/29/22 10:40, Guilliam Xavier wrote: pickArrayKeys [but the opposite would not be so], and I don't think that adding *both* methods to Randomizer is desirable either [better keep it simple/minimal]). Agreed. I think it's best to leave pickArrayKeys() as it is within the current version

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-29 Thread Guilliam Xavier
>> > https://wiki.php.net/rfc/random_extension_improvement >> >> I just realized a little thing: in the array_rand() example, for >> $beforeSingle, it would probably be "more realistic" to omit `, 1` >> (which is already the default for $num). >> >> Note: for `Randomizer::pickArrayKeys(array $array

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-28 Thread Go Kudo
2022年6月29日(水) 0:39 Guilliam Xavier : > > Hi Internals. > > > > Random Extension 5.x has been accepted by a vote of 20(+1)/0. (I made a > > mistake in timing the closing of the vote and thus received one more > vote) > > Therefore, voting on the Random Extension Improvement RFC will begin on > > 20

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-28 Thread Guilliam Xavier
> Hi Internals. > > Random Extension 5.x has been accepted by a vote of 20(+1)/0. (I made a > mistake in timing the closing of the vote and thus received one more vote) > Therefore, voting on the Random Extension Improvement RFC will begin on > 2022-07-02 as scheduled. > > Please check the RFC. Thi

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-28 Thread Go Kudo
2022年6月18日(土) 4:42 Go Kudo : > Hi internals. > > An RFC has been created to fix an issue in Random Extension 5.x. > > https://wiki.php.net/rfc/random_extension_improvement > > Voting on this RFC will begin in two weeks (2022-07-02), in time for the > PHP 8.2 Feature Freeze. (Vote finished in 2022-

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-23 Thread Go Kudo
2022年6月23日(木) 0:02 Tim Düsterhus : > Hi > > On 6/22/22 16:35, Go Kudo wrote: > > No additional comments seemed to be forthcoming, so the RFC was upgraded > to > > 1.5. > > The following changes have been made > > > > https://wiki.php.net/rfc/random_extension_improvement > > > > 1. Add: `Refine cla

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-22 Thread Tim Düsterhus
Hi On 6/22/22 16:35, Go Kudo wrote: No additional comments seemed to be forthcoming, so the RFC was upgraded to 1.5. The following changes have been made https://wiki.php.net/rfc/random_extension_improvement 1. Add: `Refine classnames` 2. Add: `Random\SerializableEngine is outdated` 3. Add `Ad

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-22 Thread Go Kudo
2022年6月18日(土) 4:42 Go Kudo : > Hi internals. > > An RFC has been created to fix an issue in Random Extension 5.x. > > https://wiki.php.net/rfc/random_extension_improvement > > Voting on this RFC will begin in two weeks (2022-07-02), in time for the > PHP 8.2 Feature Freeze. (Vote finished in 2022-

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-21 Thread Go Kudo
2022年6月21日(火) 18:23 Guilliam Xavier : > On Mon, Jun 20, 2022 at 5:25 PM Christoph M. Becker > wrote: > > > > On 20.06.2022 at 16:44, Go Kudo wrote: > > > > > 2022年6月20日(月) 23:37 Lynn : > > > > > >> On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier < > guilliam.xav...@gmail.com > > >> wrote: > > >>

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-21 Thread Guilliam Xavier
On Mon, Jun 20, 2022 at 5:25 PM Christoph M. Becker wrote: > > On 20.06.2022 at 16:44, Go Kudo wrote: > > > 2022年6月20日(月) 23:37 Lynn : > > > >> On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier >> wrote: > >> > https://wiki.php.net/rfc/random_extension_improvement > >>> > >>> Thanks, but I am

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 07:20, Go Kudo wrote: What about a signature like `Randomizer::pickArrayKeys(array $array, int $num): array`? The previous behavior when `int $num` is 1 can be easily reproduced as follows: ```php $randomizer = new Random\Randomizer(new Random\Engine\Mt19937(1234, MT_RAND_PHP)); [

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月21日(火) 0:42 Tim Düsterhus : > Hi > > On 6/20/22 17:12, Go Kudo wrote: > >> CombinedLCG > > > > This is provided as an OOP implementation for the `lcg_value()` function, > > but I don't actually > > want it to be used anymore, so I probably shouldn't provide a class for > it. > > > > And to

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 17:12, Go Kudo wrote: CombinedLCG This is provided as an OOP implementation for the `lcg_value()` function, but I don't actually want it to be used anymore, so I probably shouldn't provide a class for it. And to begin with, the current CombinedLCG cannot even be seeded with arbi

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Tim Düsterhus
Hi On 6/20/22 16:57, Nicolas Grekas wrote: I'm wondering: does Random\SerializableEngine extend Random\Engine? Can this be mentioned in the RFC? If not, what about making it this way? Having this interface only contain __(un)serialize would look strange to me, aka too broad for the name and the

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Christoph M. Becker
On 20.06.2022 at 16:44, Go Kudo wrote: > 2022年6月20日(月) 23:37 Lynn : > >> On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier > wrote: >> https://wiki.php.net/rfc/random_extension_improvement >>> >>> Thanks, but I am not sure about your argument in "Classnames are not >>> canonicalized": does "PHP

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月20日(月) 23:58 Nicolas Grekas : > > An RFC has been created to fix an issue in Random Extension 5.x. > > > > https://wiki.php.net/rfc/random_extension_improvement > > > > Voting on this RFC will begin in two weeks (2022-07-02), in time for the > > PHP 8.2 Feature Freeze. (Vote finished in 202

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Nicolas Grekas
> An RFC has been created to fix an issue in Random Extension 5.x. > > https://wiki.php.net/rfc/random_extension_improvement > > Voting on this RFC will begin in two weeks (2022-07-02), in time for the > PHP 8.2 Feature Freeze. (Vote finished in 2022-07-16, Feature Freeze is > 2022-07-19) > > In th

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月20日(月) 23:37 Lynn : > On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier > > wrote: > > > Hi, > > > > > https://wiki.php.net/rfc/random_extension_improvement > > > > Thanks, but I am not sure about your argument in "Classnames are not > > canonicalized": does "PHP applies strict PascalCase to

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Lynn
On Mon, Jun 20, 2022 at 3:15 PM Guilliam Xavier wrote: > Hi, > > > https://wiki.php.net/rfc/random_extension_improvement > > Thanks, but I am not sure about your argument in "Classnames are not > canonicalized": does "PHP applies strict PascalCase to class names" > (which remains to be proved) re

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Go Kudo
2022年6月20日(月) 22:16 Guilliam Xavier : > Hi, > > > https://wiki.php.net/rfc/random_extension_improvement > > Thanks, but I am not sure about your argument in "Classnames are not > canonicalized": does "PHP applies strict PascalCase to class names" > (which remains to be proved) really imply to rena

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-20 Thread Guilliam Xavier
Hi, > https://wiki.php.net/rfc/random_extension_improvement Thanks, but I am not sure about your argument in "Classnames are not canonicalized": does "PHP applies strict PascalCase to class names" (which remains to be proved) really imply to rename *acronyms* (e.g. "CombinedLCG" to "CombinedLcg")

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-19 Thread Go Kudo
2022年6月19日(日) 16:25 Marc : > Hi Go Kudo, > > About "pickArrayKey" I don't like the behavior change on number of array > keys to return either a single key or an array of keys. > It would be better to have different methods for both cases. > > Also it does not describe the behavior if you are reque

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-17 Thread Go Kudo
2022年6月18日(土) 4:50 Tim Düsterhus : > Hi > > On 6/17/22 21:41, Go Kudo wrote: > > https://wiki.php.net/rfc/random_extension_improvement > > > > There's still a section for array_rand() at the top of the RFC > ( > https://wiki.php.net/rfc/random_extension_improvement#randomizer_lacks_array_rand_repl

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-17 Thread Tim Düsterhus
Hi On 6/17/22 21:41, Go Kudo wrote: https://wiki.php.net/rfc/random_extension_improvement There's still a section for array_rand() at the top of the RFC (https://wiki.php.net/rfc/random_extension_improvement#randomizer_lacks_array_rand_replacement_method), but no voting section. My unders

[PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement

2022-06-17 Thread Go Kudo
Hi internals. An RFC has been created to fix an issue in Random Extension 5.x. https://wiki.php.net/rfc/random_extension_improvement Voting on this RFC will begin in two weeks (2022-07-02), in time for the PHP 8.2 Feature Freeze. (Vote finished in 2022-07-16, Feature Freeze is 2022-07-19) In th