Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-26 Thread Marc Bennewitz
On 21.06.22 01:01, Dan Ackroyd wrote: Hi, Following previous discussions, here is an RFC to have DB specific classes for PDO. https://wiki.php.net/rfc/pdo_driver_specific_subclasses Hi Dan, Thanks for your RFC! I do have some recommendations for it: 1. It would be great if driver specific

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-24 Thread Dan Ackroyd
On Tue, 21 Jun 2022 at 10:41, Rowan Tommins wrote: > > The implementation MUST be written by > someone with intimate knowledge of the DBMS in question, or it cannot be > trusted. Well, that rules me out of doing it. > So if we only have a Postgres implementation right now, we should either > im

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-24 Thread Dan Ackroyd
On Tue, 21 Jun 2022 at 02:26, Larry Garfield wrote: > > Any chance I could convince you to move away from the DSN for the factory? No. That sounds like a challenge for someone who knows about (and cares about) that problem. There's also not enough time to have that discussion before feature freez

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-21 Thread Rowan Tommins
On 21/06/2022 02:25, Larry Garfield wrote: * "Should the sub-classes only be avaiable when support for that DB is compiled in?" - I agree, probably not. Also, "available" is misspelled. * "Create all DB sub-classes?" - I'd say they all should have subclasses, even if empty. It's more consist

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-20 Thread Larry Garfield
On Mon, Jun 20, 2022, at 6:01 PM, Dan Ackroyd wrote: > Hi, > > Following previous discussions, here is an RFC to have DB specific > classes for PDO. > > https://wiki.php.net/rfc/pdo_driver_specific_subclasses > > cheers > Dan > Ack I'm conceptually in favor of this. A few comments: * Any chance

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-20 Thread Stephen Reay
Sent from my iPhone > On 21 Jun 2022, at 06:08, Dan Ackroyd wrote: > > Hi, > > Following previous discussions, here is an RFC to have DB specific > classes for PDO. > > https://wiki.php.net/rfc/pdo_driver_specific_subclasses > > cheers > Dan > Ack > > -- > PHP Internals - PHP Runtime D

[PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-20 Thread Dan Ackroyd
Hi, Following previous discussions, here is an RFC to have DB specific classes for PDO. https://wiki.php.net/rfc/pdo_driver_specific_subclasses cheers Dan Ack -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php