Hi,
I updated the RFC I added a second proposal where the only change would
be to throw exceptions by default in 8.3 instead of 9.0:
https://wiki.php.net/rfc/sqlite3_exceptions
I also changed the plan for 9.0:
"Calling SQLite3::enableExceptions(true) raises E_DEPRECATED, to alert
that the method
On 26.10.2022 at 08:57, Derick Rethans wrote:
> On 25 October 2022 14:10:14 CEST, BohwaZ wrote:
>
>> * but we make SQLite3 throw exceptions by default directly in PHP 8.3,
>> like it was done with PDO 2 years ago.
>
> I am not in favour, as it would mean that existing code suddenly may start
>
On 25 October 2022 14:10:14 CEST, BohwaZ wrote:
>* but we make SQLite3 throw exceptions by default directly in PHP 8.3,
> like it was done with PDO 2 years ago.
I am not in favour, as it would mean that existing code suddenly may start
breaking, as exceptions aren't expected (and hence not cat
On Tue, Oct 25, 2022, at 7:10 AM, BohwaZ wrote:
>> As others have said, the correct, responsible way to do this would be
>> to make it gradual and keep warnings working until 9.0. I would
>> recommend:
>>
>> 1. 8.3, enableExceptions(false) raises E_DEPRECATED.
>> 2. 9.0 enableExceptions() default
> As others have said, the correct, responsible way to do this would be
> to make it gradual and keep warnings working until 9.0. I would
> recommend:
>
> 1. 8.3, enableExceptions(false) raises E_DEPRECATED.
> 2. 9.0 enableExceptions() defaults to true, and calling it with false
> is an Error. (
On Sun, Oct 23, 2022, at 9:56 PM, BohwaZ wrote:
> Kia ora,
>
> I am proposing that the SQLite3 extension stops using warnings for
> errors and instead throws exceptions by default:
>
> https://wiki.php.net/rfc/sqlite3_exceptions
>
> Whether we just deprecate warnings first and default to exceptions
Hi,
I don't think we should be removing such large chunk of functionality in a
minor version. If you want to change the default to throw exceptions,
that's ok. But I wouldn't remove the method in 8.3 or 8.4 and only remove
it in 9.0. What is the advantage to removing the Warning mode?
Regards,
Ka
Am 24.10.2022 um 04:56 schrieb BohwaZ :
> I am proposing that the SQLite3 extension stops using warnings for
> errors and instead throws exceptions by default:
>
> https://wiki.php.net/rfc/sqlite3_exceptions
>
> Whether we just deprecate warnings first and default to exceptions, and
> then remove
Kia ora,
I am proposing that the SQLite3 extension stops using warnings for
errors and instead throws exceptions by default:
https://wiki.php.net/rfc/sqlite3_exceptions
Whether we just deprecate warnings first and default to exceptions, and
then remove warnings altogether in a later version, or
