Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-19 Thread Eric Norris
> Hi, > > Would be reasonable to be able to recover the stack trace of the error as a > string, in addition to the proposed format? In general, it is the format I > use in my error/exception handlers for convenience. > > A utility function that stringify the trace would be sufficient, as the > o

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-18 Thread Thomas Bley
> Claude Pache hat am 18.12.2024 22:59 CET geschrieben: > > > > Le 5 déc. 2024 à 21:57, Eric Norris a écrit : > > > > Hello yet again internals, > > > > I'd like to formally propose a continuation of the original error > > backtraces RFC (https://wiki.php.net/rfc/error_backtraces): > > >

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-18 Thread Claude Pache
> Le 5 déc. 2024 à 21:57, Eric Norris a écrit : > > Hello yet again internals, > > I'd like to formally propose a continuation of the original error > backtraces RFC (https://wiki.php.net/rfc/error_backtraces): > > https://wiki.php.net/rfc/error_backtraces_v2 > Hi, Would be reasonable to

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-10 Thread Eric Norris
> Yes, I agree that having a stacktracke for fatal errors is a non-issue. > For non-fatal errors the INI setting definitely is a problem. > Unconditionally having a stacktrace for non-fatal errors I'm am not yet > sure if this would be a problem or if it would be fine if it is a > RFC-agreed-upon (

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-09 Thread Tim Düsterhus
Hi Am 2024-12-06 02:08, schrieb Eric Norris: The “php.ini Defaults” section should probably refer to the voting widget as well. The first voting widget would probably be better phrased as: "Add the 'error_backtrace_recording' INI as described?" I'm a little nervous about this change, because

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-08 Thread Jakub Zelenka
On Sun, Dec 8, 2024 at 9:36 AM Jakub Zelenka wrote: > Hi, > > On Thu, Dec 5, 2024 at 10:02 PM Eric Norris > wrote: > >> Hello yet again internals, >> >> I'd like to formally propose a continuation of the original error >> backtraces RFC (https://wiki.php.net/rfc/error_backtraces): >> >> https://

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-08 Thread Jakub Zelenka
Hi, On Thu, Dec 5, 2024 at 10:02 PM Eric Norris wrote: > Hello yet again internals, > > I'd like to formally propose a continuation of the original error > backtraces RFC (https://wiki.php.net/rfc/error_backtraces): > > https://wiki.php.net/rfc/error_backtraces_v2 > > I would prefer this to be

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-05 Thread Eric Norris
Hello, On Thu, Dec 5, 2024 at 5:31 PM Tim Düsterhus wrote: > > Hi > > Thank you for your RFC. This time I'm making sure to comment already > during the discussion period :-) Haha, thank you! I appreciate the feedback as always. > > On 12/5/24 21:57, Eric Norris wrote: > > https://wiki.php.net/r

Re: [PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-05 Thread Tim Düsterhus
Hi Thank you for your RFC. This time I'm making sure to comment already during the discussion period :-) On 12/5/24 21:57, Eric Norris wrote: https://wiki.php.net/rfc/error_backtraces_v2 The RFC currently has two voting choices, the first is to accept an INI setting to configure an error mas

[PHP-DEV] [RFC] [Discussion] Error backtraces v2

2024-12-05 Thread Eric Norris
Hello yet again internals, I'd like to formally propose a continuation of the original error backtraces RFC (https://wiki.php.net/rfc/error_backtraces): https://wiki.php.net/rfc/error_backtraces_v2 We recently had a production incident that might have been shortened, had we been able to identify