Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-05-27 Thread Niels Dossche
On 22/05/2024 19:47, Niels Dossche wrote: > Okay, that seems reasonable to me and I can do that. > I'll make them return static and do "new static()" like I proposed with the > new static method. > > For XMLWriter, I suppose we also want the static counterparts: > * `XMLWriter::toMemory()` for `(

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-05-22 Thread Niels Dossche
On 21/05/2024 21:58, Claude Pache wrote: > > >> Le 21 mai 2024 à 21:00, Matthew Weier O'Phinney a >> écrit : >> >> (But again, I prefer that all those methods work on instances, as it was >> the case before PHP 8. They shouldn’t have been switched to >> static-but-broken-for-subclasses wi

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-05-21 Thread Claude Pache
> Le 21 mai 2024 à 21:00, Matthew Weier O'Phinney a > écrit : >> (But again, I prefer that all those methods work on instances, as it was the >> case before PHP 8. They shouldn’t have been switched to >> static-but-broken-for-subclasses without discussion.) > > Fixing the existing ones would

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-05-21 Thread Matthew Weier O'Phinney
On Tue, May 21, 2024 at 12:58 PM Claude Pache wrote: > > > > Le 18 mai 2024 à 01:13, Niels Dossche a écrit > : > > > > On 22/04/2024 20:41, Niels Dossche wrote: > >> Hi internals > >> > >> I'm opening the discussion for my RFC "Add openStream() to > XML{Reader,Writer}". > >> RFC link: https://wi

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-05-21 Thread Claude Pache
> Le 18 mai 2024 à 01:13, Niels Dossche a écrit : > > On 22/04/2024 20:41, Niels Dossche wrote: >> Hi internals >> >> I'm opening the discussion for my RFC "Add openStream() to >> XML{Reader,Writer}". >> RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams >> >> Kind regards >> Niels

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-24 Thread Niels Dossche
On 24/04/2024 10:22, Claude Pache wrote: > > >> Le 23 avr. 2024 à 21:23, Niels Dossche a écrit : >> >> On 22/04/2024 21:53, Larry Garfield wrote: >>> On Mon, Apr 22, 2024, at 6:41 PM, Niels Dossche wrote: Hi internals I'm opening the discussion for my RFC "Add openStream() to >>>

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-24 Thread Claude Pache
> Le 23 avr. 2024 à 21:23, Niels Dossche a écrit : > > On 22/04/2024 21:53, Larry Garfield wrote: >> On Mon, Apr 22, 2024, at 6:41 PM, Niels Dossche wrote: >>> Hi internals >>> >>> I'm opening the discussion for my RFC "Add openStream() to >>> XML{Reader,Writer}". >>> RFC link: https://wiki.p

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-23 Thread Niels Dossche
On 22/04/2024 21:53, Larry Garfield wrote: > On Mon, Apr 22, 2024, at 6:41 PM, Niels Dossche wrote: >> Hi internals >> >> I'm opening the discussion for my RFC "Add openStream() to >> XML{Reader,Writer}". >> RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams >> >> Kind regards >> Niels >

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-23 Thread Benjamin Außenhofer
On Mon, Apr 22, 2024 at 8:43 PM Niels Dossche wrote: > Hi internals > > I'm opening the discussion for my RFC "Add openStream() to > XML{Reader,Writer}". > RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams Not sure this needs an RFC. Its a sensible addition and the explanations make s

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-22 Thread Larry Garfield
On Mon, Apr 22, 2024, at 6:41 PM, Niels Dossche wrote: > Hi internals > > I'm opening the discussion for my RFC "Add openStream() to > XML{Reader,Writer}". > RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams > > Kind regards > Niels This seems quite reasonable to me overall. My one que

[PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-22 Thread Niels Dossche
Hi internals I'm opening the discussion for my RFC "Add openStream() to XML{Reader,Writer}". RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams Kind regards Niels