Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-05-30 Thread Matteo Beccati
Hi Internals, Il 09/05/2024 15:51, Derick Rethans ha scritto: On Thu, 9 May 2024, Matteo Beccati wrote: In any case I'm planning to start the vote in about 2 weeks from now. Next week I'll be organising phpday in Verona, so feel free to approach me if you are around and have any questions. I m

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-05-09 Thread Derick Rethans
On Thu, 9 May 2024, Matteo Beccati wrote: > Il 03/05/2024 11:14, Matteo Beccati ha scritto: > > > > I've updated once again the RFC and implemented most of the 3 major > > dialects (mysql, pgsql, sqlite) in the drivers. > > > > https://wiki.php.net/rfc/pdo_driver_specific_parsers > > > > https

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-05-09 Thread Matteo Beccati
Hi, Il 03/05/2024 11:14, Matteo Beccati ha scritto: Hi internals! I've updated once again the RFC and implemented most of the 3 major dialects (mysql, pgsql, sqlite) in the drivers. https://wiki.php.net/rfc/pdo_driver_specific_parsers https://github.com/php/php-src/pull/14035 I've tried to

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-05-03 Thread Matteo Beccati
Hi internals! I've updated once again the RFC and implemented most of the 3 major dialects (mysql, pgsql, sqlite) in the drivers. https://wiki.php.net/rfc/pdo_driver_specific_parsers https://github.com/php/php-src/pull/14035 I've tried to keep syntax changes we might not want as separate com

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-23 Thread Matteo Beccati
Hi Saki, internals, Il 17/04/2024 16:30, Saki Takamachi ha scritto: Hi Matteo, Thanks for the feedback. I will reference this issue as duplicate too in the RFC. Thanks for the reference to the issue. I'm certain if we dig deep enough we'll find a few more. Agree. Maybe we can find some

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Matteo Beccati
Hi Kamil, Il 17/04/2024 19:25, Kamil Tekiela ha scritto: I think the question here was more about what the syntax will be after the parameters are substituted. But if I recall correctly, the quoting is done by PDO:: quote so the syntax will remain the same. Only the buggy behavior would be fix

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Larry Garfield
On Wed, Apr 17, 2024, at 4:19 PM, Matteo Beccati wrote: > Hey Larry, > > Il 17/04/2024 16:51, Larry Garfield ha scritto: >> This all seems logical, but having separate parsers would mean that the SQL >> strings are no longer portable, yes? Eg, many frameworks and CMSes try to >> (claim to) suppo

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Matteo Beccati
Hi, On Wed, 17 Apr 2024, at 19:25, Kamil Tekiela wrote: > I think the question here was more about what the syntax will be after the > parameters are substituted. But if I recall correctly, the quoting is done by > PDO:: quote so the syntax will remain the same. Only the buggy behavior would >

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Kamil Tekiela
I think the question here was more about what the syntax will be after the parameters are substituted. But if I recall correctly, the quoting is done by PDO:: quote so the syntax will remain the same. Only the buggy behavior would be fixed when it comes to recognizing parameters.

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Matteo Beccati
Hey Larry, Il 17/04/2024 16:51, Larry Garfield ha scritto: This all seems logical, but having separate parsers would mean that the SQL strings are no longer portable, yes? Eg, many frameworks and CMSes try to (claim to) support multiple DBs transparently. (MySQL and Postgres and SQLite, usu

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Calvin Buckley
On Apr 17, 2024, at 9:24 AM, Matteo Beccati wrote: > > Hello everybody, > > I'd like to start a discussion on a new RFC about fixing the default PDO SQL > parser and having (optional) driver-specific parsers. > > https://wiki.php.net/rfc/pdo_driver_specific_parsers > > Thanks GPB and Tom de W

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Larry Garfield
On Wed, Apr 17, 2024, at 2:45 PM, Matteo Beccati wrote: > Hi Saki, > > Il 17/04/2024 16:30, Saki Takamachi ha scritto: >> Hi Matteo, >> >>> Thanks for the feedback. I will reference this issue as duplicate too in >>> the RFC. >> >> Thanks for the reference to the issue. >> >> >>> I'm certain i

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Matteo Beccati
Hi Saki, Il 17/04/2024 16:30, Saki Takamachi ha scritto: Hi Matteo, Thanks for the feedback. I will reference this issue as duplicate too in the RFC. Thanks for the reference to the issue. I'm certain if we dig deep enough we'll find a few more. Agree. Maybe we can find something other

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Saki Takamachi
Hi Matteo, > Thanks for the feedback. I will reference this issue as duplicate too in the > RFC. Thanks for the reference to the issue. > I'm certain if we dig deep enough we'll find a few more. Agree. Maybe we can find something other than PostgreSQL. I have read through your RFC. If we c

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Matteo Beccati
Hi Saki, Il 17/04/2024 16:03, Saki Takamachi ha scritto: This is a very interesting topic for me. A few days ago I saw an issue that was largely related to this. https://github.com/php/php-src/issues/13958 It seems possible to get around this problem using some hacks, but essentially I agree

Re: [PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Saki Takamachi
Hi Matteo, > 2024/04/17 21:24、Matteo Beccati のメール: > > Hello everybody, > > I'd like to start a discussion on a new RFC about fixing the default PDO SQL > parser and having (optional) driver-specific parsers. > > https://wiki.php.net/rfc/pdo_driver_specific_parsers > > Thanks GPB and Tom de W

[PHP-DEV] [RFC][Discussion] PDO driver specific parsers

2024-04-17 Thread Matteo Beccati
Hello everybody, I'd like to start a discussion on a new RFC about fixing the default PDO SQL parser and having (optional) driver-specific parsers. https://wiki.php.net/rfc/pdo_driver_specific_parsers Thanks GPB and Tom de Wit for their help with initial proof-reading. Cheers -- Matteo Becc