On 24/12/11 15:55, Lester Caine wrote:
> I'm with Derek ... having commits that are just WS corrections can be
> irritating when tracking changes ... but it would most definitely
> better to get them fixed before moving to git which would lump mass
> commits like that together in a change set and m
Hi!
It's not only bad for merges, also confusing with blame/annotate while
identifying the reason for bug.
As soon as we move to git, IIRC git has ability to separate ws-changes
from non-ws ones and do diffs/history while ignoring ws. I didn't figure
out if you can do non-ws merge (I suspect
Pierre Joye wrote:
Laruence refers to the PHP C source code and removing trailing white
>> spaces is a good thing as it is part of our CS.
>>
>> Go ahead Laruence:)
>
> Please don't. Changing whitespace en-masse makes it a royal pain to do
> merges later. Please just fix them when you change
Hi:
It is necessary that highlight the tail ws in view svn. that can help
us avoid adding more tail ws ..
:)
thanks
2011/12/24 Pierre Joye :
> 2011/12/24 Johannes Schlüter :
>
>> It's not only bad for merges, also confusing with blame/annotate while
>> identifying the reason for bug.
>
> Huh, s
2011/12/24 Johannes Schlüter :
> It's not only bad for merges, also confusing with blame/annotate while
> identifying the reason for bug.
Huh, since when do we commit or recommend to commit WS changes with
actual changes?
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
On Sat, Dec 24, 2011 at 12:56 PM, Derick Rethans wrote:
> On Sat, 24 Dec 2011, Pierre Joye wrote:
>
>> Laruence refers to the PHP C source code and removing trailing white
>> spaces is a good thing as it is part of our CS.
>>
>> Go ahead Laruence :)
>
> Please don't. Changing whitespace en-masse m
2011/12/24 Johannes Schlüter :
> On Sat, 2011-12-24 at 11:56 +, Derick Rethans wrote:
>> On Sat, 24 Dec 2011, Pierre Joye wrote:
>>
>> > Laruence refers to the PHP C source code and removing trailing white
>> > spaces is a good thing as it is part of our CS.
>> >
>> > Go ahead Laruence :)
>>
>>
On Sat, 2011-12-24 at 11:56 +, Derick Rethans wrote:
> On Sat, 24 Dec 2011, Pierre Joye wrote:
>
> > Laruence refers to the PHP C source code and removing trailing white
> > spaces is a good thing as it is part of our CS.
> >
> > Go ahead Laruence :)
>
> Please don't. Changing whitespace en-
On Sat, 24 Dec 2011, Pierre Joye wrote:
> Laruence refers to the PHP C source code and removing trailing white
> spaces is a good thing as it is part of our CS.
>
> Go ahead Laruence :)
Please don't. Changing whitespace en-masse makes it a royal pain to do
merges later. Please just fix them whe
Oh, shame on my, I was thinking about PHP code. Even so, this is
coding standards for PHP C code. Have we this? This can be a good one.
On Sat, Dec 24, 2011 at 9:11 AM, Pierre Joye wrote:
> hi!
>
> Laruence refers to the PHP C source code and removing trailing white
> spaces is a good thing as it
hi!
Laruence refers to the PHP C source code and removing trailing white
spaces is a good thing as it is part of our CS.
Go ahead Laruence :)
On Sat, Dec 24, 2011 at 12:09 PM, Rafael Kassner wrote:
> AFAIK, PHP files are transformed in bytecode before the execution, so
> white spaces will not i
AFAIK, PHP files are transformed in bytecode before the execution, so
white spaces will not interfere in nothing except more time to
transfer the file over SFTP.
It's pretty good to implement on our IDEs (and a lot of them is doing
it), once trailing white spaces are annoying while we are developi
Hi:
I noted there are a lot of tail white spaces in our codes,
it is better to remove them all, and we also should watch such ws
in furture.
a simple way to erase such ws in vim, use :%s /\s\+$//g
thanks
--
Laruence Xinchen Hui
http://www.laruence.com/
--
PHP Internals - PHP Run
13 matches
Mail list logo
