Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Pierre Joye
btw, pls commit to 5.3 after 5.3.8 (to be pkged today) On Mon, Aug 22, 2011 at 12:04 PM, Andrey Hristov wrote: >  Hi, > I have a fix, currently running the full test suite. Will commit soon. > > Best, > Andrey > > On 08/22/2011 11:56 AM, Pierre Joye wrote: >> >> it is attached to the bug :) >> >>

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Andrey Hristov
Hi, I have a fix, currently running the full test suite. Will commit soon. Best, Andrey On 08/22/2011 11:56 AM, Pierre Joye wrote: it is attached to the bug :) On Mon, Aug 22, 2011 at 11:47 AM, Andrey Hristov wrote: Hi, On 08/22/2011 10:40 AM, Laruence wrote: georg, andery, ulf:

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Pierre Joye
it is attached to the bug :) On Mon, Aug 22, 2011 at 11:47 AM, Andrey Hristov wrote: >  Hi, > > On 08/22/2011 10:40 AM, Laruence wrote: >> >> georg, andery, ulf: >> >>     hello,  there is a bug in mysqlnd,  the details about this bug can >> be found at https://bugs.php.net/bug.php?id=55473 >> >>

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Andrey Hristov
Hi, On 08/22/2011 10:40 AM, Laruence wrote: georg, andery, ulf: hello, there is a bug in mysqlnd, the details about this bug can be found at https://bugs.php.net/bug.php?id=55473 I found the reason is that mysqlnd_connect didn't free the stream when doing reconnect. I have s

[PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Laruence
georg, andery, ulf: hello, there is a bug in mysqlnd, the details about this bug can be found at https://bugs.php.net/bug.php?id=55473 I found the reason is that mysqlnd_connect didn't free the stream when doing reconnect. I have submitted a patch for this, but I am not very sure