On Tue, Mar 13, 2012 at 10:46 AM, Osama Abu Elsorour
wrote:
> [snip]
> + zval *_temp_callback = NULL;
> + MAKE_STD_ZVAL(_temp_callback);
> + *_temp_callback = *arg;
> + zval_copy_ctor(_temp_callback);
May I ask where you got this pattern for
Hi,
A few comments on the patch:
A) for licensing reasons we should try to keep as few readline only things as
possible in there (gpl vs. php license)
B) thread safty isn't an issue for readline but you still should do the init
and deinit in rinit/rshutdown not minit/mshutdown, probably also do
I was recently involved in a project that relied heavily on readline to provide
console text input capabilities. However I soon noticed that the current
readline is lacking some important functionality.
This patch applies only to PHP compiled with libreadline (and don't have an
effect if compil
