Re: [PHP-DEV] [PATCH] mysqli: remove global symbols

2005-03-29 Thread Andi Gutmans
Looks fine to me. At 01:11 PM 3/24/2005 +, Joe Orton wrote: Any objections to this patch? mysqli is defining a bunch of global symbols which it looks like it doesn't need to. Not urgent for 5.0.4. --- php-5.0.3/ext/mysqli/mysqli_prop.c.mysqliglobal +++ php-5.0.3/ext/mysqli/mysqli_prop.c @@ -5

Re: [PHP-DEV] [PATCH] mysqli: remove global symbols

2005-03-25 Thread Jani Taskinen
If anyone objects, they'll morons. Just commit. --Jani On Thu, 24 Mar 2005, Joe Orton wrote: Any objections to this patch? mysqli is defining a bunch of global symbols which it looks like it doesn't need to. Not urgent for 5.0.4. --- php-5.0.3/ext/mysqli/mysqli_prop.c.mysqliglobal +++ php

[PHP-DEV] [PATCH] mysqli: remove global symbols

2005-03-24 Thread Joe Orton
Any objections to this patch? mysqli is defining a bunch of global symbols which it looks like it doesn't need to. Not urgent for 5.0.4. --- php-5.0.3/ext/mysqli/mysqli_prop.c.mysqliglobal +++ php-5.0.3/ext/mysqli/mysqli_prop.c @@ -57,7 +57,7 @@ p = (MYSQL_STMT *)((MY_STMT *)((MYSQLI_RESOURCE *