Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-30 Thread Sterling Hughes
Rob Richards wrote: From: Andi Gutmans zend_is_executing() might work, but that is only if this method can only be called during script execution (which I'm not sure of). I'm also not sure if this is reset to 0 at the end of each request but that should be easy to fix. Yup, this method should onl

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-30 Thread Rob Richards
From: Andi Gutmans > zend_is_executing() might work, but that is only if this method can only be > called during script execution (which I'm not sure of). I'm also not sure > if this is reset to 0 at the end of each request but that should be easy to > fix. Yup, this method should only be called

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-30 Thread Andi Gutmans
zend_is_executing() might work, but that is only if this method can only be called during script execution (which I'm not sure of). I'm also not sure if this is reset to 0 at the end of each request but that should be easy to fix. Andi At 11:54 AM 5/28/2004 -0400, Rob Richards wrote: Is it poss

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-28 Thread Rob Richards
From: "Rasmus Lerdorf" <[EMAIL PROTECTED]> > I am not sure how. We know if we are in the middle of parsing a PHP > script, but that doesn't necessarily mean that the libxml call is from a > PHP context. We could be calling some 3rd-party library that knows > nothing about PHP that happens to use

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-28 Thread Rasmus Lerdorf
On Fri, 28 May 2004, Rob Richards wrote: > Is it possible to know wether a function is being called from a php context > or not? I am not sure how. We know if we are in the middle of parsing a PHP script, but that doesn't necessarily mean that the libxml call is from a PHP context. We could be c

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-28 Thread Rob Richards
Is it possible to know wether a function is being called from a php context or not? If so, a check could be done in php_libxml_streams_IO_match_wrapper which if not under the php context, it would return 0 thus making the php registered streams useless for other applications. I also got a reponse

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-28 Thread Rob Richards
If you are talking about the libxml_set_streams_context, the php streams are registered by default so that function is not even used unless explicitly called to use a specific stream. I also dont see how that patch could work as in the request shutdown, it calls xmlRegisterDefaultInputCallbacks whi

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-27 Thread Rasmus Lerdorf
Is it not possible to do this at the time set_streams_context is called? I am weary of having this done per-request for all PHP requests regardless of whether or not they actually call anything in libxml. -Rasmus On Fri, 28 May 2004, Andi Gutmans wrote: > Anyone see a problem with this patch?

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-27 Thread Andi Gutmans
Anyone see a problem with this patch? If not, I'd like to include it in RC3 because it makes sense. Andi At 10:13 PM 5/26/2004 -0700, Paul Querna wrote: Patch Moves the Registering of the PHP XML Streams to the request init, instead of installing them globaly in the Module init. This is needed if

[PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

2004-05-26 Thread Paul Querna
Patch Moves the Registering of the PHP XML Streams to the request init, instead of installing them globaly in the Module init. This is needed if any other Apache modules use libxml2 on a non-php request. If this patch is not applied, any other use of libxml2 in the same process will likely fail w