Re: [PHP-DEV] [PATCH] fix imap_mail actually use the rpath option

2011-08-04 Thread Johannes Schlüter
Hi, few comments just from reading the patch, not the full context, not testing it: On Thu, 2011-08-04 at 16:30 +0100, Keloran wrote: > Index: ext/imap/php_imap.c > === > --- ext/imap/php_imap.c (revision 314217) > +++ ext/imap/php_i

Re: [PHP-DEV] [PATCH] fix imap_mail actually use the rpath option

2011-08-04 Thread Keloran
cool, thanks that patch is for 5.4 (since the line nums changed from 5.3-5.4, On Thu, Aug 4, 2011 at 5:19 PM, Pierre Joye wrote: > I have now attached the patch to the issue: > https://bugs.php.net/bug.php?id=30688 > > On Thu, Aug 4, 2011 at 6:07 PM, Keloran wrote: > > patch attached > > > > O

Re: [PHP-DEV] [PATCH] fix imap_mail actually use the rpath option

2011-08-04 Thread Pierre Joye
I have now attached the patch to the issue: https://bugs.php.net/bug.php?id=30688 On Thu, Aug 4, 2011 at 6:07 PM, Keloran wrote: > patch attached > > On Thu, Aug 4, 2011 at 4:39 PM, Pierre Joye wrote: >> >> hi, >> >> Can you attach this patch to the bug please? >> >> Thanks for your work! >> >>

Re: [PHP-DEV] [PATCH] fix imap_mail actually use the rpath option

2011-08-04 Thread Keloran
patch attached On Thu, Aug 4, 2011 at 4:39 PM, Pierre Joye wrote: > hi, > > Can you attach this patch to the bug please? > > Thanks for your work! > > On Thu, Aug 4, 2011 at 5:30 PM, Keloran wrote: > > Index: ext/imap/php_imap.c > > ==

Re: [PHP-DEV] [PATCH] fix imap_mail actually use the rpath option

2011-08-04 Thread Pierre Joye
hi, Can you attach this patch to the bug please? Thanks for your work! On Thu, Aug 4, 2011 at 5:30 PM, Keloran wrote: > Index: ext/imap/php_imap.c > === > --- ext/imap/php_imap.c (revision 314217) > +++ ext/imap/php_imap.c (working

[PHP-DEV] [PATCH] fix imap_mail actually use the rpath option

2011-08-04 Thread Keloran
Index: ext/imap/php_imap.c === --- ext/imap/php_imap.c (revision 314217) +++ ext/imap/php_imap.c (working copy) @@ -4016,7 +4016,27 @@ if (!INI_STR("sendmail_path")) { return 0; } - sendmail = pope