Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Felipe Pena
Hi Chris, 2010/11/19 Chris Stockton > On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton wrote: > > The check to prevent extract() overwriting $GLOBALS got broken at some > > point - here's a fix: > > I remember http://bugs.php.net/47409 for this some time ago and seeing > it marked applied. After taki

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Felipe Pena
Hi, 2010/11/19 Joe Orton > The check to prevent extract() overwriting $GLOBALS got broken at some > point - here's a fix: > > Index: ext/standard/array.c > === > --- ext/standard/array.c(revision 305556) > +++ ext/standard/a

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Chris Stockton
On Fri, Nov 19, 2010 at 8:43 AM, Joe Orton wrote: > The check to prevent extract() overwriting $GLOBALS got broken at some > point - here's a fix: I remember http://bugs.php.net/47409 for this some time ago and seeing it marked applied. After taking a peak it looks like the patch in the bug repor

[PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Joe Orton
The check to prevent extract() overwriting $GLOBALS got broken at some point - here's a fix: Index: ext/standard/array.c === --- ext/standard/array.c(revision 305556) +++ ext/standard/array.c(working copy) @@ -1389,10