Re: [PHP-DEV] [PATCH] default session serialization

2009-11-26 Thread Arpad Ray
On Thu, Nov 26, 2009 at 2:23 PM, Antony Dovgal wrote: > On 26.11.2009 03:43, Stanislav Malyshev wrote: > > I think it makes sense. One note: your code allows numeric session keys, > > previously not allowed. Not sure if it's important. > > This might be important for 32bit<->64bit interaction usi

Re: [PHP-DEV] [PATCH] default session serialization

2009-11-26 Thread Antony Dovgal
On 26.11.2009 03:43, Stanislav Malyshev wrote: > I think it makes sense. One note: your code allows numeric session keys, > previously not allowed. Not sure if it's important. This might be important for 32bit<->64bit interaction using serialized data. -- Wbr, Antony Dovgal --- http://pinba.or

Re: [PHP-DEV] [PATCH] default session serialization

2009-11-25 Thread Stanislav Malyshev
Hi! Attached is a patch (against HEAD) which adapts the default ("php") session serializer to serialize the whole array using php_var_serialize instead of calling it once per element. This simplifies the serialization code, and allows unicode session keys, or even ascii keys containing the p

Re: [PHP-DEV] [PATCH] default session serialization

2009-11-21 Thread Michael Shadle
On Sat, Nov 21, 2009 at 9:16 PM, Arpad Ray wrote: > However it would be a significant BC break, as old serialized session > records would be unreadable after upgrading. We could mitigate this by > providing a script to convert old session files. I would say just a note saying "old session files

[PHP-DEV] [PATCH] default session serialization

2009-11-21 Thread Arpad Ray
Hi, Attached is a patch (against HEAD) which adapts the default ("php") session serializer to serialize the whole array using php_var_serialize instead of calling it once per element. This simplifies the serialization code, and allows unicode session keys, or even ascii keys containing the pipe c