Re: [PHP-DEV] [PATCH] apache2handler memory leak fix

2004-06-25 Thread Edin Kadribasic
Thanks. The patch is committed to both php4 and php5. Edin On Friday 25 June 2004 13:39, Joe Orton wrote: > [resend, see followup to old thread for patch to HEAD] > > It's simpler to just use the ap_r* interfaces in the the handler SAPI > for 2.0, this improves network usage by allowing httpd to

[PHP-DEV] [PATCH] apache2handler memory leak fix

2004-06-25 Thread Joe Orton
[resend, see followup to old thread for patch to HEAD] It's simpler to just use the ap_r* interfaces in the the handler SAPI for 2.0, this improves network usage by allowing httpd to buffer as necessary, and fixes a bug where ub_write is unnecessarily pmemdup'ing the string (it could have used a t

Re: [PHP-DEV] [PATCH] apache2handler memory leak fix

2004-06-18 Thread Joe Orton
On Fri, Jun 18, 2004 at 02:13:05PM +0200, Magnus MÃÃttà wrote: > Hi! > > On Friday 18 June 2004 12.30, Joe Orton wrote: > > It's simpler to just use the ap_r* interfaces in the the handler SAPI > > for 2.0, this improves network usage by allowing httpd to buffer as > > necessary, and fixes a bug w

Re: [PHP-DEV] [PATCH] apache2handler memory leak fix

2004-06-18 Thread Magnus Määttä
Hi! On Friday 18 June 2004 12.30, Joe Orton wrote: > It's simpler to just use the ap_r* interfaces in the the handler SAPI > for 2.0, this improves network usage by allowing httpd to buffer as > necessary, and fixes a bug where ub_write is unnecessarily pmemdup'ing > the string (it could have used

[PHP-DEV] [PATCH] apache2handler memory leak fix

2004-06-18 Thread Joe Orton
It's simpler to just use the ap_r* interfaces in the the handler SAPI for 2.0, this improves network usage by allowing httpd to buffer as necessary, and fixes a bug where ub_write is unnecessarily pmemdup'ing the string (it could have used a transient bucket to avoid that; the apache2filter got thi