Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-13 Thread Marcus Boerger
Hello Greg, Friday, September 12, 2008, 11:35:11 PM, you wrote: > Marcus Boerger wrote: >> Hello Greg, >> >> please don't > OK. Nice working with you Marcus, this is high class stuff. I'm glad > to see the work I'm doing is taken so seriously. Args, sorry if you got this wrong. I think you

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-13 Thread Lukas Kahwe Smith
On 12.09.2008, at 23:35, Greg Beaver wrote: Marcus Boerger wrote: Hello Greg, please don't OK. Nice working with you Marcus, this is high class stuff. I'm glad to see the work I'm doing is taken so seriously. Greg, as you can see several people think its better to ensure that namespa

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Stan Vassilev | FM
Hi, I just figured a problem related to this. We have multiple namespaces per file so we can merge multiple files together. We have no way to break out to global space after a namespace, and even with this patch, no *code* can exist before a namespace. So this means we can only merge files

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Stan Vassilev | FM
Hi, I'm in favor of this patch for simple reason that the "nothing before the first namespace" limitation is more of a WTF than a sound design prevented to limit an actual problem. We have multiple namespaces per file, so having some of the file in the global namespace (i.e. == no namespace

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Johannes Schlüter
Hi, On Fri, 2008-09-12 at 14:11 -0500, Greg Beaver wrote: > This is a simple patch that allows files like this: > > main.php: > > [...] > namespace my::template; > // stuff > ?> I'd prefer: main.php: looks cleaner imo. johannes -- PHP Internals - PHP Runtime Development Mailing Li

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Ryan Panning
David Coallier wrote: 2008/9/12 Greg Beaver <[EMAIL PROTECTED]>: Hi, This is a simple patch that allows files like this: main.php: template example Is it me or this doesn't look really clean? I have a clear idea that namespaces are there to add an extra structural layer to the code

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Stanislav Malyshev
Hi! the issue is without the patch, even an empty space or a newline at the start of a file will cause a fatal error That's good. There should be no unaccounted newlines or empty spaces in PHP code. I had not once things break because somebody left whitespace floating around in some script a

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Greg Beaver
Marcus Boerger wrote: > Hello Greg, > > please don't OK. Nice working with you Marcus, this is high class stuff. I'm glad to see the work I'm doing is taken so seriously. Bye for now, Greg -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsu

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Elizabeth M Smith
Lucas Stephanou wrote: > My first msg in this list > > And I agree with you David. > > Mix html and namespace is very very ugly. > > > > 2008/9/12 David Coallier <[EMAIL PROTECTED]>: >> 2008/9/12 Greg Beaver <[EMAIL PROTECTED]>: >>> Hi, >>> >>> This is a simple patch that allows files like thi

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Marcus Boerger
Hello Greg, please don't. marcus Friday, September 12, 2008, 9:11:39 PM, you wrote: > Hi, > This is a simple patch that allows files like this: > main.php: > > > template example > > > > namespace my::template; > // stuff ?>> > > to work without parse error. > Greg > P.S. thi

[PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Lucas Stephanou
My first msg in this list And I agree with you David. Mix html and namespace is very very ugly. 2008/9/12 David Coallier <[EMAIL PROTECTED]>: > 2008/9/12 Greg Beaver <[EMAIL PROTECTED]>: >> Hi, >> >> This is a simple patch that allows files like this: >> >> main.php: >> >> >> >> template ex

Re: [PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread David Coallier
2008/9/12 Greg Beaver <[EMAIL PROTECTED]>: > Hi, > > This is a simple patch that allows files like this: > > main.php: > > > > template example > > > > namespace my::template; > // stuff > ?> > > Is it me or this doesn't look really clean? I have a clear idea that namespaces are there to a

[PHP-DEV] [PATCH] allow T_INLINE_HTML before T_NAMESPACE

2008-09-12 Thread Greg Beaver
Hi, This is a simple patch that allows files like this: main.php: template example to work without parse error. Greg P.S. this is the last outstanding namespace issue that I'm aware of aside from the bracket wars, which is 100% philosophical, all the issues fixed by my patches are