Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-17 Thread Matt Wilmas
Thanks Tony! - Original Message - From: "Antony Dovgal" Sent: Thursday, April 17, 2008 > On 17.04.2008 14:54, Matt Wilmas wrote: > > Well, now that I have a php.net account, and 5.2.6 will be released, can > > someone change my name? :-) Unless I'm granted access to do it myself...? > >

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-17 Thread Antony Dovgal
On 17.04.2008 14:54, Matt Wilmas wrote: Well, now that I have a php.net account, and 5.2.6 will be released, can someone change my name? :-) Unless I'm granted access to do it myself...? Done =) Didn't know that about short names -- I see my name 11 times in the 5.2 NEWS, and the last 6 are

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-17 Thread Matt Wilmas
Hello guys, - Original Message - From: "Philip Olson" Sent: Thursday, April 10, 2008 > On 10 Apr 2008, at 09:48, Marcus Boerger wrote: > > Hello Matt, > > > > Thursday, April 10, 2008, 3:50:41 PM, you wrote: > > > >> Hi Scott, > >> [...] > >> BTW, maybe you could change the name in that 5

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-10 Thread Nuno Lopes
Patch applied, thanks! I haven't merged my other patch to HEAD yet, but I'll do so ASAP. Thanks, Nuno - Original Message - Hi Scott, I noticed that Nuno changed yyless() to be like flex after your commit (not in HEAD? I considered that, but figured you guys wanted it different :-))

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-10 Thread Philip Olson
On 10 Apr 2008, at 09:48, Marcus Boerger wrote: Hello Matt, Thursday, April 10, 2008, 3:50:41 PM, you wrote: Hi Scott, I noticed that Nuno changed yyless() to be like flex after your commit (not in HEAD? I considered that, but figured you guys wanted it different :-)), but now the here

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-10 Thread Marcus Boerger
Hello Matt, Thursday, April 10, 2008, 3:50:41 PM, you wrote: > Hi Scott, > I noticed that Nuno changed yyless() to be like flex after your commit (not > in HEAD? I considered that, but figured you guys wanted it different :-)), > but now the heredoc end part is wrong again (hehe), and I see Ton

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-10 Thread Matt Wilmas
Hi Scott, I noticed that Nuno changed yyless() to be like flex after your commit (not in HEAD? I considered that, but figured you guys wanted it different :-)), but now the heredoc end part is wrong again (hehe), and I see Tony reported the broken tests... Attached patch puts it back to pre-re2c

Re: [PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-08 Thread Scott MacVicar
Thanks Matt, I'll review these and merge them in with my other scanner fixes. Scott Matt Wilmas wrote: Hi all, First, I just realized while going through the scanner code after the re2c changes that there's a bug with heredoc handling (from my code changes last year, oops) on something like:

[PHP-DEV] [PATCH] Scanner fixes and tweaks

2008-04-08 Thread Matt Wilmas
Hi all, First, I just realized while going through the scanner code after the re2c changes that there's a bug with heredoc handling (from my code changes last year, oops) on something like: <