RE: [PHP-DEV] [PATCH] Resubmitted for review

2004-10-15 Thread Robert Silva
oy_zend_class). Bob Silva -Original Message- From: Andi Gutmans [mailto:[EMAIL PROTECTED] Sent: Thursday, October 14, 2004 5:14 PM To: Robert Silva; [EMAIL PROTECTED] Subject: Re: [PHP-DEV] [PATCH] Resubmitted for review Hi Robert, If I remember correctly, we came to the conclusi

Re: [PHP-DEV] [PATCH] Resubmitted for review

2004-10-14 Thread Andi Gutmans
Hi Robert, If I remember correctly, we came to the conclusion a while ago, that unless we make some big changes (which I'm not quite sure yet how far reaching they would be), then we could not malloc() constants. You would really need to emalloc()/efree() them on each request because the engine

Re: [PHP-DEV] [PATCH] Resubmitted for review

2004-10-12 Thread Marcus Boerger
Hello Andi, Wednesday, October 13, 2004, 12:37:36 AM, you wrote: > At 12:34 AM 10/13/2004 +0200, Marcus Boerger wrote: >>Hello Andi, >> >>Tuesday, October 12, 2004, 11:43:11 PM, you wrote: >> >> > We were discussing adding a per class (zend_class_entry *) callback for >> > constants. It might mak

Re: [PHP-DEV] [PATCH] Resubmitted for review

2004-10-12 Thread Andi Gutmans
At 12:34 AM 10/13/2004 +0200, Marcus Boerger wrote: Hello Andi, Tuesday, October 12, 2004, 11:43:11 PM, you wrote: > We were discussing adding a per class (zend_class_entry *) callback for > constants. It might make sense to allow that and if the callback is NULL > then try the constant's hash in z

Re: [PHP-DEV] [PATCH] Resubmitted for review

2004-10-12 Thread Marcus Boerger
Hello Andi, Tuesday, October 12, 2004, 11:43:11 PM, you wrote: > We were discussing adding a per class (zend_class_entry *) callback for > constants. It might make sense to allow that and if the callback is NULL > then try the constant's hash in zend_class_entry. > That should solve all cases,

Re: [PHP-DEV] [PATCH] Resubmitted for review

2004-10-12 Thread Andi Gutmans
We were discussing adding a per class (zend_class_entry *) callback for constants. It might make sense to allow that and if the callback is NULL then try the constant's hash in zend_class_entry. That should solve all cases, right? Andi At 11:54 PM 10/11/2004 -0700, Robert Silva wrote: This patch

[PHP-DEV] [PATCH] Resubmitted for review

2004-10-11 Thread Robert Silva
This patch allows php extension authors to declare constants on internal objects. This pretty much just duplicates the zend_declare_property_* functions but for constants. Currently there is no way for C level class authors to declare constants on their objects since the engine has to allocate spac