RE: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review

2012-02-03 Thread Clint M Priest
Okay, that's been removed from the patch. :) From: John LeSueur [mailto:john.lesu...@gmail.com] Sent: Friday, February 03, 2012 7:54 AM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review Because Zend/zend_language_scanner

Re: [PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review

2012-02-03 Thread John LeSueur
Because Zend/zend_language_scanner.c is a generated file, you could exclude it from your diff, and end up with a much smaller patch. Smaller patches are more appealing :) On Fri, Feb 3, 2012 at 6:47 AM, Clint M Priest wrote: > The property accessor functionality is done and is detailed here: > h

[PHP-DEV] [PATCH] Property Getters/Setters (v2.4) for review

2012-02-03 Thread Clint M Priest
The property accessor functionality is done and is detailed here: https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented Core Patch: http://www.clintpriest.com/patches/php-core/accessors/2.4.diff The core patch encompasses the entire original RFC and the as-implemented includes implementa