Re: [PHP-DEV] [PATCH] Pointer reset to NULL but not freed (in SAPI.c)

2008-03-26 Thread Marcus Boerger
Hello Osman, thanks for finding this bug. I fixed the embed sapi however for all active branches so that the first version with the fix is 5.2.6. The reason to not apply your patch is that we expect sapi_startup() to be able to set ini_entries to NULL and in fact this is supposed to not be used

[PHP-DEV] [PATCH] Pointer reset to NULL but not freed (in SAPI.c)

2008-03-25 Thread Osman A. Osman (عثمان)
Hey all, In main/SAPI.c's sapi_startup, sf->ini_entries is set to NULL but is not freed, which can cause a memory leak, e.g. in sapi/embed/php_embed.c which calls that function after mallocing ini_entries (php_embed.c tries to free that memory later, but the free is guarded by a check on ini_entr