Ilia Alshanetsky" , "Matteo Beccati" <
> > p...@beccati.com>
> > > Cc: internals@lists.php.net, "pdo"
> > > Inviato: Mercoledì, 26 maggio 2010 13:11:17
> > > Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
> >
Pierre,
That is not your decision, since when do you decide what goes into PDO,
that's a decision between the extension maintainer and the release master
and since you are neither...
On Mon, Jun 14, 2010 at 12:06 PM, Pierre Joye wrote:
> On Sat, Jun 12, 2010 at 12:24 PM, Pierre Joye
> wrote:
>
On Mon, Jun 14, 2010 at 2:21 AM, Ferenc Kovacs wrote:
>> > I don't know sqlite or IBM, but the MySQL SELECT INTO OUTFILE is a plain
>> > SQL
>> > statement, you don't need any special pdo function to use it, on the
>> > other
>> > hand, you can't use the postgresql's COPY TO/FROM with PDO without
On Sat, Jun 12, 2010 at 12:24 PM, Pierre Joye wrote:
> hi Ilia,
>
> So you basically say that the worries and wishes raised here are
> simply irrelevant and at the end of the day you decide what PDO can or
> cannot be?
>
> I'm very disappointed by these two commits. I don't think it is the
> way w
>
> > I don't know sqlite or IBM, but the MySQL SELECT INTO OUTFILE is a plain
> SQL
> > statement, you don't need any special pdo function to use it, on the
> other
> > hand, you can't use the postgresql's COPY TO/FROM with PDO without the
> patch
> > above.
> > Did I misunderstood something?
>
>
On 14.06.2010, at 11:28, Ferenc Kovacs wrote:
> quoting Denis:
>
> "Actually all the methods are wrappers against the native PostgreSQL
> commands (connection status, copy to/from).
>
> I needed to develop them as methods because it is not possible to get the
> same results with a sql statement
gt; >> To: Ilia Alshanetsky
> >> Cc: Pierre Joye; Denis Gasparin; Matteo Beccati;
> >> internals@lists.php.net; pdo
> >> Subject: Re: [PHP-DEV] Re: [PDO] Re: [PHP-DEV] [PATCH] New
> >> PDO methods for PostgreSQL driver
> >>
> >> On Sat, Jun 12,
Stanley Sufficool wrote:
If the dblib methods can't behave the same as the postgres methods,
> then clearly they shouldn't be named the same.
Yes, DBLIB behaves the same as pgsql in that it performs the copy in a
transaction state and also has it's data visible from the server
perspective. So
t;> To: Ilia Alshanetsky
>>> Cc: Pierre Joye; Denis Gasparin; Matteo Beccati;
>>> internals@lists.php.net; pdo
>>> Subject: Re: [PHP-DEV] Re: [PDO] Re: [PHP-DEV] [PATCH] New
>>> PDO methods for PostgreSQL driver
>>>
>>> On Sat, Jun 12, 2010 at 4
nternals@lists.php.net; pdo
>> Subject: Re: [PHP-DEV] Re: [PDO] Re: [PHP-DEV] [PATCH] New
>> PDO methods for PostgreSQL driver
>>
>> On Sat, Jun 12, 2010 at 4:54 AM, Ilia Alshanetsky
>> wrote:
>> > The concerns you raised about custom methods specific to dat
> -Original Message-
> From: Stanley Sufficool [mailto:ssuffic...@gmail.com]
> Sent: 13 June 2010 20:10
> To: Ilia Alshanetsky
> Cc: Pierre Joye; Denis Gasparin; Matteo Beccati;
> internals@lists.php.net; pdo
> Subject: Re: [PHP-DEV] Re: [PDO] Re: [PHP-DEV] [PATC
On 13.06.2010, at 21:09, Stanley Sufficool wrote:
> On Sat, Jun 12, 2010 at 4:54 AM, Ilia Alshanetsky wrote:
>> The concerns you raised about custom methods specific to database drivers
>> were not reflective of the PDO's intent as was clarified by Wez and myself.
yeah .. Wez became the ruler o
l and $fields parameters.
>> >> Parameters:
>> >> * (mandatory) $table: table to retrieve data from.
>> >> * $delimiter: alternative delimiter to use in place of the
>> standard
>> >> postgres delimiter ("\t")
>> &g
copy command, you must before copy into a shared folder and
>> >> > the issue the copy from filename command.
>> >> > Using the methods added to PDO, you can do it directly from the
>> >> > webserver.
>> >> >
>> >> > About copying to/from std
On 12.06.2010, at 15:54, Ilia Alshanetsky wrote:
> The concerns you raised about custom methods specific to database drivers
> were not reflective of the PDO's intent as was clarified by Wez and myself.
>
> The code that was introduced was specific to PostgreSQL, the common
> functionality was in
value. Default is "\N"
> >>* $fields: string with table fields to include in the row of the
> >> array. Fields are separated by comma
> >>
> >>
> >> pgsqlCopyToFile($table,$filename,$delimiter,$null,$fields)
> >>
pgsqlCopyToFile($table,$filename,$delimiter,$null,$fields)
> >>
> >>
> >>It uses the native Postgresql copy construct to retrieve $table
> contents
> >> and store them into a file.
> >>It returns boolean.
> >>The format of the
$table contents
>> and store them into a file.
>> It returns boolean.
>> The format of the rows stored into the file is indicated in the
>> $delimiter, $null and $fields parameters.
>> Parameters:
>> * (mandatory) $table: table to retrieve data from.
>&g
gt; * $delimiter: alternative delimiter to use in place of the standard
> postgres delimiter ("\t")
> * $null: alternative string to use as null value. Default is "\N"
>* $fields: string with table fields to include in the row of the
> array.
andatory) $filename: file where to store the contents of the
> table
> * $delimiter: alternative delimiter to use in place of the standard
> postgres delimiter ("\t")
> * $null: alternative string to use as null value. Default is "\N"
>* $fields:
in advance,
> Denis
>
>
> - Messaggio originale -
> > Da: "Denis Gasparin"
> > A: "Ilia Alshanetsky" , "Matteo Beccati" <
> p...@beccati.com>
> > Cc: internals@lists.php.net, "pdo"
> > Inviato: Mercoledì,
Hi,
Denis has offered to do the work in nice way that is a more proper long term
solution. So what is stopping us now? Can someone from the PHP core team
chime in and give some guidance so that we can move this forward?
Thanks, Jon
On Fri, Jun 4, 2010 at 6:21 PM, Denis Gasparin
wrote:
> Hi.
> F
On Sat, Jun 5, 2010 at 10:54 AM, Oskar Eisemuth wrote:
> Pierre Joye wrote:
>
>> On Thu, Jun 3, 2010 at 8:47 PM, Ferenc Kovacs wrote:
>>
>>
>>> Agree, but currently I don't see any point in waiting, if we don't do
>>> anything else beside waiting.
>>>
>>>
>>
>> There are discussions about that o
Pierre Joye wrote:
On Thu, Jun 3, 2010 at 8:47 PM, Ferenc Kovacs wrote:
Agree, but currently I don't see any point in waiting, if we don't do
anything else beside waiting.
There are discussions about that on the PDO list in the past. However,
it is because we failed to start discussio
Hi.
For me there is no problem. There were several solutions proposed in
this thread:
- to share connection between pdo and old pgsql driver
- to create / emulate those methods in the various pdo drivers
- others (look at the post of one week ago)
Just point me to the right solution, give me s
On Thu, Jun 3, 2010 at 8:07 PM, Jonathan Wage wrote:
> Hi,
>
> On Thu, Jun 3, 2010 at 1:58 PM, Ferenc Kovacs wrote:
>
>>
>>
>> On Thu, Jun 3, 2010 at 7:28 PM, Jonathan Wage wrote:
>>
>>> Hi,
>>>
>>> On Thu, Jun 3, 2010 at 1:16 PM, Ferenc Kovacs wrote:
>>>
If that so, I would be happy to s
Hi,
On Thu, Jun 3, 2010 at 1:58 PM, Ferenc Kovacs wrote:
>
>
> On Thu, Jun 3, 2010 at 7:28 PM, Jonathan Wage wrote:
>
>> Hi,
>>
>> On Thu, Jun 3, 2010 at 1:16 PM, Ferenc Kovacs wrote:
>>
>>> If that so, I would be happy to see some discussion and work on the PDO,
>>> because from a user perspe
As far as I can see as a user PDO is quite dead and it's missing much
of new database functionality. Just compare it to mysqli and other
vendor specific extensions witch are developed all the time.
Until there is no dedicated work for all PDO supported databases
there is no point in adding feature
, 2010 1:32 PM
>To: Johannes Schlüter
>Cc: Pierre Joye; Jonathan Wage; Ilia Alshanetsky; Matteo
>Beccati; internals@lists.php.net; pdo; Ferenc Kovacs
>Subject: [PDO] Re: [PHP-DEV] [PATCH] New PDO methods for
>PostgreSQL driver
>
>
>Hi.
>
>It is similar to what I tried to
Joye" , "Jonathan Wage"
> , "Ilia Alshanetsky" ,
> "Matteo Beccati" , internals@lists.php.net, "pdo"
> , "Ferenc Kovacs"
>
> Inviato: Giovedì, 3 giugno 2010 22:19:57
> Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL d
"Matteo Beccati" ,
> internals@lists.php.net, "pdo" , "Ferenc Kovacs"
>
> Inviato: Giovedì, 3 giugno 2010 21:52:10
> Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
> Hi,
>
>
> On Thu, Jun 3, 2010 at 3:48 PM, Denis Gas
On Thu, 2010-06-03 at 21:48 +0200, Denis Gasparin wrote:
> As I wrote last week, according to me too the best solution
> would be to share the PDO opened connection between the old
> pgsql driver and the PDO one
> That was the original way we tried to develop the patch
> without success.
Would
Denis
>
>
> - Messaggio originale -
> > Da: "Pierre Joye"
> > A: "Ferenc Kovacs"
> > Cc: "Jonathan Wage" , "Denis Gasparin" <
> denis.gaspa...@edistar.com>, "Ilia Alshanetsky"
> > , "Matteo Beccat
"
> , "Matteo Beccati" ,
> internals@lists.php.net, "pdo"
> Inviato: Giovedì, 3 giugno 2010 21:14:20
> Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
> On Thu, Jun 3, 2010 at 8:47 PM, Ferenc Kovacs wrote:
>
> > This discussio
On Thu, Jun 3, 2010 at 8:47 PM, Ferenc Kovacs wrote:
> This discussion has a long history, and it would be better to actualy do
> something about the problem, because it seems that it won't going to
> disappear by itself.
> I don't want to be rude, but the PDO v2 spec was last modified in
> 2008.
On Thu, Jun 3, 2010 at 8:17 PM, Pierre Joye wrote:
> On Thu, Jun 3, 2010 at 7:58 PM, Ferenc Kovacs wrote:
>
> > So?
> > Now we shouldn't try to improve things because they aren't perfect?
>
> Because it is a very bad thing, by design and we will have to keep it
> during years. I think this exact
On Thu, Jun 3, 2010 at 7:58 PM, Ferenc Kovacs wrote:
> So?
> Now we shouldn't try to improve things because they aren't perfect?
Because it is a very bad thing, by design and we will have to keep it
during years. I think this exact point was clear enough.
>> We need to stop this and start fixin
On Thu, Jun 3, 2010 at 7:28 PM, Jonathan Wage wrote:
> Hi,
>
> On Thu, Jun 3, 2010 at 1:16 PM, Ferenc Kovacs wrote:
>
>> If that so, I would be happy to see some discussion and work on the PDO,
>> because from a user perspective, it seems like abadoned.
>> I think that we should allow to get thi
The format of the rows into the array is indicated in the $delimiter,
>> > > $null and $fields parameters.
>> > > Parameters: * (mandatory) $table: table to retrieve data from.
>> > > * $delimiter: alternative delimiter to use in place of the standard
>> > > po
>
> >
> > - Messaggio originale -
> > > Da: "Denis Gasparin"
> > > A: "Ilia Alshanetsky" , "Matteo Beccati" <
> > p...@beccati.com>
> > > Cc: internals@lists.php.net, "pdo"
> > > Inviat
shanetsky" , "Matteo Beccati" <
> p...@beccati.com>
> > Cc: internals@lists.php.net, "pdo"
> > Inviato: Mercoledì, 26 maggio 2010 13:11:17
> > Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
>
> > I attached to this mail a
nviato: Mercoledì, 26 maggio 2010 13:11:17
> Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
> I attached to this mail a new version of the patch both in unified and
> single file format.
>
> I attached the unit tests for all the new methods too.
> They ar
On Wed, May 26, 2010 at 3:37 AM, Wez Furlong wrote:
> I confess to being busy, but I don't recall any conversation where
> this capability was revoked or otherwise called out as wrong.
Now you have examples of such discussions :)
More seriously, the current situation has to be discussed. For on
On Tue, May 25, 2010 at 6:37 PM, Wez Furlong wrote:
> On Mon, May 24, 2010 at 3:07 PM, Pierre Joye wrote:
>> On Mon, May 24, 2010 at 8:56 PM, Ilia Alshanetsky wrote:
>>> Pierre,
>>> As one of the original authors of PDO that is news to me. PDO was designed
>>> to allow common functionality to be
On Mon, May 24, 2010 at 3:07 PM, Pierre Joye wrote:
> On Mon, May 24, 2010 at 8:56 PM, Ilia Alshanetsky wrote:
>> Pierre,
>> As one of the original authors of PDO that is news to me. PDO was designed
>> to allow common functionality to be provided via a common interface, however
>> it was also de
pgsql driver).
> > >
> > > We are currently using them in production and we needed them in
> > > order to avoid additional connections to database (one with the old
> > > driver and one with PDO).
> > >
> > > Denis
> > >
> > >
>
On 24/05/2010 22:39, Denis Gasparin wrote:
I attached the patch as a single file.
There are currently no tests written for the new methods.
I'll provide them if needed to integrate the patch in the pdo_pgsql driver.
Yes please. After you do that, I'm going to review the patch as soon as
I h
On Mon, 2010-05-24 at 14:56 -0400, Ilia Alshanetsky wrote:
> As one of the original authors of PDO that is news to me. PDO was designed
> to allow common functionality to be provided via a common interface, however
> it was also designed to recognize that not all database interfaces are the
> same.
ded them in
> > order to avoid additional connections to database (one with the old
> > driver and one with PDO).
> >
> > Denis
> >
> >
> > ----- Messaggio originale -
> >> Da: "Ilia Alshanetsky"
> >> A: "Denis Gasparin&qu
inale -
Da: "Ilia Alshanetsky"
A: "Denis Gasparin"
Cc: internals@lists.php.net
Inviato: Lunedì, 24 maggio 2010 19:54:46
Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
Denis,
Could you merge the patches into a single for easier code review.
Also, th
Pierre Joye wrote:
On Mon, May 24, 2010 at 8:56 PM, Ilia Alshanetsky wrote:
Pierre,
As one of the original authors of PDO that is news to me. PDO was designed
to allow common functionality to be provided via a common interface, however
it was also designed to recognize that not all database int
> Cc: internals@lists.php.net
> Inviato: Lunedì, 24 maggio 2010 21:45:30
> Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for PostgreSQL driver
> I'll provide the patches in a single file as soon as possible.
>
> Actually all the methods are wrappers against the native
abase (one with the old driver and one with PDO).
Denis
- Messaggio originale -
> Da: "Ilia Alshanetsky"
> A: "Denis Gasparin"
> Cc: internals@lists.php.net
> Inviato: Lunedì, 24 maggio 2010 19:54:46
> Oggetto: Re: [PHP-DEV] [PATCH] New PDO methods for P
On 24.05.2010 21:54, Ilia Alshanetsky wrote:
> Denis,
>
> Could you merge the patches into a single for easier code review.
Hint: `diff -u` produces a bit more human-readable patch.
--
Wbr,
Antony Dovgal
---
http://pinba.org - realtime statistics for PHP
--
PHP Internals - PHP Runtime Develo
On Mon, May 24, 2010 at 8:56 PM, Ilia Alshanetsky wrote:
> Pierre,
> As one of the original authors of PDO that is news to me. PDO was designed
> to allow common functionality to be provided via a common interface, however
> it was also designed to recognize that not all database interfaces are th
Pierre,
As one of the original authors of PDO that is news to me. PDO was designed
to allow common functionality to be provided via a common interface, however
it was also designed to recognize that not all database interfaces are the
same. And as such allowed driver authors to provide custom func
On Mon, May 24, 2010 at 8:10 PM, Alexey Zakhlestin wrote:
> Limiting ourselves to Least Common Denominator is not the best idea.
And adding vendors specific stuff all around is a very bad idea. See
the ones we have now in PDO::
I think it is time to figure how we can do it in the most clean and
On 24.05.2010, at 22:04, Pierre Joye wrote:
> hi Ilia,
>
> On Mon, May 24, 2010 at 7:53 PM, Ilia Alshanetsky wrote:
>> since when? PDO was designed to allow drivers to provide their own
>> functions, which many drivers do.
>
> We discussed that on the PDO list, and we try to avoid to add drive
hi Ilia,
On Mon, May 24, 2010 at 7:53 PM, Ilia Alshanetsky wrote:
> since when? PDO was designed to allow drivers to provide their own
> functions, which many drivers do.
We discussed that on the PDO list, and we try to avoid to add drivers
specific methods. That's obviously makes sense given th
Denis,
Could you merge the patches into a single for easier code review. Also, the
copy to/from file seems like it would just be a wrapper against the native
COPY PostgreSQL command, is there really a need to provide a method for it?
On Mon, May 24, 2010 at 4:57 AM, Denis Gasparin
wrote:
> Hi.
>
since when? PDO was designed to allow drivers to provide their own
functions, which many drivers do.
On Mon, May 24, 2010 at 5:16 AM, Lester Caine wrote:
> Denis Gasparin wrote:
>
>> Hi.
>>
>> I developed some patches for PDO/Postgresql driver in order to add some
>> useful methods that were ava
Denis Gasparin wrote:
I developed some patches for PDO/Postgresql driver in order to add some useful \
methods that were available in the original pgsql driver.
p...@lists.php.net is the right place for PDO development ;)
Ops sorry :-) I will post the patches also to that list.
But more im
Denis Gasparin wrote:
>> Hi.
>>
>> I developed some patches for PDO/Postgresql driver in order to add some
>> useful \
>> methods that were available in the original pgsql driver.
>p...@lists.php.net is the right place for PDO development ;)
Ops sorry :-) I will post the patches also to that
Denis Gasparin wrote:
Hi.
I developed some patches for PDO/Postgresql driver in order to add some useful
methods that were available in the original pgsql driver.
p...@lists.php.net is the right place for PDO development ;)
But more important, any NEW functions should be generic. Otherwise w
Hi.
I developed some patches for PDO/Postgresql driver in order to add some useful
methods that were available in the original pgsql driver.
The attached patches apply on 5.3.2 and svn 5.3.x.
If needed, i have patches also for 5.2.x.
Please comment and tell me improvements or tips.
Thank you
65 matches
Mail list logo
