Re: [PHP-DEV] [PATCH] Net_URL

2006-09-24 Thread Alexei
Thanks Jan Sorry guys, description of how to submit patches was a bit confusing on pear website. Alexei Jan Lehnardt wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey Alexei, Thanks you for your patch! I committed it. For future reference however, these patches should go into the bu

Re: [PHP-DEV] [PATCH] Net_URL

2006-09-24 Thread Johannes Schlueter
Please send this to an PEAR list or report a bug at pear.php.net, internals is the wrong place for this. And as a related note: diff -u is way better readable and preferred. johannes Alexei wrote: Here is a patch for // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ // // Net_URL Class

Re: [PHP-DEV] [PATCH] Net_URL

2006-09-24 Thread Jan Lehnardt
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey Alexei, Thanks you for your patch! I committed it. For future reference however, these patches should go into the bug system[1] and there is a dedicated PEAR development related list[2]. Best, Jan - -- [1] http://pear.php.net/bugs/search.php?cmd

[PHP-DEV] [PATCH] Net_URL

2006-09-24 Thread Alexei
Here is a patch for // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ // // Net_URL Class Misspelled variable in function Net_URL::setProtocol() 418c418 < $this->port = is_null($port) ? $this->getStandardPort($protocal) : $port; --- > $this->port = is_null($port)