Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-10-01 Thread Jani Taskinen
Patch applied to HEAD / PHP_5_3. --Jani On Mon, 2007-08-06 at 09:57 -0400, David Soria Parra wrote: > Hi internals, > > so based on a discussion of php.pecl we thought about using the php_getopt > for the PHP_FUNCTION(getopt) instead of the system provided getopt. Here > is the patch for that. H

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Johannes Schlüter
On Tue, 2007-08-07 at 13:02 -0700, Stanislav Malyshev wrote: > > David has a point here. So first of all we should move getopt > > implementation out of CLI/CGI and into main. Could you do that > > first Jani? > > Why one would need getopt outside of cgi/cli? I.e. where would these > options co

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread David Soria Parra
> Why one would need getopt outside of cgi/cli? I.e. where would these > options come from? initially the idea was to use getopt on windows machines. After proposing my patch which just includes the NetBSD getopt(), there was a recommandation in php.pecl to use the php_getopt instead of the syste

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Stanislav Malyshev
David has a point here. So first of all we should move getopt implementation out of CLI/CGI and into main. Could you do that first Jani? Why one would need getopt outside of cgi/cli? I.e. where would these options come from? -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED]

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Johannes Schlüter
On Tue, 2007-08-07 at 19:13 +0300, Jani Taskinen wrote: > Thread safe for CGI and CLI ? :) > Or do you find the function useful outside those SAPIs? Well David's plan is to use the implementation for PHP-level getopt() and I can imagine doing crazy stuff, so if we can make it thread-safe in a good

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Jani Taskinen
Thread safe for CGI and CLI ? :) Or do you find the function useful outside those SAPIs? --Jani Johannes Schlüter kirjoitti: David, On Mon, 2007-08-06 at 09:57 -0400, David Soria Parra wrote: Hi internals, so based on a discussion of php.pecl we thought about using the php_getopt for the PH

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Johannes Schlüter
David, On Mon, 2007-08-06 at 09:57 -0400, David Soria Parra wrote: > Hi internals, > > so based on a discussion of php.pecl we thought about using the php_getopt > for the PHP_FUNCTION(getopt) instead of the system provided getopt. Here > is the patch for that. Hopefully someone is reviewing and

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Jani Taskinen
Yes, I know about this. I was wondering about this thing long time ago..just never got around doing anything about it.. :D But let's wait for PHP 5.3 branch to get opened first. --Jani On Tue, 2007-08-07 at 14:22 +0200, Marcus Boerger wrote: > Hello Jani, > > David has a point here. So firs

Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-07 Thread Marcus Boerger
Hello Jani, David has a point here. So first of all we should move getopt implementation out of CLI/CGI and into main. Could you do that first Jani? marcus Monday, August 6, 2007, 3:57:26 PM, you wrote: > Hi internals, > so based on a discussion of php.pecl we thought about using the php_get

[PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2

2007-08-06 Thread David Soria Parra
Hi internals, so based on a discussion of php.pecl we thought about using the php_getopt for the PHP_FUNCTION(getopt) instead of the system provided getopt. Here is the patch for that. Hopefully someone is reviewing and commiting the patch as i don't have karma. It addes main/getopt.c main/php_g