On 16/01/15 03:48, Joshua Rogers wrote:
> Should the patch, perhaps be inside the spprintf() function?
> That would take care of future problems, too.
>
> Thoughts?
Ok, so, there are many many places where 'error' is not checked against
NULL. So I'm going to submit a patch that will fix this in th
Hi,
On 16/01/15 03:41, Michael Wallner wrote:
> Looks good.
There's another one(2) in /ext/phar/util.c:
--snip--
911if (error) {
912*error = NULL;
913}
914/* seek to start of internal file and read it */
915if (FAILURE == phar_open_entry_fp(en
On 15/01/15 17:31, Joshua Rogers wrote:
> ---
> ext/phar/zip.c | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/ext/phar/zip.c b/ext/phar/zip.c
> index 2a95580..2117b0e 100644
> --- a/ext/phar/zip.c
> +++ b/ext/phar/zip.c
> @@ -1217,7 +1217,9 @@ int phar_zip_f
---
ext/phar/zip.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/ext/phar/zip.c b/ext/phar/zip.c
index 2a95580..2117b0e 100644
--- a/ext/phar/zip.c
+++ b/ext/phar/zip.c
@@ -1217,7 +1217,9 @@ int phar_zip_flush(phar_archive_data *phar, char
*user_stub, zend_long
