Re: [PHP-DEV] [PATCH] Fix octal parsing (finally)

2015-01-17 Thread Andrea Faulds
Hi! Since it’s been a week and there have been no objections, I’ve merged the octal fix patch into php master: https://github.com/php/php-src/commit/5f29b980514867f1a09969ca6a1c1f5fb00c3027 Finally, it is fixed after all these years :) -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP

Re: [PHP-DEV] [PATCH] Fix octal parsing (finally)

2015-01-10 Thread Xinchen Hui
Hey: On Sun, Jan 11, 2015 at 6:37 AM, Andrea Faulds wrote: > Hey internals, > > A longstanding PHP bug is that invalid octal digits simply terminate the > literal and are ignored, rather than generating a compile error. Thus, this > is valid: > > $x = 0109; // same as 010, or 8 > > I see no

Re: [PHP-DEV] [PATCH] Fix octal parsing (finally)

2015-01-10 Thread Yasuo Ohgaki
Hi all, Nice fix, Andrea! On Sun, Jan 11, 2015 at 8:55 AM, Stanislav Malyshev wrote: > > A longstanding PHP bug is that invalid octal digits simply terminate > > the literal and are > ignored, rather than generating a compile error. Thus, this is valid: > > > > $x = 0109; // same as 010, or 8 >

Re: [PHP-DEV] [PATCH] Fix octal parsing (finally)

2015-01-10 Thread Stanislav Malyshev
Hi! > A longstanding PHP bug is that invalid octal digits simply terminate > the literal and are ignored, rather than generating a compile error. Thus, this is valid: > > $x = 0109; // same as 010, or 8 > > I see no particular reason why this behaviour should be preserved. > I’ve written a patch

[PHP-DEV] [PATCH] Fix octal parsing (finally)

2015-01-10 Thread Andrea Faulds
Hey internals, A longstanding PHP bug is that invalid octal digits simply terminate the literal and are ignored, rather than generating a compile error. Thus, this is valid: $x = 0109; // same as 010, or 8 I see no particular reason why this behaviour should be preserved. I’ve written a p