Where is the patch?
Geoffrey Sneddon wrote:
On 21 Mar 2008, at 12:09, Antony Dovgal wrote:
On 03/18/2008 06:51 AM, Stephen Bach wrote:
Attached is a simple proposed patch that fixes Bug 43477. Basically,
the code
that set the error mode of the ICU converter was giving it an
instruction
(the
The original patch works as it should. Substitution with user-defined
characters only works in the "FROM_UNICODE" case. When converting to Unicode,
U+FFFD is always substituted because it is the standard substitution
character. Even the ICU library does not allow this to be changed (with good
r
On 03/21/2008 06:28 PM, Geoffrey Sneddon wrote:
>> Patch committed, thanks.
>
> Can we test U_CONV_ERROR_SUBST too? See attached patch. Also, the bug
> should be closed.
The patch breaks the test.
Can you guys decide on what should work and how, I'll commit the patch
afterwards, ok?
--
Wbr,
On 21 Mar 2008, at 12:09, Antony Dovgal wrote:
On 03/18/2008 06:51 AM, Stephen Bach wrote:
Attached is a simple proposed patch that fixes Bug 43477.
Basically, the code
that set the error mode of the ICU converter was giving it an
instruction
(the context parameter) to only skip or substitu
On 03/18/2008 06:51 AM, Stephen Bach wrote:
> Attached is a simple proposed patch that fixes Bug 43477. Basically, the code
> that set the error mode of the ICU converter was giving it an instruction
> (the context parameter) to only skip or substitute if the code point was not
> represented in
Okay. I'm fine with the patch.
Stephen Bach wrote:
Sorry for the ambiguity. Allow me to clarify: I meant that U_CONV_ERROR_SKIP
and U_CONV_ERROR_SUBST should work the same as the other error modes.
Otherwise, what's the point of having them?
-Stephen
On Tuesday 18 March 2008 06:02:36 pm Geof
Sorry for the ambiguity. Allow me to clarify: I meant that U_CONV_ERROR_SKIP
and U_CONV_ERROR_SUBST should work the same as the other error modes.
Otherwise, what's the point of having them?
-Stephen
On Tuesday 18 March 2008 06:02:36 pm Geoffrey wrote:
> On 18 Mar 2008, at 19:37, Stephen Bach w
On 18 Mar 2008, at 19:37, Stephen Bach wrote:
Shouldn't U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST work the same way?
I guess: U_CONV_ERROR_SKIP is just U_CONV_ERROR_SUBST with the
substitution string as nothing, though I expect slight speed gains
could be made by keeping them separate (due
I'm just suggesting that other error modes should do what they claim to do.
Stopping on an illegal sequence is fine, unless the user had called a
function telling the converter to do something else.
U_CONV_ERROR_STOP: stops on illegal character (the default)
U_CONV_ERROR_ESCAPE_*: 5 different mo
On 18 Mar 2008, at 17:43, Andrei Zmievski wrote:
Why would we not want to stop on illegal sequences?
Stuff relies on things _not_ stopping. No web browser stops on an
illegal sequence: they all use some replacement character (U+FFFD
REPLACEMENT CHARACTER in most). Sure, idealists will say
Why would we not want to stop on illegal sequences?
-Andrei
Stephen Bach wrote:
Attached is a simple proposed patch that fixes Bug 43477. Basically, the code
that set the error mode of the ICU converter was giving it an instruction
(the context parameter) to only skip or substitute if the code
Attached is a simple proposed patch that fixes Bug 43477. Basically, the code
that set the error mode of the ICU converter was giving it an instruction
(the context parameter) to only skip or substitute if the code point was not
represented in the new encoding. However, it still was returning an
12 matches
Mail list logo
