Re: [PHP-DEV] [PATCH] Bug #34671 Incorrect calling convention to cmd.exe

2006-02-06 Thread Frank M. Kromann
I like the idea of a php.ini setting for the comspec (although this might create OS specific ini files), and I do not like 'magick' stuff happening to command parameters in any of the exec functions. According to Windows cmd specifications the quotes are needed if one of the special characters is

Re: [PHP-DEV] [PATCH] Bug #34671 Incorrect calling convention to cmd.exe

2006-02-06 Thread Tim Starling
Wez Furlong wrote: > Is it possible that switching /S on will break existing scripts? > If so, it's probably better to make the comspec setting a PHP .ini > option that only the admin can change and allow /S to be set there. > > --Wez. Well, the patch doesn't just use /S, it also automatically en

Re: [PHP-DEV] [PATCH] Bug #34671 Incorrect calling convention to cmd.exe

2006-02-06 Thread Wez Furlong
Is it possible that switching /S on will break existing scripts? If so, it's probably better to make the comspec setting a PHP .ini option that only the admin can change and allow /S to be set there. --Wez. On 2/5/06, Tim Starling <[EMAIL PROTECTED]> wrote: > This patch is untested, my apologies

[PHP-DEV] [PATCH] Bug #34671 Incorrect calling convention to cmd.exe

2006-02-05 Thread Tim Starling
This patch is untested, my apologies for that. I don't have a working Visual C++ environment in which to compile PHP at the moment. I have, however, tested the concepts involved. I can also provide test cases and expected output if that would help. The problem is PHP's incorrect invocation of cm