Re: [PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects

2004-10-14 Thread Jason Garber
Hello Andi, reset_exception_handler() :) -- Best regards, Jasonmailto:[EMAIL PROTECTED] Tuesday, October 12, 2004, 5:40:34 PM, you wrote: AG> I see Marcus has already attempted to fix this even though the bug report AG> is still open. AG> Marcus, what exactly

Re: [PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects

2004-10-12 Thread Andi Gutmans
I see Marcus has already attempted to fix this even though the bug report is still open. Marcus, what exactly did you do? It seems you allow only NULL to reset exception handler and not empty string. Right? So it seems like you agree with me that "" is ugly but the question is if we're breaking

Re: [PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects

2004-10-12 Thread Andi Gutmans
I must admit that I think it's kind of ugly to be able to reset it by using "" but as this seems to be the existing behavior (I guess the person that added the callable support missed this part), I'll apply the patch. Thanks, Andi At 11:44 PM 10/11/2004 -0700, Robert Silva wrote: The problem is

[PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects

2004-10-11 Thread Robert Silva
The problem is that set_exception_handler allows you to reset the handler by passing an empty string as argument. It did not check to make sure it was a string before checking strlen, therefore when passed an array, it assumed the user was resetting the handler. This patch only resets when an empty