Can someone *please* review and commit this patch.
http://www.binam.net/bug-27633.patch
Scope: PHP4 & PHP5 on windows
Overview: Some ftp servers send a '\r' before every '\n' when
transferring in ASCII mode. If the file being retrieved has windows
flavor line endings '\r\n', the resulting file end
http://www.binam.net/bug-27633.patch
-Original Message-
From: Derick Rethans [mailto:[EMAIL PROTECTED]
Sent: Wednesday, February 02, 2005 2:03 PM
To: Binam, Jesse
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] [PATCH] Bug# 27633 - Wrong translation in ASCII
mode
On Wed, 2 Feb 2005
On Wed, 2 Feb 2005, Binam, Jesse wrote:
> Can somebody please review and either commit and/or give me some
> feedback. It is against HEAD as of about 30 minutes ago.
Please post the patch online and provide a link, the list manager strips
non-text attachments.
Derick
--
Derick Rethans
http://d
+}
else if (*s == '\r') {
+ s++;+} else if
(*s == '\n')
{ s++;-}-s++;-php_stream_write(outstream,
ptr, (s - ptr));-if (*(s - 1) == '\r')
{- php_stream_putc(outstream,
'\n'); } ptr =
s; }
From: Binam, Jes
I guess the patch would be helpful
;)
From: Binam, Jesse
[mailto:[EMAIL PROTECTED] Sent: Wednesday, February 02, 2005
12:34 PMTo: internals@lists.php.netSubject: [PHP-DEV]
[PATCH] Bug# 27633 - Wrong translation in ASCII mode
Can somebody please
review and either commit and/or give me
Can somebody please
review and either commit and/or give me some feedback. It is against HEAD as of
about 30 minutes ago.
This is a data
integrity issue so I would think it would be extremely high
priority.
This is
a problem in both 4.3.10 and 5.0.3, this patch should apply nicely to both
