RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-29 Thread Uwe Schindler
8 1:09 PM > To: 'Arnaud Le Blanc' > Cc: 'Lukas Kahwe Smith'; internals@lists.php.net; 'Christian Schmidt'; > 'Alex Leigh'; 'George Wang' > Subject: RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set > usingheader() > >

RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-29 Thread Uwe Schindler
Hallo Arnaud, > I believe that Apache does sets its headers just before sending them, so > when > PHP deletes all headers in Apache's hashtable this does not removes > "Server", > "Date", etc. If this is not the case for NSAPI, solution a) seems good, > but > also allows to remove "Date" by settin

Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-28 Thread Arnaud Le Blanc
Hi, On Friday 28 November 2008 18:24:38 Uwe Schindler wrote: > Just one question here: > When implementing this into NSAPI, I found the following problem: > > NSAPI does not directly allows to remove all headers, you can only do this > step by step. So there are three possibilities to ship aroun

RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-28 Thread Uwe Schindler
, 2008 2:07 PM > To: Arnaud Le Blanc > Cc: Uwe Schindler; internals@lists.php.net; 'Christian Schmidt'; Alex > Leigh; George Wang > Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set > usingheader() > > > On 13.11.2008, at 14:48, Arnau

RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-28 Thread Uwe Schindler
:07 PM > To: Arnaud Le Blanc > Cc: Uwe Schindler; internals@lists.php.net; 'Christian Schmidt'; Alex > Leigh; George Wang > Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set > usingheader() > > > On 13.11.2008, at 14:48, Arnaud Le Blanc wrote: &

Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-28 Thread Lukas Kahwe Smith
On 13.11.2008, at 14:48, Arnaud Le Blanc wrote: Hi, Committed, thanks Christian :) apache2handler, apache2filter, apache, apache_hooks, cli and cgi SAPIs have been updated. The following SAPIs need to be updated in PHP_5_3 and HEAD: aolserver, continuity, litespeed, nsapi, caudium, phttpd

Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-13 Thread Arnaud Le Blanc
vember 09, 2008 10:02 PM > > To: internals@lists.php.net > > Cc: Christian Schmidt > > Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set > > usingheader() > > > > On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote: > > &g

RE: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-09 Thread Uwe Schindler
TECTED] On Behalf Of Arnaud Le Blanc > Sent: Sunday, November 09, 2008 10:02 PM > To: internals@lists.php.net > Cc: Christian Schmidt > Subject: Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set > usingheader() > > On Sunday 09 November 2008 19:51:31 Christian Schmi

Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-09 Thread Arnaud Le Blanc
On Sunday 09 November 2008 19:51:31 Christian Schmidt wrote: > Stan Vassilev | FM wrote: > > I suggest header_remove('*') or simply header_remove() /no param/ > > removes all headers (including the one PHP sets by default), so we can > > start with a clear state. > > I added header_remove('Foo')

Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-11-09 Thread Christian Schmidt
Stan Vassilev | FM wrote: I suggest header_remove('*') or simply header_remove() /no param/ removes all headers (including the one PHP sets by default), so we can start with a clear state. I added header_remove('Foo'). header_remove() without arguments removes all headers (though Apache still

Re: [PHP-DEV] [PATCH] Allow unsetting headers previously set usingheader()

2008-10-22 Thread Stan Vassilev | FM
That isn't very intuitive. I would think it was a typo when reading such code and fix the header line... I'd suggest explicit header_remove("Vary"); Agreed, a specific function with a clear name sounds better. Christian, can you update the patch? - thanks! johannes I suggest header_remove(