Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-22 Thread Andi Gutmans
I saw Edin commited a fix. Let me know if it still gives you problems. Andi At 07:07 PM 7/20/2004 -0700, Michael Sisolak wrote: Andi, Yahoo in the sent mail shows the attachment, but it didn't show up in the list. I've posted it at: http://aduni.org/~msisolak/php5isapi.c.patch This is for the PHP_

Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-21 Thread Edin Kadribasic
Hi Micheal, I have applied the fix to the CVS. Edin - Original Message - From: "Michael Sisolak" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, July 20, 2004 11:55 PM Subject: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929) >

Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Michael Sisolak
Andi, Yahoo in the sent mail shows the attachment, but it didn't show up in the list. I've posted it at: http://aduni.org/~msisolak/php5isapi.c.patch This is for the PHP_5_0 branch. I believe that for HEAD the change would just be to use STR_EMPTY_ALLOC() at the end of sapi_isapi_read_cookes()

Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Andi Gutmans
Michael, If you didn't forget, then maybe you can post a URL to the patch? Thanks, Andi At 12:34 AM 7/21/2004 +0200, Stefan Esser wrote: Andi Gutmans wrote: You forgot to attach the patch... Not necessary. I believe that certain webmail accounts have problems sending attachments to the list. I gue

Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Stefan Esser
Andi Gutmans wrote: You forgot to attach the patch... Not necessary. I believe that certain webmail accounts have problems sending attachments to the list. I guess that is caused by whatever attaches the PHP-Internals tag to the end of every listmail. Stefan -- PHP Internals - PHP Runtime Develo

Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Andi Gutmans
You forgot to attach the patch... At 02:55 PM 7/20/2004 -0700, Michael Sisolak wrote: I believe that a bug was introduced with version 1.3 of php5isapi.c. The sapi_isapi_read_cookies() function used to return NULL when there were no cookies, but was changed to return "" instead. That's fine, but t

[PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Michael Sisolak
I believe that a bug was introduced with version 1.3 of php5isapi.c. The sapi_isapi_read_cookies() function used to return NULL when there were no cookies, but was changed to return "" instead. That's fine, but then HttpExtensionProc() attempts to free the non-ealloc'ed empty string and dies with