erm, I did ... but that line wasn't the thing that broke this.
(ZEND_FENTRY was.)
> -Original Message-
> From: Frank M. Kromann [mailto:[EMAIL PROTECTED]
> Sent: 22 November 2003 05:09
> To: Moriyoshi Koizumi
> Cc: Steph; internals; Derick Rethans
> Subject: Re:
On 2003/11/22, at 14:08, Frank M. Kromann wrote:
Take a look at iconv.h line 80
#define iconv libiconv
This line is the problem I'll change the php_iconv.h file to include.
You must be right. Seems I overlooked that stuff totally though I
recognised the evil #define is there. I'll commit a patch
A possible fix:
diff -u -r1.97 iconv.c
--- iconv.c 2 Nov 2003 18:54:08 - 1.97
+++ iconv.c 22 Nov 2003 05:51:27 -
@@ -60,6 +60,7 @@
/* {{{ iconv_functions[]
*/
+#undef iconv
function_entry iconv_functions[] = {
PHP_NAMED_FE(iconv,php_if_iconv,
Take a look at iconv.h line 80
#define iconv libiconv
This line is the problem I'll change the php_iconv.h file to include.
- Frank
That will fix it
>
> On 2003/11/22, at 6:30, Derick Rethans wrote:
>
> > On Fri, 21 Nov 2003, Steph wrote:
> >
> >> Works on my box (no idea how sane this is, or
On 2003/11/22, at 6:30, Derick Rethans wrote:
On Fri, 21 Nov 2003, Steph wrote:
Works on my box (no idea how sane this is, or what it may break on
other
systems, please handle like barbed wire).
I think I know why this might happen... perhaps "iconv" is defined as
macro on windhoos. Can you plea
been private to helly). It's a
_recent_ change D..
> -Original Message-
> From: Derick Rethans [mailto:[EMAIL PROTECTED]
> Sent: 21 November 2003 21:31
> To: Steph
> Cc: internals
> Subject: Re: [PHP-DEV] [PATCH] fixes #26194
>
>
> On Fri, 21 Nov 2003, Steph
On Fri, 21 Nov 2003, Steph wrote:
> Works on my box (no idea how sane this is, or what it may break on other
> systems, please handle like barbed wire).
I think I know why this might happen... perhaps "iconv" is defined as
macro on windhoos. Can you please see if get_defined_functions() does
some
Works on my box (no idea how sane this is, or what it may break on other
systems, please handle like barbed wire).
- Steph
? ext/libxml/php_libxml2.def
Index: ext/iconv/iconv.c
===
RCS file: /repository/php-src/ext/iconv/iconv.c,v
ret
