Re: [PHP-DEV] [PATCH]: Fix for PDOStatement::debugDumpParams()

2010-07-20 Thread Jonah H. Harris
2010/7/20 Johannes Schlüter > > Can you open a bug and attach the patch to it please? > > > and please add the bug in "unified diff" format (diff -u) which makes it > simpler to read. > Sorry about that. I've updated the diff and submitted it as: http://bugs.php.net/bug.php?id=52384 -- Jona

Re: [PHP-DEV] [PATCH]: Fix for PDOStatement::debugDumpParams()

2010-07-20 Thread Johannes Schlüter
Hi, On Tue, 2010-07-20 at 23:02 +0200, Pierre Joye wrote: > hi, > > Can you open a bug and attach the patch to it please? and please add the bug in "unified diff" format (diff -u) which makes it simpler to read. Thanks! johannes > Thanks for your work, > > On Tue, Jul 20, 2010 at 10:30 PM, J

Re: [PHP-DEV] [PATCH]: Fix for PDOStatement::debugDumpParams()

2010-07-20 Thread Pierre Joye
hi, Can you open a bug and attach the patch to it please? Thanks for your work, On Tue, Jul 20, 2010 at 10:30 PM, Jonah H. Harris wrote: > Per the documentation > (http://php.net/manual/en/pdostatement.debugdumpparams.php), > PDOStatement::debugDumpParams should be emitting the bind parameter v

[PHP-DEV] [PATCH]: Fix for PDOStatement::debugDumpParams()

2010-07-20 Thread Jonah H. Harris
Per the documentation ( http://php.net/manual/en/pdostatement.debugdumpparams.php), PDOStatement::debugDumpParams should be emitting the bind parameter value. Currently however, it does not. Accordingly, attached is a patch for 5.2 (which also applies cleanly to 5.3), which emits the bind paramete