On Sun, Feb 5, 2017 at 2:56 AM, Andrey Andreev wrote:
> On Sat, Feb 4, 2017 at 8:29 AM, Yasuo Ohgaki wrote:
>
>>
>>
>> I will change my mind if there is convincing logical
>> reason(s) not to do this. I suppose there isn't.
>>
>
> Not only are you ignoring everybody else's arguments, but also be
Hi,
On Sat, Feb 4, 2017 at 8:29 AM, Yasuo Ohgaki wrote:
>
>
> I will change my mind if there is convincing logical
> reason(s) not to do this. I suppose there isn't.
>
Not only are you ignoring everybody else's arguments, but also behaving
like PHP is your own personal project.
Please stop.
Ch
Hi,
On Sat, Feb 4, 2017 at 1:01 AM, Yasuo Ohgaki wrote:
> Did everyone understand why I propose salt as required parameter and
> specify optional salt explicitly?
>
>
I did, and I disagreed.
> HKDF w/o salt is OK, but with salt, it's much stronger than w/o it.
> In addition, most use case with
On Sat, Feb 4, 2017 at 2:48 PM, Yasuo Ohgaki wrote:
> string hash_hkdf(string algo, string ikm [, int length = 0, string info =
> '', string salt = ''])
I copied and pasted this proto from the source.
It's wrong. Correct one is
string hash_hkdf(string algo, string ikm [, int length = 0 [, stri
On Sat, Feb 4, 2017 at 2:37 PM, Yasuo Ohgaki wrote:
> On Sat, Feb 4, 2017 at 8:56 AM, Nikita Popov wrote:
>
>> You are free to prepare a patch, but your patch will not get merged.
>>
>> Your blatant disregard of any and all feedback you receive on your
>> proposals is beginning to get on my nerv
Hi Nikita,
On Sat, Feb 4, 2017 at 8:56 AM, Nikita Popov wrote:
> You are free to prepare a patch, but your patch will not get merged.
>
> Your blatant disregard of any and all feedback you receive on your
> proposals is beginning to get on my nerves. This has played out again and
> again, most r
On Sat, Feb 4, 2017 at 12:01 AM, Yasuo Ohgaki wrote:
> Hi all,
>
> On Tue, Jan 17, 2017 at 4:01 PM, Yasuo Ohgaki wrote:
>
> > On Mon, Jan 16, 2017 at 8:16 PM, Andrey Andreev
> wrote:
> >
> >>
> >> On Mon, Jan 16, 2017 at 3:47 AM, Yasuo Ohgaki
> wrote:
> >>
> >>> Nice function, I like it.
> >>>
Hi all,
On Tue, Jan 17, 2017 at 4:01 PM, Yasuo Ohgaki wrote:
> On Mon, Jan 16, 2017 at 8:16 PM, Andrey Andreev wrote:
>
>>
>> On Mon, Jan 16, 2017 at 3:47 AM, Yasuo Ohgaki wrote:
>>
>>> Nice function, I like it.
>>> Modified patch is committed to master
>>> http://git.php.net/?p=php-src.git;a=
Hi Andrey,
On Mon, Jan 16, 2017 at 8:16 PM, Andrey Andreev wrote:
>
> On Mon, Jan 16, 2017 at 3:47 AM, Yasuo Ohgaki wrote:
>
>> Nice function, I like it.
>> Modified patch is committed to master
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=4bf7ef08061
>> 720586cb0a2f410720e26719d97f3
>>
Hi fsb,
On Tue, Jan 17, 2017 at 3:47 AM, fsb wrote:
>
> - when salt is ''(empty string), use default static known random salt
>> value.
>>Note: hkdf's salt could be known, yet provide stronger result as RFC
>> states.
>>
>
> This change renders the implementation nonstandard. And it's useles
Hi Nikita,
On Mon, Jan 16, 2017 at 8:08 PM, Nikita Popov wrote:
> Making the salt required makes no sense to me.
>
It does not make sense to me too if API requires a "salt value" always.
"salt" should be able to be omitted.
My proposal is to "make salt parameter required" and "let programmers
On Wed, Jan 11, 2017 at 2:24 PM, Andrey Andreev wrote:
> Hi all,
>
> There's a pending GitHub pull request of mine to include a HKDF
> implementation into ext/hash.
> Mostly anybody who saw it agreed that it probably doesn't require an RFC
> vote, but I hadn't originally announced it here on the
Hi,
On Mon, Jan 16, 2017 at 3:47 AM, Yasuo Ohgaki wrote:
> Nice function, I like it.
> Modified patch is committed to master
> http://git.php.net/?p=php-src.git;a=commitdiff;h=4bf7ef08061
> 720586cb0a2f410720e26719d97f3
>
> I have 2 improvement ideas.
>
>
>
> 1) Make salt parameter required.
>
>
On Mon, Jan 16, 2017 at 2:47 AM, Yasuo Ohgaki wrote:
> Hi all,
>
> On Wed, Jan 11, 2017 at 11:24 PM, Andrey Andreev wrote:
>
> > Hi all,
> >
> > There's a pending GitHub pull request of mine to include a HKDF
> > implementation into ext/hash.
> > Mostly anybody who saw it agreed that it probably
Hi all,
On Mon, Jan 16, 2017 at 10:47 AM, Yasuo Ohgaki wrote:
>
> Comments are appreciated.
> If there is no comment, I'll work on these improvements hopefully soon.
>
Forgot to mention one more thing.
I also would like to make HKDF a PHPAPI.
Regards,
--
Yasuo Ohgaki
yohg...@ohgaki.net
Hi all,
On Wed, Jan 11, 2017 at 11:24 PM, Andrey Andreev wrote:
> Hi all,
>
> There's a pending GitHub pull request of mine to include a HKDF
> implementation into ext/hash.
> Mostly anybody who saw it agreed that it probably doesn't require an RFC
> vote, but I hadn't originally announced it he
Hi all,
There's a pending GitHub pull request of mine to include a HKDF
implementation into ext/hash.
Mostly anybody who saw it agreed that it probably doesn't require an RFC
vote, but I hadn't originally announced it here on the list either, so this
is what I'm doing now ...
For technical detail
17 matches
Mail list logo
