Re: [PHP-DEV] [DRAFT] RFC - hash_pbkdf2 addition

2012-06-14 Thread Anthony Ferrara
Simon, > I personally would rename the 2nd parameter to $data as this function is not > only meant for creating secure hashes from passwords. Well, I understand your sentiment. But PBKDF stands for Password Based Key Derivation Function. Even the spec calls that parameter password: PBKDF2 (P, S

Re: [PHP-DEV] [DRAFT] RFC - hash_pbkdf2 addition

2012-06-14 Thread Simon Schick
Hi, Anthony I personally would rename the 2nd parameter to $data as this function is not only meant for creating secure hashes from passwords. Bye Simon On Thu, Jun 14, 2012 at 4:00 AM, Anthony Ferrara wrote: > Hello all, > > I've written up a quick draft version of an RFC for pull request 105

[PHP-DEV] [DRAFT] RFC - hash_pbkdf2 addition

2012-06-13 Thread Anthony Ferrara
Hello all, I've written up a quick draft version of an RFC for pull request 105 ( https://github.com/php/php-src/pull/105 ), to add hash_pbkdf2() to the core implementation. Please give it a look and provide some feedback, so that this can move into discussion as a more defined proposal. https://