Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-13 Thread Pascal MARTIN, AFUP
On 01/03/2015 02:11, Marcio Almada wrote: the voting for the "Context Sensitive Lexer" is now open. Hi, After discussing this with other members of AFUP (well, not any of the implementations, as we don't really have the expertise needed for that -- but the feature as seen by end-users), we a

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-11 Thread Marcio Almada
Hi, 2015-03-11 11:49 GMT-03:00 Nikita Popov : > On Mon, Mar 9, 2015 at 6:47 AM, Marcio Almada > wrote: > >> Hi, >> >> Just passing by to announce I already have a working version of the new >> patch: https://github.com/php/php-src/pull/1158 >> >> The patch is 100% compatible with the proposed on

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-11 Thread Dmitry Stogov
On Wed, Mar 11, 2015 at 5:49 PM, Nikita Popov wrote: > On Mon, Mar 9, 2015 at 6:47 AM, Marcio Almada > wrote: > > > Hi, > > > > Just passing by to announce I already have a working version of the new > > patch: https://github.com/php/php-src/pull/1158 > > > > The patch is 100% compatible with th

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-11 Thread Nikita Popov
On Mon, Mar 9, 2015 at 6:47 AM, Marcio Almada wrote: > Hi, > > Just passing by to announce I already have a working version of the new > patch: https://github.com/php/php-src/pull/1158 > > The patch is 100% compatible with the proposed one with the advantages: > >- Has no regression or forwar

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-09 Thread Sebastian Bergmann
Am 09.03.2015 um 09:44 schrieb Matteo Beccati: > I like the approach. I'm no lexer expert but the new PR seems much nicer. > Moreover, I like the feature itself but previously voted no on the > implementation. I've therefore switched my vote to a "yes". Dito. -- PHP Internals - PHP Runtime Deve

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-09 Thread Matteo Beccati
Hi Marcio, Just passing by to announce I already have a working version of the new patch: https://github.com/php/php-src/pull/1158 The patch is 100% compatible with the proposed one with the advantages: - Has no regression or forward compatibility risks and is highly predictable -

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-08 Thread Marcio Almada
Hi, Just passing by to announce I already have a working version of the new patch: https://github.com/php/php-src/pull/1158 The patch is 100% compatible with the proposed one with the advantages: - Has no regression or forward compatibility risks and is highly predictable - Has an very

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-04 Thread Marcio Almada
Hi 2015-03-04 5:52 GMT-03:00 Nikita Popov : > > After reviewing the implementation, I've decided to vote "no" on this RFC. > > I had originally assumed that if this proposal is limited to method names > and class constants only the implementation should be pretty simple and > robust. However it t

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-04 Thread Sebastian Bergmann
Am 04.03.2015 um 09:52 schrieb Nikita Popov: > So, tl;dr: I think the patch is too risky. Even if we can make sure that > we've covered all the current edge-cases and don't regress anything, I'm > afraid that this will cause complications with future changes. This ends up > replicating too many par

Re: [PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-03-04 Thread Nikita Popov
On Sun, Mar 1, 2015 at 2:11 AM, Marcio Almada wrote: > Hi, > > Since no more issues appeared on discussion, the voting for the "Context > Sensitive Lexer" is now open. The voting will close in exactly 14 days > counting from now: > > RFC: https://wiki.php.net/rfc/context_sensitive_lexer#votes > >

[PHP-DEV][RFC][VOTING] Context Sensitive Lexer

2015-02-28 Thread Marcio Almada
Hi, Since no more issues appeared on discussion, the voting for the "Context Sensitive Lexer" is now open. The voting will close in exactly 14 days counting from now: RFC: https://wiki.php.net/rfc/context_sensitive_lexer#votes Since so few people participated on discussions, if you decide to vot