Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-21 Thread Stephen Bach
The original patch works as it should. Substitution with user-defined characters only works in the "FROM_UNICODE" case. When converting to Unicode, U+FFFD is always substituted because it is the standard substitution character. Even the ICU library does not allow this to be changed (with good r

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Stephen Bach
Sorry for the ambiguity. Allow me to clarify: I meant that U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST should work the same as the other error modes. Otherwise, what's the point of having them? -Stephen On Tuesday 18 March 2008 06:02:36 pm Geoffrey wrote: > On 18 Mar 2008, at 19:37, Step

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Stephen Bach
erent modes that escape the illegal sequence in various ways Shouldn't U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST work the same way? -Stephen On Tuesday 18 March 2008 01:43:13 pm Andrei wrote: > Why would we not want to stop on illegal sequences? > > -Andrei > > Stephen Bach

[PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-17 Thread Stephen Bach
an error for illegal sequences. The test suite returns the same results with or without the patch. Test also attached. -Stephen Bach Index: Zend/zend_unicode.c === RCS file: /repository/ZendEngine2/zend_unicode.c,v retrieving