Re: [PHP-DEV] [VOTE][RFC] Coercive Scalar Type Hints

2015-03-12 Thread Ole Markus With
On 03/11/2015 09:05 PM, Pierre Joye wrote: > On Mar 12, 2015 2:10 AM, "Zeev Suraski" wrote: >> >> The vote on the Coercive Scalar Type Hints is now open for voting. >> >> >> >> The latest version of the RFC includes changes discussed on internals@ > last >> week: >> >> 1. Accept string->bool an

Re: [PHP-DEV] [RFC] Coercive Scalar Type Hints

2015-02-22 Thread Ole Markus With
On 02/21/2015 09:10 PM, Pádraic Brady wrote: > > On the RFC rules themselves, a few comments: > > 1. Happy to see leading/trailing spaces excluded. > 2. Rules don't make mention of leading zeroes, e.g. 0003 > 3. "1E07" might be construed as overly generous assuming we are > excluding stringy int

Re: [PHP-DEV] [RFC] [PRE-VOTE] Remove the date.timezone warning

2015-02-15 Thread Ole Markus With
On 02/15/2015 08:28 PM, Matteo Beccati wrote: > On 15/02/2015 19:02, Bob Weinand wrote: >> I'm probably going to put this into vote tomorrow. >> >> The RFC got some update from neutrality aspect and covers some >> feedback from the initial discussion thread. >> >> The link is: https://wiki.php.ne

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-14 Thread Ole Markus With
On 01/14/2015 02:35 PM, Zeev Suraski wrote: > I don’t think we’re ever going to get consensus. But judging by the > feedback to the v0.1 version, I tend to disagree that the opposers would > have blocked it. There were certainly opposers – but not that many of them > as far as I could tell. I

Re: [PHP-DEV] Proposal for serious BC compatibility aka language versioning

2013-02-03 Thread Ole Markus With
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/13 23:56, Florian Anderiasch wrote: > On 03.02.2013 23:49, Thomas Bley wrote: >> Using Debian/Ubuntu, I have "python2.6", "python2.7" and >> "python3" packages, but only one version of "php5-fpm". Maybe it >> would be better to have "php5.3-fp

[PHP-DEV] SVN Account Request: olemarkus

2012-03-06 Thread Ole Markus With
As per Pierre, required for accessing security bugs/repo etc. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-21 Thread Ole Markus With
On 22/09/11 01:41, Alan Knowles wrote: To clarify * Code changed to work around this change will not break if it is reverted. Basically it is to add is_object() before any call to is_a() * If left as is, there is reasonable potential for remote exploits in many codebases. * This change is not

Re: [PHP-DEV] Bundling "modern" extensions

2011-06-10 Thread Ole Markus With
On Fri, 10 Jun 2011 13:39:34 +0200, Johannes Schlüter wrote: On Fri, 2011-06-10 at 12:03 +0100, Keloran wrote: As far as I can see there are very few extension that are really needed in the core, the main problem comes from distributions changing the methods that PECL works or the core wor

Re: [PHP-DEV] [PATCH] Notice on array to string convertion

2011-06-02 Thread Ole Markus With
On Thu, 02 Jun 2011 15:38:00 +0200, Brian Moon wrote: I like this for the current stable branch, no bc impact and gives a way to detect such mistakes (not ideal but better than nothing). On Thu, Jun 2, 2011 at 12:11 PM, Patrick ALLAERT wrote: Hi, I would like to introduce an E_NOTICE when

Re: [PHP-DEV] Implicit isset/isempty check on short-ternary operator

2011-04-16 Thread Ole Markus With
nal description of checked ternary I strongly object to this working on non-arrays. But given that constraint, my vote goes to the checked ternary operator as well. -- Ole Markus With -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Implicit isset/isempty check on short-ternary operator

2011-04-14 Thread Ole Markus With
On Thu, 14 Apr 2011 15:25:45 +0200, Martin Scotta wrote: arrays are intent for holding values, not for represent things so use objects for that. the need for array_key_exists/isset to check for the presence of an index is a smell that you need to refactor your code for a different datatype

Re: [PHP-DEV] Implicit isset/isempty check on short-ternary operator

2011-04-14 Thread Ole Markus With
. When it comes to $_POST you probably want to use filter_input instead. Cheers, Ole Markus With -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Implicit isset/isempty check on short-ternary operator

2011-04-14 Thread Ole Markus With
On Thu, 14 Apr 2011 10:59:41 +0200, Eloy Bote Falcon wrote: What is the purpose of that generateHash function? It doesn't work in the isset check. Instead of using a multi-dimensional array, I use a flat array. Anyway, you can do a simple $a = array('foo'); isset($a[$x][$y][$z]) without

Re: [PHP-DEV] Implicit isset/isempty check on short-ternary operator

2011-04-14 Thread Ole Markus With
n a second step. However, my views on this are: I think it best to avoid discussing the actual syntax before agreeing on what we really need. -- Ole Markus With Systems Architect - Sportradar AS Developer - Gentoo Linux -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Implicit isset/isempty check on short-ternary operator

2011-04-10 Thread Ole Markus With
ted to only work for array elements. -1 for any other variable type. -- Ole Markus With -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: PHP Annotations RFC + Patch

2010-09-16 Thread Ole Markus With
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/09/10 18:00, Zeev Suraski wrote: > At 16:34 16/09/2010, Guilherme Blanco wrote: >> So the question to be answered is: Should PHP support Annotations? > > -1 for introducing a new Annotations concept and associated syntax > > +1 for adding APIs