Re: [PHP-DEV] [RFC] [VOTE] Improve openssl_random_pseudo_bytes()

2018-11-04 Thread Michael Moravec
On Fri, 2 Nov 2018 at 20:30, Sammy Kaye Powers wrote: > > Hey internals! > > Given there has been at least two weeks of discussion around the RFC, > "Improve openssl_random_pseudo_bytes()" and there doesn't seem to be > any outstanding issues, I have moved the RFC into voting phase. > > The voting

[PHP-DEV] Eligibility of array_key_exists() optimization for 7.3

2018-08-08 Thread Michael Moravec
Hi, there are some questions whether PR #3360 (Implement ZEND_ARRAY_KEY_EXISTS opcode to speed up array_key_exists()) [1] could go into 7.3.0beta2 or not. This PR adds new opcode, but also significantly improves performance of array_key_exists(), to the point that it becomes faster than isset().

[PHP-DEV] GCC -foptimize-strlen and bug #76510

2018-08-04 Thread Michael Moravec
Hi, yesterday I was digging into the bug #76510: https://bugs.php.net/bug.php?id=76510 A strange PHAR- and streams-related issue that only happens for some users/binaries. I was able to trace it down to a GCC optimization "optimize-strlen". Here's when the bug does and does not reproduce: gcc-8 w

Re: [PHP-DEV] [RFC][Vote] iterable_to_array() and iterable_count()

2018-07-17 Thread Michael Moravec
Hi, the RFC has been declined. Thank you for voting, and especially thanks to Jordi and Nikita for explaining their No vote, unlike the rest of No-voters. Thank you, M. 2018-07-09 22:13 GMT+02:00 Pedro Magalhães : > On Tue, Jul 3, 2018 at 9:48 PM Michael Moravec wrote: >> >>

Re: [PHP-DEV] [RFC][Vote] iterable_to_array() and iterable_count()

2018-07-05 Thread Michael Moravec
2018-07-05 22:35 GMT+02:00 Nikita Popov : > I voted against both functions. Jordi already explained why iterable_count() > is questionable, so let me add a comment regarding iterable_to_array(). > > Essentially my gripe is that I'm not convinced of the usefulness of this > function and am concerne

Re: [PHP-DEV] Re: [RFC][Vote] iterable_to_array() and iterable_count()

2018-07-05 Thread Michael Moravec
2018-07-05 16:43 GMT+02:00 Jordi Boggiano : > Just to explain the No vote for iterable_count, I think we'd rather advocate > people implement Countable in their iterables than to force the consumption > of an iterator just to count it as this can have side-effects and render the > iterator unusabl

[PHP-DEV] Re: [RFC][Vote] iterable_to_array() and iterable_count()

2018-07-03 Thread Michael Moravec
2018-07-04 0:23 GMT+02:00 Christoph M. Becker : > > Yeah, I'd prefer that. It's not that 2018-07-17 12:00 UTC *couldn't* > work – it's just I'd rather have some buffer time (I presume there will > be more RFCs whose voting ends close to feature freeze). Alright, updated! RFC voting now closes on

[PHP-DEV] Re: [RFC][Vote] iterable_to_array() and iterable_count()

2018-07-03 Thread Michael Moravec
On 03.07.2018 at 22:48, Michael Moravec wrote: > > > Hello internals, > > > > The RFC for adding iterable_to_array() and iterable_count() is now open > for > > voting: > > > > https://wiki.php.net/rfc/iterable_to_array-and-iterable_count > > Thanks for the

[PHP-DEV] [RFC][Vote] iterable_to_array() and iterable_count()

2018-07-03 Thread Michael Moravec
Hello internals, The RFC for adding iterable_to_array() and iterable_count() is now open for voting: https://wiki.php.net/rfc/iterable_to_array-and-iterable_count You can vote for each function separately. Voting will close on 2018-07-17 12:00 UTC. Thank you, M.

Re: [PHP-DEV] [RFC][Discussion] iterable_to_array() and iterable_count()

2018-07-01 Thread Michael Moravec
Hi Johannes, 2018-06-20 18:40 GMT+02:00 Johannes Schlüter : > > Is there any reason not to extend the existing functions to also allow > arrays? > Yes, this was discussed in the PR on GitHub: https://github.com/php/php-src/pull/3293#issuecomment-397082988 There are two main reasons to not do th

[PHP-DEV] [RFC][Discussion] iterable_to_array() and iterable_count()

2018-06-19 Thread Michael Moravec
lue sounds like a way worse option in terms of consistency and compatibility. A PR with implementation for iterable_to_array() is already submitted, iterable_count() to be added soon. Looking forward for your feedback. Thanks! Michael Moravec

[PHP-DEV] [RFC] Mixed Typehint

2017-12-18 Thread Michael Moravec
no BC break to user-land is involved. This RFC comes with a rather simple PR: https://github.com/php/php-src/pull/2603 Please let me know what you think or if you find anything unclear. Thanks! Michael Moravec

[PHP-DEV] Wiki karma for mixed type RFC

2017-07-10 Thread Michael Moravec
Hello everyone, I'd like to request a Wiki karma to be able to create an RFC for adding the mixed type. There is already a PR for this: https://github.com/php/php-src/pull/2603 Wiki username in question is "majkl". Thank you, M.