Re: [PHP-DEV] [RFC] Drop support for 32bit builds

2025-07-21 Thread Marc Bennewitz
On 21.07.25 00:05, Hanz wrote: Hello, my two cents, On Thu, Jun 19, 2025 at 9:09 PM Marc Bennewitz wrote: Hi, During the discussion about the year 2038 issue it turned out that maybe it's time to drop support for 32-bit of PHP completely. Based on that I have creat

[PHP-DEV] Re: [RFC] Drop support for 32bit builds

2025-07-21 Thread Marc Bennewitz
Hi everyone, On 19.06.25 16:08, Marc Bennewitz wrote: Hi, During the discussion about the year 2038 issue it turned out that maybe it's time to drop support for 32-bit of PHP completely. Based on that I have created an RFC to deprecate 32-bit build in 8.next and drop support for it

Re: [PHP-DEV] [RFC] Readonly property hooks

2025-07-13 Thread Marc Bennewitz
On 13.07.25 18:17, Nick wrote: On 13. Jul 2025, at 20:38, Marc Bennewitz wrote: Hi Nick, Claude, Hey Marc, I think it's important to explicitly mark it as "this value will be stored in memory", I mean just silently caching the get hook could quickly lead to unexpected

Re: [PHP-DEV] [RFC] Readonly property hooks

2025-07-13 Thread Marc Bennewitz
On 11.07.25 11:38, Nick wrote: On 11. Jul 2025, at 14:25, Claude Pache wrote: Le 11 juil. 2025 à 06:30, Nick a écrit : To not get this buried in individual answers to others: I came up with two alternative implementations which cache the computed `get` hook value. One leverages separate

Re: [PHP-DEV] [RFC] Drop support for 32bit builds

2025-06-23 Thread Marc Bennewitz
On 20.06.25 14:21, Hans Henrik Bergan wrote: On Fri, 20 Jun 2025 at 13:20, Marc Bennewitz wrote: On 19.06.25 18:55, Hans Henrik Bergan wrote: On Thu, Jun 19, 2025, 18:24 Ben Ramsey wrote: On Jun 19, 2025, at 11:08, Calvin Buckley wrote: On Jun 19, 2025, at 11:08 AM, Marc Bennewitz

Re: [PHP-DEV] [RFC] Drop support for 32bit builds

2025-06-20 Thread Marc Bennewitz
On 19.06.25 18:55, Hans Henrik Bergan wrote: On Thu, Jun 19, 2025, 18:24 Ben Ramsey wrote: > On Jun 19, 2025, at 11:08, Calvin Buckley wrote: > > On Jun 19, 2025, at 11:08 AM, Marc Bennewitz wrote: >> >> Hi, >> >> During t

Re: [PHP-DEV] [RFC] Drop support for 32bit builds

2025-06-20 Thread Marc Bennewitz
On 20.06.25 10:15, Hans Henrik Bergan wrote: On Fri, 20 Jun 2025 at 09:15, Marc Bennewitz wrote: On 19.06.25 18:08, Calvin Buckley wrote: I think the biggest arguments against this would be: - embedded systems; think of PHP in use for i.e. router web UIs. While I suspect a lot of these are

Re: [PHP-DEV] [RFC] Drop support for 32bit builds

2025-06-20 Thread Marc Bennewitz
On 19.06.25 18:08, Calvin Buckley wrote: I think the biggest arguments against this would be: - embedded systems; think of PHP in use for i.e. router web UIs. While I suspect a lot of these are going to be i.e. AArch64/RV64 in the future, there might be a long tail of existing systems. Of cours

[PHP-DEV] [RFC] Drop support for 32bit builds

2025-06-19 Thread Marc Bennewitz
Hi, During the discussion about the year 2038 issue it turned out that maybe it's time to drop support for 32-bit of PHP completely. Based on that I have created an RFC to deprecate 32-bit build in 8.next and drop support for it in 9. RFC: https://wiki.php.net/rfc/drop_32bit_support Ope

Re: [PHP-DEV] Year 2038 issue

2025-06-18 Thread Marc Bennewitz
On 16.06.25 19:01, Yogarine wrote: Hi all, On 16 Jun 2025, at 17:24, Rob Landers wrote: On Mon, Jun 16, 2025, at 16:54, Alexandru Pătrănescu wrote: On Mon, Jun 16, 2025 at 4:03 PM Marc Bennewitz wrote: Hi all, It's 12.5 years only until the timestamps in PHP on 32bit will not wo

Re: [PHP-DEV] Year 2038 issue

2025-06-16 Thread Marc Bennewitz
On 16.06.25 17:21, Rob Landers wrote: On Mon, Jun 16, 2025, at 16:54, Alexandru Pătrănescu wrote: On Mon, Jun 16, 2025 at 4:03 PM Marc Bennewitz wrote: Hi all, It's 12.5 years only until the timestamps in PHP on 32bit will not work as expected anymore. Hi, I think

Re: [PHP-DEV] Year 2038 issue

2025-06-16 Thread Marc Bennewitz
On 16.06.25 16:16, Kamil Tekiela wrote: Why do you say that these functions do not work with year 2038? https://3v4l.org/61VLh I wouldn't be opposed to deprecating them, but I don't know if we have a good enough reason to do so. https://3v4l.org seems to be 64bit now ;) -> https://3v4l.org/1F

[PHP-DEV] Year 2038 issue

2025-06-16 Thread Marc Bennewitz
Hi all, It's 12.5 years only until the timestamps in PHP on 32bit will not work as expected anymore. The DateTime[Immutable] classes use 64bit integers internally already but there are still a couple of places where this is an issue in the API due to PHP integer limit: Based on that I pers

Re: [PHP-DEV] Allow hooks in `readonly` promoted properties

2025-06-04 Thread Marc Bennewitz
Hi Larry, On 03.06.25 19:03, Larry Garfield wrote: On Mon, Jun 2, 2025, at 11:34 PM, Nick wrote: I would like to add, personally, I don’t believe the above is dumb: ```php class Dumb { public readonly int $value { get => $this->value * random_int(1, 100); } } ``` I think it is a legitimate u

Re: [PHP-DEV] Enum + property hook getter

2025-02-08 Thread Marc Bennewitz
Hi Tim, Unintentionally, I first replied to Tim only but it was meant to be send to the list. On 07.02.25 16:11, Tim Düsterhus wrote: Hi Am 2025-02-07 16:03, schrieb Marc Bennewitz: Is that something feasible and how complicated would that be to implement? Supporting this might cause

[PHP-DEV] Enum + property hook getter

2025-02-07 Thread Marc Bennewitz
>name, 3);     } } Means, allowing get-only property hooks on enums reducing the need to write "old school" getter methods. Is that something feasible and how complicated would that be to implement? Best, Marc Bennewitz OpenPGP_0x3936ABF753BC88CE.asc Description: OpenPGP public key

Re: [PHP-DEV] Pattern matching details questions

2025-02-04 Thread Marc Bennewitz
On 04.02.25 08:51, Rob Landers wrote: On Tue, Feb 4, 2025, at 05:31, Larry Garfield wrote: Hi folks.  Ilija is still working on the implementation for the pattern matching RFC, which we want to complete before proposing it officially in case we run into implementation challenges. Such as t

Re: [PHP-DEV] Empty subject in match and switch constructions

2025-02-04 Thread Marc Bennewitz
Hi Claude, On 04.02.25 11:10, Claude Pache wrote: Le 4 févr. 2025 à 10:34, Dmitry Derepko a écrit : Hi, Claude! On Feb 4, 2025, at 11:44 AM, Claude Pache wrote: Hi, One issue to resolve is how to interpret: ```php $x = match {   preg_match('/a/', 'a') => "will it be matched ..."  , d

[PHP-DEV] Idea: Inline enum

2024-12-19 Thread Marc Bennewitz
Hi all, I got a case where I have to create multiple different formatters and also I want to define the possible tokens of each formatter accessible in specific groups using enums. During that task I'm wondering why it's not possible to create an inline enum definition similar to an anonymou

[PHP-DEV] DatePeriod microsecond support

2024-08-21 Thread Marc Bennewitz
Hi, The DatePeriod class works based on DateTimeInterface but does not take the microsecond of the date-time instance into account [1]. To fix that I have opened a small PR [2] 2 months ago which got approved quickly as well but nothing more happened until then. I'm wring here to kindly ask

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.4

2024-07-01 Thread Marc Bennewitz
Hi Gina, On 25.06.24 16:36, Gina P. Banyard wrote: Hello internals, It is this time of year again where we proposed a list of deprecations to add in PHP 8.4: https://wiki.php.net/rfc/deprecations_php_8_4 As a reminder, this list has been compiled over the course of the past year by various

Re: [PHP-DEV] [Early Feedback] Pattern matching

2024-06-21 Thread Marc Bennewitz
Hi Larry, On 20.06.24 19:38, Larry Garfield wrote: Hello, peoples. Ilija and I have been working on and off on an RFC for pattern matching since the early work on Enumerations. A number of people have noticed and said they're looking forward to it. It's definitely not going to make it into

Re: [PHP-DEV] [RFC][Vote announcement] Property hooks

2024-04-12 Thread Marc Bennewitz
Hi, On 12.04.24 04:55, Juliette Reinders Folmer wrote: Hi Ilija, On 12-4-2024 1:00, Ilija Tovilo wrote: Oh, and hang on, they *can* be read from a method in the same class as long as that method is called from within the set hook, so now the method will need to either do a backtrace or use

[PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int

2024-04-02 Thread Marc Bennewitz
Hi internals, On 17.03.24 13:23, Marc Bennewitz wrote: Hello internals, I have opened the vote for the "Rounding Integers as int" RFC: https://wiki.php.net/rfc/integer-rounding Do to Easter weekend the vote will run for two weeks and two days until Tue the 2nd of April 2024. T

Re: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int

2024-03-22 Thread Marc Bennewitz
Hi Bob, and sorry for the late reply ... On 19.03.24 01:05, Bob Weinand wrote: Hey Marc, On 18.3.2024 08:53:01, Marc Bennewitz wrote: Hi Bob, On 17.03.24 14:59, Bob Weinand wrote: On 17.3.2024 13:23:04, Marc Bennewitz wrote: Hello internals, I have opened the vote for the "Rou

Re: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int

2024-03-18 Thread Marc Bennewitz
Hi Vincent, On 17.03.24 22:59, Vincent Langlet wrote: Hi, IMHO, the more meaningful cases of the RFC are missing : round(float, precision: >= 0): int|float // only cast to float for int overflow ceil(float): int|float // only cast to float for int overflow floor(float): int|float // only cast t

Re: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int

2024-03-18 Thread Marc Bennewitz
Hi Bob, On 17.03.24 14:59, Bob Weinand wrote: On 17.3.2024 13:23:04, Marc Bennewitz wrote: Hello internals, I have opened the vote for the "Rounding Integers as int" RFC: https://wiki.php.net/rfc/integer-rounding Do to Easter weekend the vote will run for two weeks and two days

Re: [PHP-DEV] Re: [RFC] [Discussion] [VOTE] Rounding Integers as int

2024-03-17 Thread Marc Bennewitz
On 17.03.24 14:10, Tim Düsterhus wrote: Hi On 3/17/24 13:23, Marc Bennewitz wrote: I have opened the vote for the "Rounding Integers as int" RFC: https://wiki.php.net/rfc/integer-rounding Please also update the Status within the RFC itself and move it to the correct section

[PHP-DEV] [RFC] [Discussion] [VOTE] Rounding Integers as int

2024-03-17 Thread Marc Bennewitz
Hello internals, I have opened the vote for the "Rounding Integers as int" RFC: https://wiki.php.net/rfc/integer-rounding Do to Easter weekend the vote will run for two weeks and two days until Tue the 2nd of April 2024. Best regards, Marc Bennewitz OpenPGP_0x3936ABF753

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2024-03-10 Thread Marc Bennewitz
Hi Larry, On 10.03.24 16:52, Larry Garfield wrote: On Sun, Mar 10, 2024, at 10:31 AM, Gina P. Banyard wrote: On Saturday, 9 March 2024 at 16:00, Larry Garfield wrote: I am still opposed to this. Logically, ceil/float/round should be returning ints, not floats. Only returning ints if it was

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2024-02-25 Thread Marc Bennewitz
Hi all, I now have updated the RFC to allow to opt-in to new behavior on PHP 8.4 and be able to opt-out to previous behavior in PHP 9.0 via new parameter "force_float". Also the deprecation has been removed as nobody liked it. Best regards, Marc On 26.09.23 12:39, Marc Bennewitz

Re: [PHP-DEV] [RFC][Discussion] Raising zero to the power of negative number

2024-02-25 Thread Marc Bennewitz
Hi Jorg, On 13.01.24 00:25, Jorg Sowa wrote: Thank you for the suggestions. I agree that error message should be more meaningful. I changed it. The main driver of this change is to match the division by zero behavior for both operators which can operate on both integers and floats. Would it mak

Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2

2024-02-23 Thread Marc Bennewitz
Hi Larry, first of all thank you very much for this amazing work you two have been done :+1:. On 23.02.24 00:56, Larry Garfield wrote: On Wed, Feb 21, 2024, at 11:02 PM, Matthew Weier O'Phinney wrote: On Wed, Feb 21, 2024 at 12:57 PM Larry Garfield wrote: After much on-again/off-again work

Re: [PHP-DEV] Requesting RFC karma

2024-02-20 Thread Marc Bennewitz
On 20.02.24 09:58, Derick Rethans wrote: On 20 February 2024 08:41:19 GMT, Marc Bennewitz wrote: Hi Hans, On 16.02.24 13:05, Hans Henrik Bergan wrote: My name is "Hans Henrik Bergan", usually go by the nickname "divinity76", I've contributed to OSS (includi

Re: [PHP-DEV] Requesting RFC karma

2024-02-20 Thread Marc Bennewitz
Hi Hans, On 16.02.24 13:05, Hans Henrik Bergan wrote: My name is "Hans Henrik Bergan", usually go by the nickname "divinity76", I've contributed to OSS (including PHP) for years, and am currently involved in 3 things that might require an RFC, and requesting RFC karma for wiki account "divinity7

Re: [PHP-DEV] Custom object equality

2023-10-24 Thread Marc Bennewitz
Hi Jordan, On 23.10.23 22:07, Jordan LeDoux wrote: Implementing the compare handler for an overload requires adding two new entries to ZEND_AST_BINARY_OP because the `>` and `<` comparisons have to be preserved in the AST in order to call the correct object handler. THAT requires updating OpCach

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-19 Thread Marc Bennewitz
Hi, On 26.09.23 12:39, Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding Best, Marc Based on the discussion I see two groups. The one that would like to change this behavior without message (bug fix) and others tha

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-19 Thread Marc Bennewitz
Hi Jakub, On 16.10.23 00:17, Jakub Zelenka wrote: Your JSON example is a bit unrelated because if you care about your types your should have used JSON_RESERVE_ZERO_FRACTION in the first place else you should not care about int vs float at all. The thing is that JSON might be encoded by anothe

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Marc Bennewitz
Hi Robert, On 13.10.23 13:44, Robert Landers wrote: On Fri, Oct 13, 2023 at 1:26 PM Jakub Zelenka wrote: On Tue, Sep 26, 2023 at 11:39 AM Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding I would personally pre

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Marc Bennewitz
Hi Jakub, On 13.10.23 13:25, Jakub Zelenka wrote: On Tue, Sep 26, 2023 at 11:39 AM Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding I would personally prefer a new function for rounding integers if anyone wan

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-06 Thread Marc Bennewitz
Hi Tim, On 05.10.23 21:57, Tim Düsterhus wrote: Hi On 10/4/23 08:35, Marc Bennewitz wrote: As far as I understand you are in favor of option 1. (considering it a bugfix) but how do you make sure this will not lead to different application behavior overlooked on upgrading? Also there is no way

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-06 Thread Marc Bennewitz
Hi George, On 05.10.23 14:12, G. P. B. wrote: On Thu, 5 Oct 2023 at 07:40, Marc Bennewitz wrote: I don't see a bug or broken behavior here as these functions were processing floating point numbers since forever. https://3v4l.org/PrrmO That's not my point, the point is

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-04 Thread Marc Bennewitz
On 05.10.23 01:38, G. P. B. wrote: On Tue, 26 Sept 2023 at 11:39, Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding I don't understand the point of the deprecation phase at all. Frankly, I consider this RFC

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-03 Thread Marc Bennewitz
Hi, On 03.10.23 14:41, Tim Düsterhus wrote: Hi On 9/30/23 08:26, Marc Bennewitz wrote: The deprecation would act as an information for upcoming behavior change, not classical deprecation of future removal. If the new behavior is what you want, than you don't need to change anything

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-29 Thread Marc Bennewitz
Hi Tim, On 29.09.23 17:28, Tim Düsterhus wrote: Hi On 9/26/23 12:39, Marc Bennewitz wrote: I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding I find the proposal reasonable, but I don't like the deprecation proposal, because it does not allow

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Marc Bennewitz
Hi Niels, On 29.09.23 09:07, Niels Dossche wrote: Hi internals Discussion seems to have died down. Today, it's been 14 days since the last major change was done to the RFC (i.e. the class hierarchy update). And it's also been close to 4 weeks since I first announced the RFC it on the mailing

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-29 Thread Marc Bennewitz
Hi Saki, On 27.09.23 02:18, Saki Takamachi wrote: Hi, Marc. There is one additional case to consider. It's backwards compatible. If `strict_types` is not `1`, the code currently out there may be passing `int` to these functions. Therefore, it is better to be aware that such code can have dest

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-26 Thread Marc Bennewitz
Hi Larry, On 26.09.23 20:41, Larry Garfield wrote: On Tue, Sep 26, 2023, at 10:39 AM, Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding Best, Marc I'm honestly kind of confused by this. The basic con

[PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-26 Thread Marc Bennewitz
Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding Best, Marc OpenPGP_0x3936ABF753BC88CE.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

[PHP-DEV] number_format() Support rounding negative places

2023-06-23 Thread Marc Bennewitz
Hi internals, I have opened a very small PR at https://github.com/php/php-src/pull/11487 I was told to send an email here and ask for feedback. This PR adds support for rounding negative |$decimals| in |number_format()|. Previously negative |$decimals| got silently ignored and the number got

Re: [PHP-DEV] rounding integers

2023-05-22 Thread Marc Bennewitz
On 21.05.23 17:20, Larry Garfield wrote: On Sun, May 21, 2023, at 7:18 AM, Rowan Tommins wrote: On 21 May 2023 13:00:30 BST, Dan Ackroyd wrote: On Sun, 21 May 2023 at 06:16, Marc wrote: Do you think this could be an acceptable BC-break No. Suggesting changing a 30 year old maths operations

Re: [PHP-DEV] [RFC][Under discussion] Fetch properties in const expressions

2022-06-27 Thread Marc Bennewitz
On 24.06.22 23:55, Larry Garfield wrote: On Fri, Jun 24, 2022, at 11:43 AM, Nicolas Grekas wrote: Hi everyone I'd like to start a discussion on a simple RFC to allow fetching properties in constant expressions. https://wiki.php.net/rfc/fetch_property_in_const_expressions The RFC proposes add

Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes

2022-06-26 Thread Marc Bennewitz
On 21.06.22 01:01, Dan Ackroyd wrote: Hi, Following previous discussions, here is an RFC to have DB specific classes for PDO. https://wiki.php.net/rfc/pdo_driver_specific_subclasses Hi Dan, Thanks for your RFC! I do have some recommendations for it: 1. It would be great if driver specific

Re: [PHP-DEV] Alias stdClass to DynamicObject?

2021-09-07 Thread Marc Bennewitz
On 06.09.21 17:28, Nikita Popov wrote: Hi internals, In the thread for deprecation of dynamic properties, Rowan suggested that we alias "stdClass" to "DynamicObject" in https://externals.io/message/115800#115802. I wanted to split this discussion off into a separate thread, as this can be deci

Re: Fwd: Re[2]: [PHP-DEV] PHP 8.1 enum const expressions problem

2021-07-30 Thread Marc Bennewitz
On 30.07.21 02:01, Кирилл Несмеянов wrote: Yes, I saw this short description in your RFC ( https://wiki.php.net/rfc/enumerations ) about «enum sets». However, I do not quite understand why we can not now add a cast to scalars (string and int) and math expressions, which would solve this prob

Re: [PHP-DEV] Re: [RFC] is_literal

2021-06-18 Thread Marc Bennewitz
On 18.06.21 08:00, Craig Francis wrote: On Wed, 16 Jun 2021 at 18:24, Craig Francis wrote: On Sat, 12 Jun 2021 at 18:00, Craig Francis wrote: I'd like to start the discussion on the is_literal() RFC: https://wiki.php.net/rfc/is_literal Following up on the is_literal() RFC, thanks for th

Re: [PHP-DEV] Re: [RFC] Object-scope RNG implementation

2021-01-19 Thread Marc Bennewitz
Am 19.01.21, 17:20 schrieb "Nikita Popov" : * 64-bit: I looked over your implementation, and I think your approach to handling 64-bits is correct. You only call next64() if the requested range is larger than 32-bit, and that can only happen on 64-bit systems, thus guaranteeing

Re: [PHP-DEV] [RFC] Enumerations

2020-12-05 Thread Marc Bennewitz
Am 05.12.20, 16:21 schrieb "Rowan Tommins" : (Apologies if this posts twice, I may have accidentally hit send before I'd finished writing it) On 05/12/2020 14:21, Marc Bennewitz wrote: > * Do cases have a stable ordinal number / position and

Re: [PHP-DEV] [RFC] Enumerations

2020-12-05 Thread Marc Bennewitz
Am 05.12.20, 16:08 schrieb "Larry Garfield" : On Sat, Dec 5, 2020, at 8:21 AM, Marc Bennewitz wrote: > > * How can you access a defined case value? > Something like `Suit::Spades->value()` At the moment it's only accessible via the :

Re: [PHP-DEV] [RFC] Enumerations

2020-12-05 Thread Marc Bennewitz
Am 05.12.20, 00:25 schrieb "Larry Garfield" : Greetings, denizens of Internals! Ilija Tovilo and I have been working for the last few months on adding support for enumerations and algebraic data types to PHP. This is a not-small task, so we've broken it up into several stages. The f

Re: [PHP-DEV] [RFC][Under Discussion] Add functions array_key_first()and array_key_last()

2018-06-26 Thread Marc Bennewitz
Hi all, I just want to add some information that I feel it's missing in that discussion - I'm sorry if it was mentioned already. 1. It's already possible to extract the key and value of any index position of an array using array_slice: https://3v4l.org/mib99 2. "array_[key|value]_[first|las

Re: [PHP-DEV] PHP_OS_FAMILY and macOS

2017-06-13 Thread Marc Bennewitz
Am 13.06.2017 um 21:35 schrieb Davey Shafik: Given that iPad (and iPhone) both run iOS which is based on Darwin, and Apple just relaxed the rules on running interpreted code, and we are already seeing IDEs spring up for the device, we should use "Darwin", rather than "Mac". This also encompasse

Re: [PHP-DEV] [PATCH] Make var_export() output "(object)array(..." instead of "stdClass::__set_state(..." for stdClass

2017-03-14 Thread Marc Bennewitz
Am 14.03.2017 um 20:26 schrieb Fleshgrinder: On 3/14/2017 7:57 PM, Andrea Faulds wrote: Hi everyone, Since stdClass has no __set_state method, var_export() produces unusable output if given an object of that class. I wrote a patch that would make var_export() produce a cast to object instead,

Re: [PHP-DEV] Re: [RFC][Discuss] Arrow Functions

2017-01-30 Thread Marc Bennewitz
Am 31.01.2017 um 05:53 schrieb Stephen Reay: Hi Andrea, All, On 31 Jan 2017, at 08:12, Andrea Faulds wrote: Is it necessary to introduce a new keyword, fn? I think you'd get a similar benefit from: function($x) => $arr[$x] Likewise, is it necessary to restrict auto-capture to the => s

[PHP-DEV] Allow "static" type

2017-01-27 Thread Marc Bennewitz
Hi all, I would like to know your opinion about using "static" as type-hint similar to "self" and how simple / complex it would be to implement. Example - using static: https://3v4l.org/XqDma class Base { public static function test(static $obj) : static { echo get_class($obj) .

Re: [PHP-DEV] [RFC][DISCUSSION] Object type hint, now with added variance

2016-11-23 Thread Marc Bennewitz
Am 23.11.2016 um 01:52 schrieb Dan Ackroyd: Hi, This is the reintroduction of the Object Type RFC for discussion. There was previously strong feedback from people who would prefer that the inheritance checks for methods that use object types should be co/contravariant. This has been added to

Re: [PHP-DEV] strtod and NaN vs. zero

2016-10-24 Thread Marc Bennewitz
Hi Andrea, Am 24.10.2016 um 15:40 schrieb Andrea Faulds: Hi, Marc Bennewitz wrote: But I'm still curious why casting any non numeric string results in the valid number float(0) where there is a special value in floating point numbers declared to represent not a number values. Be

Re: [PHP-DEV] strtod and NaN vs. zero

2016-10-23 Thread Marc Bennewitz
Am 23.10.2016 um 21:13 schrieb Marc Bennewitz: Am 23.10.2016 um 13:49 schrieb Niklas Keller: 2016-10-23 12:55 GMT+02:00 Marc Bennewitz mailto:dev@mabe.berlin>>: Hi internals, On casting a non numeric value to a float in PHP the result will be float(0). In PHP-

Re: [PHP-DEV] strtod and NaN vs. zero

2016-10-23 Thread Marc Bennewitz
Am 23.10.2016 um 13:49 schrieb Niklas Keller: 2016-10-23 12:55 GMT+02:00 Marc Bennewitz mailto:dev@mabe.berlin>>: Hi internals, On casting a non numeric value to a float in PHP the result will be float(0). In PHP-7.0 an exception was introduced that on casting a

[PHP-DEV] strtod and NaN vs. zero

2016-10-23 Thread Marc Bennewitz
Hi internals, On casting a non numeric value to a float in PHP the result will be float(0). In PHP-7.0 an exception was introduced that on casting a string "/\s*NaN\s*/i" will result in float(NaN). https://3v4l.org/2Xakm Wouldn't it be more logical and expected to return NaN in all cases o

[PHP-DEV] Class Constant Visibility BC Break

2016-08-21 Thread Marc Bennewitz
Hi, I encountered a problem of my library with the new class constant visibility functionality. The problem is that I'm using ReflectionClass::getConstants() to detect class constants but I'm only interested in public constants. Before class constants were public by definition but now it c

Re: [PHP-DEV] Bug or expected behavior?

2016-05-31 Thread Marc Bennewitz
On 05/31/2016 09:59 PM, Nikita Popov wrote: On Tue, May 31, 2016 at 9:54 PM, Marc Bennewitz <mailto:dev@mabe.berlin>> wrote: Hi, today I was running into an issue with a function lookup over namespace. https://3v4l.org/qF7cK fails https://3v4l.org/evVic works

[PHP-DEV] Bug or expected behavior?

2016-05-31 Thread Marc Bennewitz
Hi, today I was running into an issue with a function lookup over namespace. https://3v4l.org/qF7cK fails https://3v4l.org/evVic works For me it looks like the function lookup for "is_null" in this case gets cached on first use and on second call no check will be done if this function exists i

Re: [PHP-DEV] [RFC] Fix inconsistent behavior of $this variable

2016-05-24 Thread Marc Bennewitz
On 05/24/2016 11:57 AM, Rowan Collins wrote: On 24/05/2016 06:45, Jesse Schalken wrote: I'm curious, what is it about $this that makes it special in the first place? Can't it be a normal local variable that happens to already be assigned at the start of a method? There are a few things that t

Re: [PHP-DEV] Immutable modifier

2015-11-17 Thread Marc Bennewitz
FYI there was a very small discussion about it ~ 1 year ago https://www.mail-archive.com/internals@lists.php.net/msg71521.html On 11/16/2015 10:15 AM, Chris Riley wrote: Hi, There has been a lot of interest recently (eg psr-7) in immutable data. I'm considering putting an RFC together to add la

Re: [PHP-DEV] [Question] Variadic method signature compatibility between 5.6 and 7.0

2015-11-02 Thread Marc Bennewitz
Hi Rowan, On 11/02/2015 05:41 PM, Rowan Collins wrote: Alexander Lisachenko wrote on 02/11/2015 11:12: First definition declares exactly one single parameter, which can be absent during the method call, so I can even write public static function test() {} Second definition defines zero or mo

Re: [PHP-DEV] [RFC] Void Return Type (v0.2, reöpening)

2015-10-15 Thread Marc Bennewitz
On 10/15/2015 01:19 AM, Larry Garfield wrote: On 10/14/2015 06:00 PM, Andrea Faulds wrote: >> Both you and Stas have said this, but it's only true if we solely >> consider C-like languages. Other languages do different things. In >> the PHP manual, Hack, TypeScript, ActionScript, and most lik

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-07 Thread Marc Bennewitz
On 09/07/2015 08:43 AM, Sean DuBois wrote: On Sun, Sep 06, 2015 at 06:47:56PM +0100, Andrea Faulds wrote: Hi Sean, Sean DuBois wrote: I am starting this discussion to get peoples opinion on the overall feature, and find someone who would be interested in watching over my progress and making

Re: [PHP-DEV] Headsup: PHP7 feature freeze

2015-06-28 Thread Marc Bennewitz
On 06/28/2015 09:22 PM, Christoph Becker wrote: Marc Bennewitz wrote: On 06/25/2015 09:48 PM, Aaron Piotrowski wrote: On Jun 25, 2015, at 2:39 PM, Marc Bennewitz mailto:dev@mabe.berlin>> wrote: Nice to see this - didn't noted it in the last month :) But there is one edge case

Re: [PHP-DEV] Headsup: PHP7 feature freeze

2015-06-28 Thread Marc Bennewitz
On 06/25/2015 09:48 PM, Aaron Piotrowski wrote: On Jun 25, 2015, at 2:39 PM, Marc Bennewitz <mailto:dev@mabe.berlin>> wrote: Nice to see this - didn't noted it in the last month :) But there is one edge case that is not handled by PHP-7 at current behavior; http://3v4l.or

Re: [PHP-DEV] Headsup: PHP7 feature freeze

2015-06-25 Thread Marc Bennewitz
On 06/25/2015 09:39 PM, Marc Bennewitz wrote: On 06/25/2015 09:31 PM, Christoph Becker wrote: Marc Bennewitz wrote: I would really like to see directly calling a string of "Class::method" be fixed for 7.0. It's currently resulting in a fatal error and is inconsistent with

Re: [PHP-DEV] Headsup: PHP7 feature freeze

2015-06-25 Thread Marc Bennewitz
On 06/25/2015 09:31 PM, Christoph Becker wrote: Marc Bennewitz wrote: I would really like to see directly calling a string of "Class::method" be fixed for 7.0. It's currently resulting in a fatal error and is inconsistent with call_user_func[_array], is_callable and the cal

Re: [PHP-DEV] Headsup: PHP7 feature freeze

2015-06-25 Thread Marc Bennewitz
On 06/25/2015 05:03 PM, Kalle Sommer Nielsen wrote: Howdy This is a quick heads up that we plan to have the next release of 7.0.0 be Beta 1, this marks a feature freeze and from there on, we will switch focus on to stabilization, regressions and other bug fixes. Beta 1 is schedule to be tagge

Re: [PHP-DEV] Migrating PHP classes to built in namespace

2015-06-04 Thread Marc Bennewitz
On 06/04/2015 10:01 AM, Yasuo Ohgaki wrote: Hi all, On Thu, Jun 4, 2015 at 12:07 AM, Sara Golemon wrote: On Wed, Jun 3, 2015 at 1:33 AM, Dominic Grostate wrote: Has there been any discussion or consideration towards migrating or at least aliasing all built in classes to a Php vendor names

Re: [PHP-DEV] Method call overhead

2015-06-04 Thread Marc Bennewitz
On 06/04/2015 06:35 AM, Yasuo Ohgaki wrote: Hi Brian, On Thu, Jun 4, 2015 at 7:33 AM, Brian Moon wrote: This is a better representation of what you are trying to show. It removes all the magic call back stuff that could be adding to the slowness you are seeing. In addition, it does not crea

Re: [PHP-DEV] [RFC] Throwable Interface

2015-05-25 Thread Marc Bennewitz
On 05/24/2015 11:32 PM, Yasuo Ohgaki wrote: Hi Aaron, On Sun, May 24, 2015 at 5:12 AM, Aaron Piotrowski wrote: I’ve created an RFC for modifying the exception hierarchy for PHP 7, adding Throwable interface and renaming the exceptions thrown from fatal errors. The RFC is now ready for discu

Re: [PHP-DEV] [RFC] Throwable Interface

2015-05-25 Thread Marc Bennewitz
On 05/24/2015 10:11 PM, Aaron Piotrowski wrote: On May 24, 2015, at 2:08 PM, Marc Bennewitz wrote: Where are the new classes and the interface located if it's not in the global namespace or do I muss something? Sorry if what I wrote wasn’t clear. Throwable, Error, TypeError

[PHP-DEV] ::class wrong case

2015-05-25 Thread Marc Bennewitz
Hi, I have noted that detecting a class name using "::class" it will return the called case instead of the original case. see http://3v4l.org/97K36 That's annoying as I like to check the right class case on autoload to detect mistakes. Sure, class names in PHP are case-insensitive but files

Re: [PHP-DEV] [RFC] Throwable Interface

2015-05-24 Thread Marc Bennewitz
On 05/23/2015 10:12 PM, Aaron Piotrowski wrote: Hello, I’ve created an RFC for modifying the exception hierarchy for PHP 7, adding Throwable interface and renaming the exceptions thrown from fatal errors. The RFC is now ready for discussion. RFC: https://wiki.php.net/rfc/throwable-interface

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-04-30 Thread Marc Bennewitz
Am 30.04.2015 um 14:30 schrieb Julien Pauli: On Thu, Apr 30, 2015 at 6:51 AM, Sebastian Bergmann wrote: Am 30.04.2015 um 02:50 schrieb Stanislav Malyshev: I like the idea, however we do have the deadline and the deadline has been passed. So I wonder if we can't keep it for 7.1 That means

Re: [PHP-DEV] Re: Fix division by zero to throw exception

2015-04-04 Thread Marc Bennewitz
Am 04.04.2015 um 00:13 schrieb Andrea Faulds: On 3 Apr 2015, at 23:08, Dmitry Stogov wrote: On Apr 4, 2015 12:34 AM, "Nikita Popov" wrote: Don't think we need to disable compile-time evaluation for 2) and 3). It'll just end up being a compile error in that case. I think if you have 1 % 0

Re: [PHP-DEV] [RFC][VOTE] Constructor behaviour of internal classes

2015-04-04 Thread Marc Bennewitz
Hi Nikita, Dmitry, I think it's a mistake to throw a TypeException on invalid argument count as in this case it has nothing to do with a type. Marc Am 03.04.2015 um 20:48 schrieb Dmitry Stogov: I don' t see any problems. Thanks. Dmitry. On Fri, Apr 3, 2015 at 6:31 PM, Nikita Popov wrote:

Re: [PHP-DEV] Overwrite return type-hint into a more specific one

2015-04-01 Thread Marc Bennewitz
Hi Anthony, Am 01.04.2015 um 21:25 schrieb Anthony Ferrara: Marc, On Wed, Apr 1, 2015 at 2:46 PM, Marc Bennewitz wrote: Hi internals, On experimenting with return type-hints I noted an inconsistency on overwriting an existing hint to a more specific one. On adding a non existing return

Re: [PHP-DEV] Deprecate setlocale?

2015-04-01 Thread Marc Bennewitz
Am 01.04.2015 um 20:58 schrieb Stanislav Malyshev: Hi! https://bugs.php.net/bug.php?id=67127 - breaks DateTime This looks like misunderstanding how float-to-string works. If you asked it to put commas as decimal separator, don't be surprised it puts commas as decimal separator. This should

Re: [PHP-DEV] Deprecate setlocale?

2015-04-01 Thread Marc Bennewitz
Hi Am 01.04.2015 um 21:02 schrieb Stanislav Malyshev: Hi! - make strtoupper/strtolower etc. to work with ascii only This would be a bad idea, however much better idea is to make *system* case folding (i.e. methods, classes, etc.) use ascii-only. Which we already mostly do (see zend_op

[PHP-DEV] Overwrite return type-hint into a more specific one

2015-04-01 Thread Marc Bennewitz
Hi internals, On experimenting with return type-hints I noted an inconsistency on overwriting an existing hint to a more specific one. On adding a non existing return type-hint on overwrite it's fine but it's logically the same (this previously was an E_STRICT). http://3v4l.org/YdB8s - works

Re: [PHP-DEV] Deprecate setlocale?

2015-04-01 Thread Marc Bennewitz
Am 01.04.2015 um 18:15 schrieb Dan Ackroyd: Hi, I'd like to get people's feedback for the idea of making setlocale be either deprecated and to be removed eventually or just increasing the warning level against people using it. What if the system is configured with a different locale? OK we co

Re: [PHP-DEV] Exception hierarchy: open issues

2015-03-30 Thread Marc Bennewitz
Am 30.03.2015 um 12:58 schrieb Thomas Punt: Hey, Imho TypeException may not be best name for it, as it's also thrown for non-type related error conditions, like mismatched argument count. Would SignatureException be a more apt name for these error conditions? We already have an InvalidArgume

Re: [PHP-DEV] 回复: [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-21 Thread Marc Bennewitz
I also had a question! Didn't you noticed it? Am 20.03.2015 um 16:49 schrieb Marc Bennewitz: Why not simply allow the callback to be an array, too? Marc Am 21.03.2015 um 09:14 schrieb Xinchen Hui: Hey: On Fri, Mar 20, 2015 at 9:14 PM, Xinchen Hui wrote: Hey: On Fri, Mar 20, 2015 at

Re: [PHP-DEV] 回复: [RFC][DISCUSSION] Add preg_replace_callback_array function

2015-03-20 Thread Marc Bennewitz
Am 20.03.2015 um 09:03 schrieb Wei Dai: Hi internals, Hi internals, The RFC to add a user-land function for an easy-to-use and reliable preg_replace_callback_array() in PHP is up for discussion: https://wiki.php.net/rfc/preg_replace_callback_array This proposes adding one function: `pre

  1   2   >