I propose the following patch to prevent segfault for openssl_decrypt as
detailed in https://bugs.php.net/bug.php?id=61124
Index: ext/openssl/openssl.c
===
--- ext/openssl/openssl.c (revision 323312)
+++ ext/openssl/openssl.c
:
> Hello,
>
> On Wed, Jan 25, 2012 at 9:32 PM, Kiyoto Tamura wrote:
>> Also, I am not sure if php_trim is what we want here. It looks like vrana's
>> initial proposal was to discard everything after CR-LF. This is different
>> from trimming CR/LF/whitespace at the e
ion
as to why we might want to allow CR-LF in the user agent value.
On Jan 25, 2012, at 7:33 PM, Chris Stockton wrote:
> Hello,
>
> On Wed, Jan 25, 2012 at 5:43 PM, Kiyoto Tamura wrote:
>> vrana has raise a good point in a potentially dangerous behavior with
>> ini_set() in
. Can you elaborate
on the downside of the stricter check advocated by vrana?
Personally, I am ambivalent. I am just curious about the other side of the
argument.
Thanks,
Kiyoto Tamura
On Jan 25, 2012, at 7:33 PM, Chris Stockton wrote:
> Hello,
>
> On Wed, Jan 25, 2012 at 5:43 PM,
vrana has raise a good point in a potentially dangerous behavior with ini_set()
in https://bugs.php.net/bug.php?id=60668.
Here is my proposed patch. Feedback is appreciated. Thanks!
Kiyoto Tamura
diff --git a/Zend/zend_ini.c b/Zend/zend_ini.c
index a7ec5d7..89b1287 100644
--- a/Zend/zend_ini.c
s any expression at all)?
Kiyoto
2011/7/28 Johannes Schlüter :
> On Thu, 2011-07-28 at 16:10 -0700, Kiyoto Tamura wrote:
>> Hi,
>>
>> I am new to the PHP internals, and I was just looking through the code
>> related to parsing break/continue statements. It l
Hi,
I am new to the PHP internals, and I was just looking through the code
related to parsing break/continue statements. It looks that as of PHP
5.4, Zend/zend_language_parser.y accepts both "T_BREAK expr" and
"T_CONTINUE expr" and check to make sure "expr" is a positive integer
in the function ze
