Re: [PHP-DEV] Deprecate setlocale?

2015-04-02 Thread Keyur Govande
On Thu, Apr 2, 2015 at 3:55 PM, Ryan Pallas wrote: > > > On Thu, Apr 2, 2015 at 1:50 PM, Adam Harvey wrote: > >> On 2 April 2015 at 12:24, Dan Ackroyd wrote: >> > On 2 April 2015 at 16:01, Keyur Govande wrote: >> >> >> >> >> >> T

Re: [PHP-DEV] Deprecate setlocale?

2015-04-02 Thread Keyur Govande
On Thu, Apr 2, 2015 at 3:21 AM, Rasmus Lerdorf wrote: > On 04/01/2015 09:15 AM, Dan Ackroyd wrote: > > Hi, > > > > I'd like to get people's feedback for the idea of making setlocale be > > either deprecated and to be removed eventually or just increasing the > > warning level against people using

[PHP-DEV] [PATCH] Fixes for bugs #65463, #66036

2014-08-14 Thread Keyur Govande
Hello, I've opened https://github.com/php/php-src/pull/770 for patches for bugs #65463, #66036. More details in the PR. The bug is reproducible on PHP 5.4, 5.5 and 5.6 with and without --enable-zend-signals. Please review, I'm hesitant to merge such a core change without more eyes. Thanks, Keyu

Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-03-05 Thread Keyur Govande
On Fri, Feb 22, 2013 at 3:06 PM, Keyur Govande wrote: > On Fri, Feb 22, 2013 at 2:59 PM, Hannes Magnusson < > hannes.magnus...@gmail.com> wrote: > >> On Fri, Feb 22, 2013 at 11:52 AM, Rasmus Lerdorf >> wrote: >> > On 02/22/2013 11:48 AM, Hannes Magnusson wrote

Re: [PHP-DEV] [VOTE] Improved Linux process title support in the CLI SAPI

2013-02-22 Thread Keyur Govande
On Fri, Feb 22, 2013 at 2:59 PM, Hannes Magnusson < hannes.magnus...@gmail.com> wrote: > On Fri, Feb 22, 2013 at 11:52 AM, Rasmus Lerdorf > wrote: > > On 02/22/2013 11:48 AM, Hannes Magnusson wrote: > >> On Thu, Feb 21, 2013 at 4:42 PM, Keyur Govande > wrote: >

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Keyur Govande
On Fri, Feb 8, 2013 at 4:01 PM, Ferenc Kovacs wrote: > > > > On Fri, Feb 8, 2013 at 9:30 PM, Keyur Govande wrote: > >> On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse > >wrote: >> >> > Hi, >> > >> > could you rename these functions to

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-08 Thread Keyur Govande
On Fri, Feb 8, 2013 at 3:20 AM, Christoph Rosse wrote: > Hi, > > could you rename these functions to: > > cli_process_set_title > cli_process_get_title > > http://www.php.net/manual-**lookup.php?pattern=set_&scope=**quickref > gives

Re: [PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-07 Thread Keyur Govande
Addressing a bunch of comments at once: 1) I've removed is_available and renamed the set/get methods to: cli_process_title_set/get. I've also removed the test dependencies on pcntl and posix. The patch is updated: https://gist.github.com/keyurdg/4728770 2) Updated the RFC's introduction section wit

[PHP-DEV] [RFC] Improved Linux process title support in the CLI SAPI

2013-02-06 Thread Keyur Govande
Hello, I've created a new RFC to improve support for setting a CLI process' title on Linux. It is based off of the PostgreSQL implementation and is more robust than the proctitle extension. More details and patch here: https://wiki.php.net/rfc/cli_process_title Thanks, Keyur.