Re: [PHP-DEV] [Proposal] Add `savepoint()` method to PDO

2024-02-05 Thread Kentaro Takeda via internals
Hi Saki, Aside from a few concerns, I think your proposal is very sensible. I have long felt a disconnect that while we have `beginTransaction()`, `commit()`, and `rollback()` methods, there's no equivalent functionality for `SAVEPOINT` in PDO. It seems natural to support these commonly used tran

Re: [PHP-DEV] [PDO] 2 phase commit

2023-12-02 Thread Kentaro Takeda via internals
Hi Eugene. > 1. We have sent commit to the first database and it responded us with OK > (comitted) > 2. Next we send commit to the second database, and it may be the case that in > that very moment we lose connection. Hence, if connection is lost before > final commit request, second database w

Re: [PHP-DEV] Deprecate declare(encoding='...') + zend.multibyte + zend.script_encoding + zend.detect_unicode ?

2023-11-29 Thread Kentaro Takeda via internals
> The migration path is to convert the legacy-encoding PHP files to UTF-8. Please take a look at the following code. This is a part of the code that I am actually maintaining in the latest version of php. ```php https://www.php.net/unsub.php

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Kentaro Takeda via internals
Hi, Matteo > Regarding this past issue with PostgreSQL, it can be solved by > treating numbers larger than `int4` as `unknown` (as is the case now) > rather than as `int8` (as in previous attempts). I'm sorry, this was my mistake. select 1::boolean ; -- returns `t` select 1 = true ; -- `ERR

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-05 Thread Kentaro Takeda via internals
Hi, Matteo, > The last time I tried to fix the PDO_PARAM_INT behavior on pdo_pgsql I broke > Laravel and surely many other projects. > https://github.com/php/php-src/pull/6801 Thank you for providing an important example. Regarding this past issue with PostgreSQL, it can be solved by treating n

Re: [PHP-DEV] Fix the inconsistent behavior of PDO::PARAM_XXX

2023-11-04 Thread Kentaro Takeda via internals
Hi, internals. > As shown in the following issue, the behavior of `PDO::PARAM_` is > inconsistent and I would like to fix this. > https://github.com/php/php-src/issues/12603 I consider the current behavior a bug. And some of them contain behaviors that are very confusing to users. > It may b