[PHP-DEV] Re: FrankenPHP moving under the PHP GitHub organization

2025-05-15 Thread Kévin Dunglas
Hi, Here is the announcement published by the PHP Foundation, Les-Tilleuls.coop, and the Caddy team: https://les-tilleuls.coop/en/blog/frankenphp-is-now-officially-supported-by-the-php-foundation Best,

[PHP-DEV] VCS Account Request: dunglas

2025-03-25 Thread Kévin Dunglas
I already have GitHub access.

Re: [PHP-DEV] [RFC] Modern Compression (zstd, brotli)

2025-02-18 Thread Kévin Dunglas
ink about a well-designed high-level API. -- Kévin Dunglas https://dunglas.dev

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Kévin Dunglas
On Sun, Dec 22, 2024 at 10:44 AM Jakub Zelenka wrote: > Thinking about it, there might be a possibility to address it (at least on > Linux) using fanotify. Not sure about other platforms but maybe there are > some solutions to address it. Also it might get a bit complex and not sure > how much th

Re: [PHP-DEV] Debug Build Container Image for GitHub Packages

2024-09-02 Thread Kévin Dunglas
This would help the FrankenPHP project a lot! The build script used for the official images already contains an environment variable for creating variants containing debugging symbols: https://github.com/docker-library/php/blob/a15b1e1448d2f99db63f68dc4ce21da9a82f5aad/Dockerfile-linux.template#L40

Re: [PHP-DEV] State of Generics and Collections

2024-08-23 Thread Kévin Dunglas
Thanks for sharing this research work. Instead of having to choose between fully reified generics and erased type declarations, couldn't we have both? A new option in php.ini could allow to enable the “erased” mode as a performance, production-oriented optimization. In development, and on projects

Re: [PHP-DEV] Support for pkg-config .pc files

2024-08-14 Thread Kévin Dunglas
Having pkg-config support would allow us to simplify the build process of FrankenPHP. Cgo (as many other tools) has native support for pkg-config. We'll remove many hardcoded paths that are difficult to override for end users. FrankenPHP doesn't use the embed SAPI, but does rely on libphp to provi

Re: [PHP-DEV] Switching max_execution_time from CPU time to wall-clock time and from SIGPROF to SIGALRM

2024-05-21 Thread Kévin Dunglas
Hello, I'm in favor of merging Arnaud's patch for macOS while waiting for a better solution like relying on Grand Central Dispatch or another non-signal-based solution (https://github.com/php/php-src/pull/13468), which would allow max_execution_time to work with ZTS builds on mac as well. I'm als

[PHP-DEV] Re: [proposal] max_execution_time to a negative number

2024-04-11 Thread Kévin Dunglas
According to "man 2 setitimer", the same error should happen on Linux even without zend_max_execution_timer: https://github.com/php/php-src/blob/2079da0158bc91fff4edd85ac66c89b40c4faf3a/Zend/zend_execute_API.c#L1566 A C error will also occur if the value is superior to 999,999,999. We should at l

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-04 Thread Kévin Dunglas
Data classes will be a very useful addition to "API Platform". API Platform is a "resource-oriented" framework that strongly encourages the use of "data-only" classes: we use PHP classes both as a specification language to document the public shape of web APIs (like an OpenAPI specification, but w

Re: [PHP-DEV] php-src docs

2024-02-11 Thread Kévin Dunglas
I strongly support this initiative. When I started writing SAPI (even though I already had some experience with the PHP code base), I spent a lot of time reading scattered articles on the subject, many of which were incomplete or outdated. Having a centralized place to search and contribute wo

[PHP-DEV] Re: RFC proposal: worker mode primitives for SAPIs

2024-01-04 Thread Kévin Dunglas
> Le 4 janv. 2024 à 18:21, Joanhey a écrit : > > Hi, > > I like it for start a discussion, than it's necessary. > But we need to see the big picture. > > The CLI-SAPI is the poor brother in PHP (contrary to other languages), but > that is another discussion than I'll try to open later. > >

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-31 Thread Kévin Dunglas
On Sun, Dec 31, 2023 at 2:20 AM Rowan Tommins wrote: > On 30 December 2023 19:48:39 GMT, Larry Garfield > wrote: > >The Franken-model is closer to how PHP-FPM works today, which means that > is easier to port existing code to, especially existing code that has lots > of globals or hidden globals

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-29 Thread Kévin Dunglas
On Fri, Dec 29, 2023 at 8:14 PM Rowan Tommins wrote: > - FrankenPHP expects the user to manage the main event loop, repeatedly > passing the server a function to be called once; it doesn't pass > anything into or out of the userland handler, instead resetting global > state to mimic a non-worker

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-25 Thread Kévin Dunglas
On Mon, Dec 25, 2023 at 7:56 PM Jordan LeDoux wrote: > > > On Mon, Dec 25, 2023 at 8:19 AM Kévin Dunglas wrote: > >> >> On Sun, Dec 24, 2023 at 10:44 PM Jordan LeDoux >> wrote: >> >>> >>> >>> On Sat, Dec 23, 2023 at 12

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-25 Thread Kévin Dunglas
On Mon, Dec 25, 2023 at 6:30 PM Jakub Zelenka wrote: > > > On Mon, Dec 25, 2023 at 12:34 PM Kévin Dunglas wrote: > >> On Sun, Dec 24, 2023 at 4:21 PM Larry Garfield >> wrote: >> >> In practice, I want to understand the implications for user-space co

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-25 Thread Kévin Dunglas
> Forgive my ignorance, but why no connection? You mean the > pre-worker-start part needs to avoid an SQL connection? Why is that? That > would be something that needs to be super-well documented, and possibly > some guards in place to prevent it, if there's no good way around it. > (This is the

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-25 Thread Kévin Dunglas
On Sun, Dec 24, 2023 at 10:44 PM Jordan LeDoux wrote: > > > On Sat, Dec 23, 2023 at 12:34 PM Kévin Dunglas wrote: > >> Hello and Merry Christmas! >> >> One of the main features of FrankenPHP is its worker mode, which lets you >> keep a PHP application in mem

Re: [PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-25 Thread Kévin Dunglas
On Sun, Dec 24, 2023 at 4:21 PM Larry Garfield wrote: In practice, I want to understand the implications for user-space code. > Does this mean FPM could be configured in a way to execute a file like that > shown in the docs page above? Or would it only work with third party SAPIs > like FrankenP

[PHP-DEV] RFC proposal: worker mode primitives for SAPIs

2023-12-23 Thread Kévin Dunglas
ere: https://frankenphp.dev/docs/worker/#custom-apps I'd like to hear what the community thinks about this. Would you be interested in this functionality in PHP? Should I work on an RFC? If there's interest, I can work on a patch. Cheers, -- Kévin Dunglas

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Kévin Dunglas
This change seems reasonable to me: safer, with little chance of breaking things, and easy to reverse for the end user by changing a single parameter.

[PHP-DEV] Bad interactions between Fibers and GoRoutines (and/or cgo)

2023-08-18 Thread Kévin Dunglas
Does anyone have any idea what's going on? Best regards, -- Kévin Dunglas

[PHP-DEV] Proposal to incrementally improve timeout and signal handling

2022-10-20 Thread Kévin Dunglas
both? (pardon my ignorance of internals processes). Thank you, -- Kévin Dunglas

[PHP-DEV] Set SA_ONSTACK in zend_sigaction External

2022-09-22 Thread Kévin Dunglas
fix (having the ability to call Go/C++ VM code from PHP and embed PHP in such programs), should I open an RFC? Also, if merging my patch is considered, which branch should I target? Cheers, -- Kévin Dunglas

[PHP-DEV] Add support for ::class to constant()

2021-03-09 Thread Kévin Dunglas
Hi folks, Currently, it's not possible to use the ::class special constant with the constant() function. This doesn't work: var_dump( constant('\DateTime::class') ); For instance, Twig's constant() helper internally uses this PHP function, consequently the following Twig template doesn't work:

[PHP-DEV] Re: hash_equals: leak less information about length

2015-01-06 Thread Kévin Dunglas
misuses in the wild). To summarize: a theoretical (especially for web apps, more annoying for CLI apps) and advertised leak is better than a big undocumented leak. Can you merge this PR? 2014-08-31 12:59 GMT+02:00 Kévin Dunglas : > Hi, > > I've submitted a PR to make the hash_equ

Re: [PHP-DEV] Fixed Bug #65576 (Constructor from trait conflicts with inherited constructor)

2014-12-08 Thread Kévin Dunglas
t behavior? Can you provide some > rationale for why it should happen this way? > -- Kévin Dunglas Consultant et développeur freelance http://dunglas.fr Tél. : 06 60 91 20 20

[PHP-DEV] Fixed Bug #65576 (Constructor from trait conflicts with inherited constructor)

2014-12-08 Thread Kévin Dunglas
Hi, I've published a patch for bug #65576 : https://github.com/php/php-src/pull/946 Can you review it and merge it please ? Best regards. -- Kévin Dunglas http://dunglas.fr http://les-tilleuls.coop

[PHP-DEV] Re: IDN support in streams

2014-11-14 Thread Kévin Dunglas
:00 Kévin Dunglas : > Hello, > > I've submitted a PR to add IDN support in PHP streams. The way it's done > will allow easy IDN domain validation in ext/filter too. > > Can you review this PR please? > > https://github.com/php/php-src/pull/890 > > -- >

Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-11-14 Thread Kévin Dunglas
27;s current state for now. Do you guys are OK to get the current PR merged? 2014-11-12 19:10 GMT+01:00 Kévin Dunglas : > Hi Yasuo, > > I've not changed (and even read) the email validator. I'll take a look at > it. > > 2014-11-12 10:41 GMT+01:00 Yasuo Ohgaki : >

Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-11-12 Thread Kévin Dunglas
Hi Yasuo, I've not changed (and even read) the email validator. I'll take a look at it. 2014-11-12 10:41 GMT+01:00 Yasuo Ohgaki : > Hi Kevin, > > On Wed, Nov 12, 2014 at 4:09 PM, Kévin Dunglas wrote: > >> I'll change my PR according to the RFC I'v

Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-11-11 Thread Kévin Dunglas
actually in all the DKIM RFCs and in the formal STD 76, >> see § 3.6.2.1. Namespace, so it's more than a convention! > > > "_" is used for service name. Active Directory uses "_" a lot, for > example. e.g. _tcp, _sites, _ldap, etc. > > https://tools

Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-11-06 Thread Kévin Dunglas
00 ; serial 21600 ; refresh (6 hours) 3600 ; retry (1 hour) 604800 ; expire (1 week) 86400 ; minimum (1 day) ) 2014-11-06 13:55 GMT+01:00 Andrey Andreev : > Hi, > > On Thu, Nov 6, 2014 at 8:19 AM, Kévin Dunglas wrote: > > Hi Andrey, > > > > Sorry but I think you'

Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-11-05 Thread Kévin Dunglas
com." http://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names You can also see this StackOverflow answer http://stackoverflow.com/a/2183140/1352334 2014-11-06 0:32 GMT+01:00 Andrey Andreev : > Hi, > > On Wed, Nov 5, 2014 at 11:57 PM, Kévin Dunglas wrot

Re: [PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-11-05 Thread Kévin Dunglas
.org > > On Tue, Oct 14, 2014 at 3:41 PM, Kévin Dunglas wrote: >> >> Hi, >> >> I opened a PR making FILTER_VALIDATE_URL more strict and more compliant >> with standards: https://github.com/php/php-src/pull/826 >> >> Can anyone review (and merge) this p

[PHP-DEV] IDN support in streams

2014-11-04 Thread Kévin Dunglas
Hello, I've submitted a PR to add IDN support in PHP streams. The way it's done will allow easy IDN domain validation in ext/filter too. Can you review this PR please? https://github.com/php/php-src/pull/890 -- Kévin Dunglas Consultant et développeur freelance http://dunglas.fr Té

Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL

2014-10-15 Thread Kévin Dunglas
, we have > to be careful to do not break things out there, for example someone > relying on it to process URI/URL. > > Cheers, > -- > Pierre > > @pierrejoye | http://www.libgd.org > -- Kévin Dunglas Consultant et développeur freelance http://dunglas.fr Tél. : 06 60 91 20 20

[PHP-DEV] Better RFC conformance for FILTER_VALIDATE_URL

2014-10-14 Thread Kévin Dunglas
Hi, I opened a PR making FILTER_VALIDATE_URL more strict and more compliant with standards: https://github.com/php/php-src/pull/826 Can anyone review (and merge) this patch? Thanks! -- Kévin Dunglas Consultant et développeur freelance http://dunglas.fr Tél. : 06 60 91 20 20

Re: [PHP-DEV] #68049 filter_var echo wrong result for a url

2014-09-22 Thread Kévin Dunglas
od idea indeed, > `FILTER_VALIDATE_UNCOMPLIANT_URL` sounds good enough? > > I guess it should accept underscores and domain names starting with > numbers too. > > Regards, > > *Florian Margaine* > > P.S: sorry Kevin for the double mail. > Le 22 sept. 2014 09:03, "Kévin Dunglas

Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL

2014-09-22 Thread Kévin Dunglas
I'll implement optional (and not default) support of IDN in filter_var(). Does anyone known if it's better to use libIDN (LGPL) or ICU (custom license deviated from the X license) from a license point of view? 2014-09-19 16:18 GMT+02:00 Chris Wright : > On 19 September 2014 14:48,

Re: [PHP-DEV] #68049 filter_var echo wrong result for a url

2014-09-22 Thread Kévin Dunglas
8049 > > The thing is, browsers *do* accept the underscore in URLs. Should the > rfc3986 <http://tools.ietf.org/html/rfc3986#section-3.2.2> be respected, > or > should PHP be lenient like browsers and accept more? > > Regards, > > *Florian Margaine* > -- Kévin Dungl

Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL

2014-09-19 Thread Kévin Dunglas
he doc explaining the new behavior. 2014-09-19 12:28 GMT+02:00 Chris Wright : > On 19 September 2014 10:58, Pierre Joye wrote: > > Hi, > > > > On Sep 19, 2014 4:03 PM, "Chris Wright" wrote: > >> > >> Kévin > >> > >> On 1

[PHP-DEV] Re: Internationalized Domain Name support in FILTER_VALIDATE_URL

2014-09-18 Thread Kévin Dunglas
gt; On 19 Sep 2014, at 06:52, Andrea Faulds > wrote: > > > > > On 18 Sep 2014, at 21:26, Kévin Dunglas > wrote: > > > >> I'm working on enhancing the FILTER_VALIDATE_URL filter ( > >> https://github.com/php/php-src/pull/826). > &

[PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL

2014-09-18 Thread Kévin Dunglas
port of IDN validation can be easily added using ICU's uidna_toASCII() function. Is it acceptable to add a dependency to ICU for ext/filter? Another option is to add a HAVE_ICU constant in main/php_config.h and to validate IDN only if ICU is present. What strategy is preferred? -- Kév

[PHP-DEV] hash_equals: leak less information about length

2014-08-31 Thread Kévin Dunglas
use some tricks from the CPython one ( https://github.com/python/cpython/blob/c7688b44387d116522ff53c0927169db45969f0e/Modules/_operator.c#L175 - use of volatile and no modulo). Best regards, -- Kévin Dunglas http://dunglas.fr