What did we decide to do about this patch? I noticed that it never got any
feedback about the actual patch. Could someone take a look?
Thanks!
Ilia
On Sun, Sep 28, 2008 at 4:48 PM, Ilia Cheishvili
<[EMAIL PROTECTED]>wrote:
> There is a bug in stream_filter_remove() that calls t
No problem, I'm do that right now. I'll follow this process in the future,
too :)
Thanks Pierre!
Ilia
On Sun, Sep 28, 2008 at 4:58 PM, Pierre Joye <[EMAIL PROTECTED]> wrote:
> On Mon, Sep 29, 2008 at 12:57 AM, Ilia Cheishvili
> <[EMAIL PROTECTED]> wrote:
> >
Sorry for that! I transposed two characters. The right bug # is 46164.
I'll add the patch to the bug as well.
Ilia
On Sun, Sep 28, 2008 at 4:54 PM, Pierre Joye <[EMAIL PROTECTED]> wrote:
> hi Ilia!
>
> On Mon, Sep 29, 2008 at 12:48 AM, Ilia Cheishvili
> <[EMAIL PROTE
There is a bug in stream_filter_remove() that calls the stream destructor
when it shouldn't. I have included two attachments--one is the patch to
streamsfuncs.c and the other is a test.
Take a look :)
Ilia
Index: streamsfuncs.c
===
.
Thanks for the back and forth thus far :)
Ilia
On Sat, Sep 27, 2008 at 3:21 AM, Alexey Zakhlestin <[EMAIL PROTECTED]>wrote:
> On Sat, Sep 27, 2008 at 12:26 PM, Ilia Cheishvili
> <[EMAIL PROTECTED]> wrote:
> > Ah, I see. I like that even better :)
> > And I attached yet a
Ah, I see. I like that even better :)
And I attached yet another patch that incorporates your idea.
Ilia
On Sat, Sep 27, 2008 at 2:20 AM, Alexey Zakhlestin <[EMAIL PROTECTED]>wrote:
> On Sat, Sep 27, 2008 at 12:04 PM, Ilia Cheishvili
> <[EMAIL PROTECTED]> wrote:
> > It
exey Zakhlestin <[EMAIL PROTECTED]>wrote:
> On Sat, Sep 27, 2008 at 11:04 AM, Ilia Cheishvili
> <[EMAIL PROTECTED]> wrote:
> > Hi all,
> > This patch addresses the issue with the date() function. When passing in
> a
> > 'u', the date() function simp
I would definitely have to agree. I would much prefer to have a minimal
solution implemented and then to iterate over it in the future than to try
to figure out the perfect implementation the first time.
Just from watching where the thread about namespaces has gone, I would
definitely have to say
Hi all,
This patch addresses the issue with the date() function. When passing in a
'u', the date() function simply outputs six zeros. To fix this, I added a
gettimeofday() call that figures out what to display for microseconds. I am
including the headers and using the function with pre-processor
t 12:27 AM, Jani Taskinen <[EMAIL PROTECTED]>wrote:
> Ilia Cheishvili wrote:
>
>> Hey all,
>>
>> This patch addresses the *printf() bug when dealing with exponents (%e).
>> See http://bugs.php.net/bug.php?id=46145 for more details.
>>
>> The patch
Hey all,
This patch addresses the *printf() bug when dealing with exponents (%e).
See http://bugs.php.net/bug.php?id=46145 for more details.
The patch is large because there were a lot of unit tests written to expect
the wrong behavior, so I had to update them. I realize that there is the
possib
As far as I know, it's still underway. Andi explained at ZendCon this year
how it will take a few more months--he made it clear that PHP has a very
rich development history that no one wants to lose. I, for one, am looking
forward to when the migration is finally complete, as I am so much more us
Hi all,
My name is Ilia--I figured that since this is my first patch to the PHP
core, I should refrain from submitting a massive patch and keep it simple.
The patch that I have attached fixes a simple compiler warning within
Zend/zend_execute.c.
The compiler was complaining about comparing signed
13 matches
Mail list logo
