Re: [PHP-DEV] [PATCH] ext/snmp/snmp.c memleaks

2007-07-05 Thread Gustaf Gunnarsson
Hi, thank you for reviewing my patch. Antony Dovgal wrote: Are you sure this part of the patch is correct? Yes [[ cut away code ]] First you free the pdu and then go to the retry label which uses it and then frees it again on failure. You misunderstund. status = snmp_synch_respo

[PHP-DEV] [PATCH] ext/snmp/snmp.c memleaks

2007-06-20 Thread Gustaf Gunnarsson
Hi, the following patch fixes memory leaks in the snmp module. Diff against PHP 5.2 CVS branch. I'd also like to supply a patch later adding support for multiple set/get operations in one PDU. I'd like not to use php_snmp_internal() function for my new operations because I think that function