Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-12 Thread Greg MacLellan
Wez Furlong wrote: If you can make that change and then either put the diff online, or as a regular MIME plain text attachment and not inlined, so that it is easy to get at without it being mangled in the email, I will apply it to CVS. Done. It actually didn't come out mangled for me at all (mo

Re: [PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-12 Thread Greg MacLellan
Wez Furlong wrote: Two or three comments: - You leak the dynamically allocated buffer returned by X509_NAME_oneline() - X509_NAME_oneline() man page says that its use is discouraged in favour of smarter functions. Is there a possibility that someone will need that functionality? - if you can solve

[PHP-DEV] Fwd: [PATCH] added: openssl_csr_subject()

2004-10-08 Thread Greg MacLellan
CSR. Uses the same CSR handling routines as openssl_csr_sign() etc, so it can take a string in PEM format, a file, whatever. Prototype: string openssl_csr_subject(mixed csr) Sample return value: string(99) "/C=CA/ST=Ontario/L=Kingston/O=Greg MacLellan/OU=PHP/CN=CSR Test/[EMAIL PROTECTED]"

[PHP-DEV] [PATCH] added: openssl_csr_subject()

2004-10-08 Thread Greg MacLellan
(99) "/C=CA/ST=Ontario/L=Kingston/O=Greg MacLellan/OU=PHP/CN=CSR Test/[EMAIL PROTECTED]" -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Proposal: Array syntax

2003-11-05 Thread Greg MacLellan
nd it's totally unfeasable to remove the array() syntax. Also, the fact that [] are used for array indexes means it's more confusing when they're also used in a very similar context of defining the actual array. Marco's example $a = [1,2,$b[11]]; I think best illustrates

[PHP-DEV] [PATCH] DIO: Flow control, Modem info, Read waiting

2003-10-29 Thread Greg MacLellan
erduck" http://www.itwatchdogs.com/duckdetails.shtml ttyl, greg -- Greg MacLellan Index: php-src/ext/dio/dio.c === RCS file: /repository/php-src/ext/dio/dio.c,v retrieving revision 1.21.2.3 diff -u -r1.21.2.3 dio.c --- php-src

Re: [PHP-DEV] argv and argc on cliphp

2003-10-06 Thread Greg MacLellan
> > That was my argument. I was saying that instead of ALWAYS creating $argv and > > $argc, regardless of register_global status, it should ALWAYS create > > $_SERVER['argv'] and $_SERVER['argc'], regardless of variables_order > > setting. > > My big problem with this approach is that when variable

Re: [PHP-DEV] argv and argc on cliphp

2003-10-06 Thread Greg MacLellan
> > > You're not breaking code (since it can always use $_SERVER) and you're > > > not introducing any globals (which goes along with the register_globals > > > setting). > > > >Sure you are, you are creating the global $_SERVER which was specifically > >not enabled in your scenario. > > I may be m

Re: [PHP-DEV] argv and argc on cliphp

2003-10-03 Thread Greg MacLellan
Rasmus Lerdorf wrote: Andrei and I discussed this change and at the conceptual level at least $_SERVER should be populated with argc and argv if variables_order includes "S". If you have specifically configured your system to not create $_SERVER, then of course it shouldn't be there. The chang

[PHP-DEV] PATCH: get modem status (direct io)

2003-09-17 Thread Greg MacLellan
ded on the serial control lines). A test script is also attached. Btw, this is my first attempt at both working on PHP itself, and submitting a patch. If anything here is wrong, let me know! :p ttyl, greg -- Greg MacLellan ? autom4te-2.53.cache ? dio_modemget.patch ? dio_modemget.patch.2 Index: ext/d