Re: [PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-12-31 Thread Giovanni Giacobbi
On Tue, Dec 31, 2024, 13:42 Christoph M. Becker wrote: > On 11.07.2024 at 11:35, Giovanni Giacobbi wrote: > > > The recent PR #14877 [1] proposes to add the imagecompare gd function > that > > mimics the gdImageCompare function from libgd. I always thought that a > &

Re: [PHP-DEV] Require C11 in PHP 8.4

2024-08-11 Thread Giovanni Giacobbi
generally > > fine with bumping the requirements to C11, except for Giovanni Giacobbi > > (whose draft PR[2] had no further discussion so far), and maybe for some > > uncertainties regarding some less used compilers. > > Giovanni's remark that this would impact many people was

Re: [PHP-DEV] Require C11 in PHP 8.4

2024-08-02 Thread Giovanni Giacobbi
On Thu, 1 Aug 2024 at 23:57, Ilija Tovilo wrote: > [...] > I started fixing these in a PR [1] which required more changes than > expected. After a short discourse, we were wondering whether it might > be better to switch to a newer C standard instead. Our coding > standards [2] currently specify

[PHP-DEV] ext/gd new imagematch function (was: adding imagecompare)

2024-07-11 Thread Giovanni Giacobbi
The recent PR #14877 [1] proposes to add the imagecompare gd function that mimics the gdImageCompare function from libgd. I always thought that a pixel-by-pixel matching function for two images was a big missing feature in PHP, as the corresponding userland implementation is really, REALLY slow. T

Re: [PHP-DEV] PHP 8 Release Announcement Page

2021-11-19 Thread Giovanni Giacobbi
On Fri, 19 Nov 2021 at 10:13, Pierre wrote: > Le 19/11/2021 à 10:10, Kamil Tekiela a écrit : > > I would suggest option number 5. Leave it as it is. Many people are still > > not aware that PHP 8 has been released. > > If that's not possible, then we should keep the page (opt 3), otherwise > we >

Re: [PHP-DEV] PHP 7.2.0 RC6 Released

2017-11-09 Thread Giovanni Giacobbi
On 9 November 2017 at 18:46, Thomas Hruska wrote: > On 11/9/2017 7:36 AM, Sara Golemon wrote: > >> The sixth (and likely final) release candidate for 7.2.0 was just >> released and can be >> downloaded from: >> https://downloads.php.net/~pollita/ >> Or using the git tag: php-7.2.0RC6 >> >> Barrin

Re: [PHP-DEV] PCRE JIT broken in PHP 7.2

2017-09-18 Thread Giovanni Giacobbi
On 18 September 2017 at 19:04, Dmitry Stogov wrote: > This commit should fix the problem https://github.com/php/php-src/commit/ > 5ef10d08ec2d0823fb21ad189dacfb43d900a0b5 > > > Yes! I tested 7.2.0RC2 with this patch applied and it fixes the problem. Thank you!

Re: [PHP-DEV] PCRE JIT broken in PHP 7.2

2017-09-18 Thread Giovanni Giacobbi
On 18 September 2017 at 13:46, Dan Ackroyd wrote: > On 18 September 2017 at 12:28, Giovanni Giacobbi > wrote: > > > > just an heads up, I started testing my project with PHP 7.2.0RC2 but it > was > > causing a segmentation fault. > > Even if you think bu

[PHP-DEV] PCRE JIT broken in PHP 7.2

2017-09-18 Thread Giovanni Giacobbi
mp(preg_match('/a/', "a")); => segmentation fault If you need any further information let me know. Kind regards -- Giovanni Giacobbi

Re: [PHP-DEV] json_encode() / json_decode() warnings

2017-07-28 Thread Giovanni Giacobbi
ll; $retval = json_decode($json, true, 512, JSON_BIGINT_AS_STRING); if (json_last_error() != JSON_ERROR_NONE) throw new JsonDecodeException(json_last_error_msg(), json_last_error()); return $retval; } ``` So yes, the behaviour of json_decode() might not be optimal, but it's fine the way it is. -- Giovanni Giacobbi

Re: [PHP-DEV] Add is_vectorlike($array) function

2017-05-02 Thread Giovanni Giacobbi
On 2 May 2017 at 11:55, Rowan Collins wrote: > On 02/05/2017 10:13, Jesse Schalken wrote: > >> Related to the optimisation made by Sara Golemon here: >> https://github.com/php/php-src/commit/c74bc87c74f48bc55541b3 >> bf2fc67d595f58a3b5 >> >> I often define a function like this, which checks if an

Re: [PHP-DEV] Allow "static" type

2017-01-28 Thread Giovanni Giacobbi
hizing on the direction PHP had taken the past years (good old times when the strict type hinting was rejected because it made it too complicated for newcomers, lol). Cheers -- Giovanni Giacobbi

[PHP-DEV] String to array odd behaviour in 7.1

2017-01-25 Thread Giovanni Giacobbi
Greetings, There is something weird with 7.1 and implicit strings to array conversions, so I wanted to double check with you that the behaviour is wanted (and perhaps the migration71 doc should be updated to reflect this. So in the migration docs [1] you say that: " Applying the empty index opera

Re: [PHP-DEV] Explicit constructor call and polymorphic dispatch

2017-01-15 Thread Giovanni Giacobbi
o you guys can fry me in another thread :P On 15 January 2017 at 07:06, Wes wrote: > you guys went slightly off topic :P > -- Giovanni Giacobbi

Re: [PHP-DEV] Explicit constructor call and polymorphic dispatch

2017-01-14 Thread Giovanni Giacobbi
"Fleshgrinder" Fussenegger > > IMHO it already IS safe. > > In PHP 4 the "constructor" was a method thad had the same name as the > class. But now it is a class that has always the same name and is always > preceded with two underscores. There is no way to "accidentaly" call that > method. You have to explicitly call "__construct" to "break" things. > > If developers "want" to break something they will find a way. Protecting > "__construct" will not stop them from doing so. But it will stop the rest > of us do legitimate things. > > Cheers > > Andreas > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Giovanni Giacobbi

Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-12 Thread Giovanni Giacobbi
I want to thank Markus and Björn for getting me up to speed with the pointers. Please see the rest of my response below. On 11 January 2016 at 15:05, Rowan Collins wrote: > Giovanni Giacobbi wrote on 11/01/2016 13:31: > >> set_exception_handler(callback function, bool also_throwa

[PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code

2016-01-11 Thread Giovanni Giacobbi
Greetings, Short premise before I get flamed: I know PHP 7 is rolling and it is way too late for this, that I should've tested the RCs, follow the mailing list and so on, but I'm a dev like you guys and struggle with the time to do everything by the book, including reading the previous threads bec

Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-03 Thread Giovanni Giacobbi
On Sun, Jul 3, 2011 at 22:42, Antony Dovgal wrote: > On 07/03/2011 04:50 AM, Giovanni Giacobbi wrote: >> >> Detailed changelog of the patch: >> - Renamed options "pm.status_path", "ping.path", "ping.response" into >> a new

[PHP-DEV] Re: Big patch for FPM (config and initialization)

2011-07-03 Thread Giovanni Giacobbi
Sorry I always forget this mailing list is "special" and strip my attachments... Here is a link: http://pastebin.com/7JpXr22c On Sun, Jul 3, 2011 at 02:50, Giovanni Giacobbi wrote: > Greetings dear devs! > > A few days ago I made my first nginx+php-fpm setup, and I soon >

[PHP-DEV] Big patch for FPM (config and initialization)

2011-07-02 Thread Giovanni Giacobbi
me if you accept this patch: 1) allow '$pool' variable to be used in the [globals], but this requires a bit of restructuring because it needs to be lazy-expanded in post process time instead of parsing time. 2) possibility to include more than one file per section Looking forward to have

Re: [PHP-DEV] BC break in 5.3.2 -> 5.3.3 with "parent::" and __call/__callStatic

2010-10-24 Thread Giovanni Giacobbi
However, being actually non-defined, we need to choose between __call() and __callStatic(), and i think that number 2 is the only applicable criteria. Note that for my problem, reverting commit 295706 in branch PHP_5_3 is enough to fix my problem, but it would break again 51176. As this is

[PHP-DEV] BC break in 5.3.2 -> 5.3.3 with "parent::" and __call/__callStatic

2010-10-24 Thread Giovanni Giacobbi
aviour, which sounds very reasonable, and maybe introduce another way when you actually want to get rid of the context, something like static:: -- Giovanni Giacobbi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Giovanni Giacobbi
s a single error channel, with the exception of E_ALL and possibly E_NONE if it gets added. I would avoid adding more E_* constants which don't represent a single channel. I would find it confusing. 2c -- Giovanni Giacobbi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Type hinting - Request for Discussion

2009-07-10 Thread Giovanni Giacobbi
for debugging (in fact I always have to debug_backtrace() to find something useful). There is NO ambiguity with current type hinting, you can still have classes with the same name: class is_int { } function StandardHint(is_int $a); IDEs can still act smart because is_int() is a PHP standard func

Re: [PHP-DEV] Type hinting - Request for Discussion

2009-07-10 Thread Giovanni Giacobbi
is gives the perfect freedom to the developers and makes everyone happy. I know your concerns about third party libraries that you might have to deal with, but if you trigger one of those errors, then it means you are not respecting the APIs, which means there is a bug in your application.

Re: [PHP-DEV] 5.3.0 stable delayed until next Tuesday

2009-06-24 Thread Giovanni Giacobbi
h to push out an RC5 and release it as 5.3.0 only changing the version number between them? I saw other projects doing this and I think it helps to prevent major issues due to last-time fixes. I have this feeling that 5.3.0 release is going to be traumatic! Just my 2 cents. -- Giovanni Giacob

Re: [PHP-DEV] PHP 5.2.10

2009-05-15 Thread Giovanni Giacobbi
extensions). > > I think we should allow this change. > Sorry if I'm not getting this right, but doesn't he have to explicitly require version >= 5.2.10 in his pecl/memcached extension? It's not like that with this change his extension is going to work for 5.2.x.

Re: [PHP-DEV] Bug in HTTP stream context causes problems in SoapClient/get_sdl()

2009-01-25 Thread Giovanni Giacobbi
P is opening a raw socket and communicating on its own with Apache#2 (the one outputting the wsdl with chunked encoding). Thus PHP has to deal with this by itself, you cannot consider it a misconfiguration of Apache#2, because it is legitimately using the HTTP protocol. -- Giovanni Giacobbi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Bug in HTTP stream context causes problems in SoapClient/get_sdl()

2009-01-25 Thread Giovanni Giacobbi
1.1); php_stream_context_set_option(context, "http", "protocol_version", http_version); zval_ptr_dtor(&http_version); smart_str_appendl(&headers, "Connection: close", sizeof("Connection: close")-1); } +#endif if (headers.len > 0) { zval *str_headers; Regards -- Giovanni Giacobbi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] prototyping

2009-01-15 Thread Giovanni Giacobbi
process. The benefits? Nobody (but me...) would install an unstable version of PHP in a production environment, but probably some people would taste an experimental feature included in a stable version. Just my 2 cents. Regards, -- Giovanni Giacobbi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] SOAP extension and object records

2008-03-08 Thread Giovanni Giacobbi
s NOT minOccurs="0" in Product's element definition. Am I doing something wrong? Thank you -- Giovanni Giacobbi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] 4.3.2RC4: patch for php.ini-dist and php.ini-recommended

2003-05-27 Thread Giovanni Giacobbi
but i couldn't find an email address where to direct ready patches for CVS. (maybe you should write it in the package documentation?) Regards -- Giovanni Giacobbi --- php-4.3.2RC4/php.ini-dist.orig Thu May 8 03:23:35 2003 +++ php-4.3.2RC4/php.ini-dist Tue May 27 17:08:04 2003 @@ -67,7 +67,7 @@ ;