line2"
bool(false)
-Original Message-
From: Stanislav Malyshev [mailto:s...@zend.com]
Sent: Wednesday, September 09, 2009 2:59 PM
To: Garrett Serack
Cc: 'PHP Internals'
Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek
does not work correctly)
(6) "line1
"
string(6) "line2
"
string(6) "line2
"
bool(false)
Both pre- and post- patch, the stream_get_line doesn't work right with the bz
stream. I get the first read ok, then subsequent ones don't work.
fgets() works perfectly fine ho
ior.
G
-Original Message-
From: Stanislav Malyshev [mailto:s...@zend.com]
Sent: Thursday, September 03, 2009 5:31 PM
To: Garrett Serack
Cc: 'PHP Internals'
Subject: Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek
does not work correctly)
Hi!
> it
I'll have to wait till next week to write those. No Problem.
G
-Original Message-
From: Pierre Joye [mailto:pierre@gmail.com]
Sent: Thursday, September 03, 2009 2:16 PM
To: Garrett Serack
Cc: Hans Åhlin; internals@lists.php.net
Subject: Re: [PHP-DEV] Fix for 49148 (combinati
Ah, no. That is correctly handled. (the default max line length is 8k), and
passing in a larger number works just fine.
G
-Original Message-
From: Garrett Serack
Sent: Thursday, September 03, 2009 1:32 PM
To: Garrett Serack; Hans Åhlin; internals@lists.php.net
Subject: RE: [PHP-DEV] Fix
Ah, I found another case... when the line length is longer than the read
buffer. I'll post again in a few minutes.
G
-Original Message-
From: Garrett Serack [mailto:garre...@microsoft.com]
Sent: Thursday, September 03, 2009 1:22 PM
To: Hans Åhlin; internals@lists.php.net
Subjec
Without the patch, That is what will you see (windows or linux). (Which is
wrong...)
The patch corrects the case where the stream has been fseek'd to the last line
in the file, when the last line doesn't end with a line terminator. (where you
see 'false' in the results).
Without the patch, the
it happens on Linux and Windows. I've repro'd it in both places.
The bug submitter hadn't tested elsewhere.
G
-Original Message-
From: Stanislav Malyshev [mailto:s...@zend.com]
Sent: Wednesday, September 02, 2009 2:15 PM
To: Garrett Serack
Cc: 'PHP Internals'
S
I finally got to the bottom of this bug. It was hiding nice and deep.
I thought I'd run this by folks first before committing, as it impacts streams,
which are pretty important :D . It passes the current tests, and I wrote test
for it too. (below).
Index: main/streams/streams.c
G
-Original Message-
From: Stanislav Malyshev [mailto:s...@zend.com]
Sent: Wednesday, August 19, 2009 2:40 PM
To: Garrett Serack; Pierre
Cc: 'PHP Internals'
Subject: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS
branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/t
Howdy,
In response to Bug #48911(http://bugs.php.net/bug.php?id=48911), revision
286468 adds SAPI_API to
int php_embed_init(int argc, char **argv PTSRMLS_DC);
void php_embed_shutdown(TSRMLS_D);
extern sapi_module_struct php_embed_module;
Which breaks building the php5embed on Windows.
Hey Christian,
Uh, my fault false alarm.
The fix that went in a while back did indeed fix the problem.
Garrett
-Original Message-
From: Christian Seiler [mailto:chris...@gmx.net]
Sent: Saturday, June 13, 2009 11:01 AM
To: Pierre Joye
Cc: php-dev List
Subject: Re: [PHP-DEV] float
Developing the PHP Runtime (+Pecl,+APC,+Build scripts) on Windows
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
13 matches
Mail list logo
